Mailing-List: contact notifications-help@groovy.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@groovy.apache.org
From: jwagenleitner <git@git.apache.org>
To: notifications@groovy.apache.org
Reply-To: notifications@groovy.apache.org
References: <git-pr-440-groovy@git.apache.org>
In-Reply-To: <git-pr-440-groovy@git.apache.org>
Subject: [GitHub] groovy pull request #440: Groovy-7961 : NoSuchElementException
Content-Type: text/plain
Message-Id: <20161007011935.C492EE02E4@git1-us-west.apache.org>
Date: Fri,  7 Oct 2016 01:19:35 +0000 (UTC)
archived-at: Fri, 07 Oct 2016 01:19:37 -0000

Github user jwagenleitner commented on a diff in the pull request:

    https://github.com/apache/groovy/pull/440#discussion_r82316120
  
    --- Diff: src/main/groovy/lang/ObjectRange.java ---
    @@ -450,6 +451,9 @@ public Comparable next() {
                     value = peek();
                     nextFetched = true;
                 }
    +            if (value == null) {
    +                throw new NoSuchElementException();
    +            }
    --- End diff --
    
    I think these first 2 `if` statements could be replaced by the following and would make it cleaner:
    ```
    if (!hasNext()) {
        throw new NoSuchElementException();
    }
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---