groovy-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jwagenleitner <...@git.apache.org>
Subject [GitHub] groovy pull request #441: GROOVY-7951: MethodCallExpression.transformExpress...
Date Fri, 07 Oct 2016 14:47:24 GMT
GitHub user jwagenleitner opened a pull request:

    https://github.com/apache/groovy/pull/441

    GROOVY-7951: MethodCallExpression.transformExpression does not copy generic types

    PR created from patch supplied in [GROOVY-7951](https://issues.apache.org/jira/browse/GROOVY-7951).
 It seems like a reasonable change to make, though I did have trouble thinking up a way to
test it that would be meaningful.  If anyone can nudge me in the right direction I can try
to write up a test if you think it's warranted in this case.
    
    I considered whether `genericsTypes.clone()` should be used, but it didn't seem to be
common and most uses of the array seem to be read only.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jwagenleitner/groovy GROOVY-7951

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/groovy/pull/441.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #441
    
----
commit 76f9cdabd6e48baf5721b6b6dbff21a109f164a7
Author: John Wagenleitner <jwagenleitner@apache.org>
Date:   2016-10-04T22:29:59Z

    GROOVY-7951: MethodCallExpression.transformExpression does not copy generic types

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message