groovy-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mariogarcia <...@git.apache.org>
Subject [GitHub] groovy pull request #439: WIP Add groovy-macro docs
Date Thu, 06 Oct 2016 09:00:08 GMT
GitHub user mariogarcia opened a pull request:

    https://github.com/apache/groovy/pull/439

    WIP Add groovy-macro docs

    **WIP**
    
    This is a **Working In Progress** because:
    
    **Failing Tests**
    
    There are 2 tests that started failing once I added the `groovy-macro` dependencies in
specs:
    
    - `org.codehaus.groovy.classgen.asm.sc.bugs.Groovy7316Bug > testTypeCheckingBypassUsingExplicitTypeHint`
    
    - `org.codehaus.groovy.classgen.asm.sc.bugs.Groovy6757Bug > testExplicitTypeHint`
    
    **Questions**
    
    - Apart from that, there're a lot of licenses added I don't know where they came from.
Should I exclude them from the PR ?
    
    **Feedback**
    
    Of course, need to know if the docs are ok, or not. Even if the PR is rejected I'd be
happy if at least part of them help to the macros documentation.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mariogarcia/groovy documentation_ast

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/groovy/pull/439.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #439
    
----
commit f496bb17d9735e7ad598307695581d6ef4d97270
Author: Mario Garcia <mario.ggar@gmail.com>
Date:   2016-08-13T11:03:30Z

    WIP Add groovy-macro docs

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message