groovy-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jwagenleitner <...@git.apache.org>
Subject [GitHub] groovy pull request #432: GROOVY-7909 Calling parents method from trait usin...
Date Sun, 16 Oct 2016 06:21:45 GMT
Github user jwagenleitner commented on a diff in the pull request:

    https://github.com/apache/groovy/pull/432#discussion_r83546094
  
    --- Diff: src/main/org/codehaus/groovy/transform/trait/SuperCallTraitTransformer.java
---
    @@ -36,13 +38,19 @@
     
     import java.util.List;
     
    +import static org.objectweb.asm.Opcodes.ACC_ABSTRACT;
    +import static org.objectweb.asm.Opcodes.ACC_PUBLIC;
    +import static org.objectweb.asm.Opcodes.ACC_STATIC;
    +import static org.objectweb.asm.Opcodes.ACC_SYNTHETIC;
    +
     /**
      * This transformer is used to transform calls to <code>SomeTrait.super.foo()</code>
into the appropriate trait call.
      *
      * @author C├ędric Champeau
      * @since 2.3.0
      */
     class SuperCallTraitTransformer extends ClassCodeExpressionTransformer {
    +    public static final String UNRESOLVED_HELPER_CLASS = "UNRESOLVED_HELPER_CLASS";
    --- End diff --
    
    This is only used in the same package, I think package-private would be better than public.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message