groovy-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From blackdrag <...@git.apache.org>
Subject [GitHub] groovy pull request #438: GROOVY-7948: fix completion of static imports in g...
Date Thu, 13 Oct 2016 07:16:49 GMT
Github user blackdrag commented on a diff in the pull request:

    https://github.com/apache/groovy/pull/438#discussion_r83155709
  
    --- Diff: subprojects/groovy-groovysh/src/main/groovy/org/codehaus/groovy/tools/shell/completion/ImportsSyntaxCompletor.groovy
---
    @@ -87,51 +78,49 @@ class ImportsSyntaxCompletor implements IdentifierCompletor {
             return foundMatch
         }
     
    -    private static final String STATIC_IMPORT_PATTERN = ~/^import static ([a-z0-9]+\.)+[A-Z][a-zA-Z0-9]*(\.(\*|[^.]+))?$/
    +    private static final String STATIC_IMPORT_PATTERN = ~/^static ([a-zA-Z_][a-zA-Z_0-9]*\.)+([a-zA-Z_][a-zA-Z_0-9]*|\*)$/
     
         /**
          * finds matching imported classes or static methods
    -     * @param prefix
    -     * @param importSpec
    -     * @param matches
    -     * @return
    +     * @param importSpec an import statement without the leading 'import ' or trailing
semicolon
    +     * @return all names matching the importSpec
          */
    -    void collectImportedSymbols(final String importSpec, final Collection<String>
matches) {
    +    SortedSet<String> collectImportedSymbols(final String importSpec) {
    --- End diff --
    
    we decided to be strict about such things in a bugfix release and 2.4.8 is one. So yeah,
unless the method signature is made compatible no 2.4.x


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message