groovy-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paulk-asert <...@git.apache.org>
Subject [GitHub] groovy pull request #436: GROOVY-7952: Property expressions for extension me...
Date Thu, 06 Oct 2016 03:28:16 GMT
Github user paulk-asert commented on a diff in the pull request:

    https://github.com/apache/groovy/pull/436#discussion_r82111762
  
    --- Diff: src/main/org/codehaus/groovy/classgen/asm/sc/StaticTypesCallSiteWriter.java
---
    @@ -158,19 +158,24 @@ public void makeGetPropertySite(Expression receiver, final String
methodName, fi
     
             // GROOVY-5580, it is still possible that we're calling a superinterface property
             String getterName = "get" + MetaClassHelper.capitalize(methodName);
    +        String altGetterName = "is" + MetaClassHelper.capitalize(methodName);
             if (receiverType.isInterface()) {
                 Set<ClassNode> allInterfaces = receiverType.getAllInterfaces();
                 MethodNode getterMethod = null;
                 for (ClassNode anInterface : allInterfaces) {
                     getterMethod = anInterface.getGetterMethod(getterName);
    -                if (getterMethod!=null) break;
    +                if (getterMethod == null) getterMethod = anInterface.getGetterMethod(altGetterName);
    +                if (getterMethod != null) break;
                 }
                 // GROOVY-5585
    -            if (getterMethod==null) {
    +            if (getterMethod == null) {
                     getterMethod = OBJECT_TYPE.getGetterMethod(getterName);
                 }
    +            if (getterMethod == null) {
    +                getterMethod = OBJECT_TYPE.getGetterMethod(altGetterName);
    --- End diff --
    
    There are no isXxx methods in Object? Is this needed?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message