Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 69479200B87 for ; Mon, 19 Sep 2016 23:08:26 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 67E52160ACC; Mon, 19 Sep 2016 21:08:26 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id AD60B160ABB for ; Mon, 19 Sep 2016 23:08:25 +0200 (CEST) Received: (qmail 95636 invoked by uid 500); 19 Sep 2016 21:08:24 -0000 Mailing-List: contact notifications-help@groovy.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@groovy.apache.org Delivered-To: mailing list notifications@groovy.apache.org Received: (qmail 95625 invoked by uid 99); 19 Sep 2016 21:08:24 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Sep 2016 21:08:24 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id C37FCDFE65; Mon, 19 Sep 2016 21:08:24 +0000 (UTC) From: jwagenleitner To: notifications@groovy.apache.org Reply-To: notifications@groovy.apache.org Message-ID: Subject: [GitHub] groovy pull request #427: Compatibility in 2.4.x with Gradle's classloader c... Content-Type: text/plain Date: Mon, 19 Sep 2016 21:08:24 +0000 (UTC) archived-at: Mon, 19 Sep 2016 21:08:26 -0000 GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/427 Compatibility in 2.4.x with Gradle's classloader cleanup Gradle has a cleanup mechanism in place that reflectively accesses the ClassInfo.klazz field. This change prevents an exception being thrown by the cleanup method. This workaround also means that the cleanup strategy will no longer work, the fix to replace klazz with a WeakReference should eliminate the need for the explicit cleanup. For more details, see dev mailing list thread: https://mail-archives.apache.org/mod_mbox/incubator-groovy-dev/201609.mbox/%3CCAHPL-JkQ%2BU8PfaxyVhtE%3DvGV%2BsXXmCzxOsCR8UbBww6P2vskPg%40mail.gmail.com%3E You can merge this pull request into a Git repository by running: $ git pull https://github.com/jwagenleitner/groovy ClassInfoCompat Alternatively you can review and apply these changes as the patch at: https://github.com/apache/groovy/pull/427.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #427 ---- commit 81dfa648541f00a33d25bc0084ec240b88c3f321 Author: John Wagenleitner Date: 2016-09-19T18:48:19Z Compatibility in 2.4.x with Gradle's classloader cleanup Gradle has a cleanup mechanism in place that reflectively accesses the ClassInfo.klazz field. This change prevents an exception being thrown by the cleanup method. This workaround also means that the cleanup strategy will no longer work, the fix to replace klazz with a WeakReference should eliminate the need for the explicit cleanup. For more details, see dev mailing list thread: https://mail-archives.apache.org/mod_mbox/incubator-groovy-dev/201609.mbox/%3CCAHPL-JkQ%2BU8PfaxyVhtE%3DvGV%2BsXXmCzxOsCR8UbBww6P2vskPg%40mail.gmail.com%3E ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---