groovy-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jwagenleitner <...@git.apache.org>
Subject [GitHub] groovy pull request #422: GROOVY-7922: Static type checking not strict enoug...
Date Sun, 18 Sep 2016 05:30:14 GMT
Github user jwagenleitner commented on a diff in the pull request:

    https://github.com/apache/groovy/pull/422#discussion_r79297750
  
    --- Diff: src/main/org/codehaus/groovy/transform/stc/StaticTypeCheckingSupport.java ---
    @@ -1157,6 +1142,45 @@ private static ClassNode makeRawType(final ClassNode receiver)
{
             return result;
         }
     
    +    private static void removeMethodInSuperInterface(List<MethodNode> toBeRemoved,
MethodNode one, MethodNode two) {
    +        ClassNode oneDC=one.getDeclaringClass();
    +        ClassNode twoDC=two.getDeclaringClass();
    +        if(oneDC.implementsInterface(twoDC)){
    +            toBeRemoved.add(two);
    +        }else{
    +            toBeRemoved.add(one);
    +        }
    +    }
    +
    +    private static boolean areEquivalentInterfaceMethods(MethodNode one, MethodNode two,
Parameter[] onePars, Parameter[] twoPars) {
    --- End diff --
    
    I think it would simplify things if this just took 2 MethodNode's, the parameters can
be gotten from the nodes so no need to pass them in I think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message