groovy-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jwagenleitner <>
Subject [GitHub] groovy pull request #419: GROOVY-6396: same linkedlist code different behavi...
Date Sun, 18 Sep 2016 04:43:38 GMT
Github user jwagenleitner commented on a diff in the pull request:
    --- Diff: src/main/org/codehaus/groovy/runtime/ ---
    @@ -8913,11 +8913,15 @@ public int compare(Map.Entry<K, V> e1, Map.Entry<K, V>
e2) {
    -     * Removes the last item from the List. Using add() and pop()
    -     * is similar to push and pop on a Stack.
    -     * <pre class="groovyTestCase">def list = ["a", false, 2]
    -     * assert list.pop() == 2
    -     * assert list == ["a", false]</pre>
    +     * Removes the initial item from the List, similar to pop on a Stack.
    --- End diff --
    I wonder if most associate removing items from the top of a Stack, so in this case would
it make sense to say 
    >..similar to pop on a Deque.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message