groovy-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jwagenleitner <...@git.apache.org>
Subject [GitHub] groovy pull request #:
Date Fri, 09 Sep 2016 19:18:26 GMT
Github user jwagenleitner commented on the pull request:

    https://github.com/apache/groovy/commit/9be5459c906ba106f235d40ebe0f25b7193a0467#commitcomment-18968136
  
    In src/main/org/apache/groovy/metaclass/Realm.java:
    In src/main/org/apache/groovy/metaclass/Realm.java on line 43:
    I know this is just some experimental work, so if you aren't looking for any feedback
let me know and I wont comment anymore.  Just thought I'd point out the license header is
the older style and would be good to use the updated version (no years).  Also noticed the
missing generic type for the type Class argument.
    
    Am curious if `Realm` (in combo with ClassValue) is meant to replace `ClassInfo`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message