groovy-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GROOVY-7723) propertyMissing(String,Object) called for missing getter
Date Sat, 09 Apr 2016 09:59:25 GMT

    [ https://issues.apache.org/jira/browse/GROOVY-7723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15233479#comment-15233479
] 

ASF GitHub Bot commented on GROOVY-7723:
----------------------------------------

GitHub user jwagenleitner opened a pull request:

    https://github.com/apache/groovy/pull/307

    GROOVY-7723 - propertyMissing(String,Object) called for missing getter

    Looks like commit 97a45dfb3e3c5212c36 introduced [this change] (https://github.com/apache/groovy/commit/97a45dfb3e3c5212c3610cd90fe1e7434614b260#diff-c1354c0d7df171ad8cafcb3d1bf63857L535).
The original code would not have delegated to the setter method. I don't think the intent
of the commit was to change the behavior but resulted inadvertently due to the refactoring.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jwagenleitner/groovy GROOVY-7723

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/groovy/pull/307.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #307
    
----
commit 930c41d10d41cc9923db90afec53357e15b1d822
Author: John Wagenleitner <jwagenleitner@apache.org>
Date:   2016-04-09T09:56:08Z

    GROOVY-7723 - propertyMissing(String,Object) called for missing getter

----


> propertyMissing(String,Object) called for missing getter
> --------------------------------------------------------
>
>                 Key: GROOVY-7723
>                 URL: https://issues.apache.org/jira/browse/GROOVY-7723
>             Project: Groovy
>          Issue Type: Bug
>    Affects Versions: 2.4.0
>         Environment: Tested with Groovy 1.8.0, 2.1.0, 2.2.2, and 2.4.0.
>            Reporter: Yih Tsern
>            Priority: Minor
>
> GROOVY-2098 says that {{propertyMissing(String)}} is for getters, while {{propertyMissing(String,Object)}}
is for setters.
> But as the code snippet below shows, when {{propertyMissing(String)}} is missing, missing
getters are handled by {{propertyMissing(String,Object)}}:
> {code:java}
> class Sample {
>     /**
>     def propertyMissing(String name) {
>         return "propertyMissing(String)"
>     }
>     **/
>     def propertyMissing(String name, value) {
>         return "propertyMissing(String,Object)"
>     }
> }
> println new Sample().missing // Prints `propertyMissing(String,Object)`
> {code}
> Is this a bug?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message