groovy-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GROOVY-7529) Fix up transforms (apart from TupleConstructor) which are affected by empty includes default
Date Sat, 01 Aug 2015 02:29:04 GMT

    [ https://issues.apache.org/jira/browse/GROOVY-7529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14650115#comment-14650115
] 

ASF GitHub Bot commented on GROOVY-7529:
----------------------------------------

Github user paulk-asert commented on a diff in the pull request:

    https://github.com/apache/incubator-groovy/pull/77#discussion_r36029568
  
    --- Diff: src/spec/doc/core-metaprogramming.adoc ---
    @@ -966,6 +966,25 @@ include::{projectdir}/src/spec/test/CodeGenerationASTTransformsTest.groovy[tags=
     ----
     |=======================================================================
     
    +[[xform-MapConstructor]]
    +===== @groovy.transform.MapConstructor
    +
    +The `@MapConstructor` annotation aims at eliminating boilerplate code by generating a
map constructor for you. A map
    --- End diff --
    
    Yes, MapConstructor was missing from the documentation altogether. I added at least a
placeholder but I'll probably try to add the doco in a separate commit and then rework this
PR accordingly.


> Fix up transforms (apart from TupleConstructor) which are affected by empty includes
default
> --------------------------------------------------------------------------------------------
>
>                 Key: GROOVY-7529
>                 URL: https://issues.apache.org/jira/browse/GROOVY-7529
>             Project: Groovy
>          Issue Type: Bug
>            Reporter: Keegan Witt
>            Assignee: Paul King
>
> I know this is a bit of an edge case, but I find the behavior doesn't follow what one
would expect
> {code:java}
> assert Cat.class.declaredConstructors.size() == 1  // fails
> @groovy.transform.TupleConstructor(includes=[])
> class Cat {
>   String name
>   int age
> }
> {code}
> This is a CLONE to cover the other transforms. TupleConstructor was fixed in GROOVY-7523.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message