Mailing-List: contact notifications-help@groovy.incubator.apache.org;
 run by ezmlm
Precedence: bulk
Reply-To: dev@groovy.incubator.apache.org
Date: Wed, 22 Jul 2015 13:35:05 +0000 (UTC)
From: "Jochen Kemnade (JIRA)" <jira@apache.org>
To: notifications@groovy.incubator.apache.org
Message-ID: <JIRA.12811456.1415242457000.256214.1437572105375@Atlassian.JIRA>
In-Reply-To: <JIRA.12811456.1415242457000@Atlassian.JIRA>
References: <JIRA.12811456.1415242457000@Atlassian.JIRA>
 <JIRA.12811456.1415242457542@arcas>
Subject: [jira] [Commented] (GROOVY-7156) Builders behave strange when
 closures throw exceptions
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/GROOVY-7156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636907#comment-14636907 ] 

Jochen Kemnade commented on GROOVY-7156:
----------------------------------------

And groovy-binary-2.5.0-20150722.114831-291.zip is affected too.

> Builders behave strange when closures throw exceptions
> ------------------------------------------------------
>
>                 Key: GROOVY-7156
>                 URL: https://issues.apache.org/jira/browse/GROOVY-7156
>             Project: Groovy
>          Issue Type: Bug
>    Affects Versions: 2.3.7, 2.4.0-rc-2, 2.4.0, 2.4.1, 2.4.2, 2.4.3, 2.4.4
>            Reporter: Jochen Kemnade
>         Attachments: groovy-7156.zip
>
>
> I noticed some strange behavior when closures inside a builder throw exceptions:
> {code}
> import groovy.transform.TypeChecked
> @TypeChecked
> class TestBuilder extends BuilderSupport {
>   Object createNode(Object name, Map map){
>     println "Create node $name: $map"
>     new Node(null, name, map)
>   }
>   Object createNode(Object name){
>     println "Create node $name"
>     new Node(null, name)
>   }
>   Object createNode(Object name, Object value){
>     println "Create node $name, value $value"
>     new Node(null, name, value)
>   }
>   Object createNode(Object name, Map map, Object value){
>     println "Create node $name: $map, value $value"
>     new Node(null, name, map, value)
>   }
>   void setParent(Object parent, Object child){
>     println "set parent of $child to $parent"
>     ((Node)parent).append( (Node) child)
>   }
> }
> def builder = new TestBuilder()
> // First case
> // expected: MissingMethodException tring to call String.foo()
> // actual: MissingMethodException tring to call b(Closure)
> try {
>   builder.a {
>     b {
>       error('xy'.foo())
>     }
>   }
> }catch (e){
>   assert e instanceof MissingMethodException
>   assert e.method == "foo"
> }
> // Second case
> // expected: one call to buidler.createNode('b')
> // actual: two calls to buidler.createNode('b')
> builder.with {
>   a {
>     b {
>       error("xy".foo())
>     }
>   }
> }
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)