groovy-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (GROOVY-7520) Improve unimplemented message for abstract methods
Date Thu, 30 Jul 2015 20:35:04 GMT


ASF GitHub Bot commented on GROOVY-7520:

GitHub user keeganwitt opened a pull request:

    GROOVY-7520: Improve unimplemented message for abstract methods

    c3a802fe13a6fc7267130db805940bd2be41b4f8 accidentally included #71 instead of #68 in it's
commit message.  I'm opening this PR to re-request the pull.

You can merge this pull request into a Git repository by running:

    $ git pull GROOVY-7520

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #78
commit a4fba4baf019661e3a011bbaa9f1da8e506f9989
Author: Keegan Witt <>
Date:   2015-07-23T16:04:54Z

    GROOVY-7520: Improve unimplemented message for abstract methods


> Improve unimplemented message for abstract methods
> --------------------------------------------------
>                 Key: GROOVY-7520
>                 URL:
>             Project: Groovy
>          Issue Type: Bug
>          Components: Compiler
>            Reporter: Keegan Witt
>             Fix For: 2.4.5
> GROOVY-7081 caused the message to change for scenarios like
> {code:java}
> abstract class Module {
>     abstract String getModuleName()
> }
> class Master extends Module {
>     String title
>     String track
> }    
> def master = new Master(title: "Hello", track: "1")
> println master.title
> {code}
> The message went from
> {quote}Can't have an abstract method in a non-abstract class. The class 'Master' must
be declared abstract or the method 'java.lang.String getModuleName()' must be implemented.{quote}
> to
> {quote}Abstract method 'java.lang.String getModuleName()' is not implemented but a method
of the same name but different return type is defined: method 'java.lang.String getModuleName()'{quote}

This message was sent by Atlassian JIRA

View raw message