groovy-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keeganwitt <...@git.apache.org>
Subject [GitHub] incubator-groovy pull request: GROOVY-7509 Problem With Stub Gener...
Date Thu, 30 Jul 2015 14:46:09 GMT
Github user keeganwitt commented on a diff in the pull request:

    https://github.com/apache/incubator-groovy/pull/76#discussion_r35878035
  
    --- Diff: src/main/org/codehaus/groovy/tools/javac/JavaStubGenerator.java ---
    @@ -925,7 +931,8 @@ private void printImports(PrintWriter out, ClassNode classNode) {
             imports.addAll(Arrays.asList(ResolveVisitor.DEFAULT_IMPORTS));
     
             for (Map.Entry<String, ImportNode> entry : moduleNode.getStaticImports().entrySet())
{
    -            imports.add("static "+entry.getValue().getType().getName()+"."+entry.getKey());
    +            if (entry.getKey().equals(entry.getValue().getFieldName()))
    --- End diff --
    
    Could this just be
    ```java
    imports.add("static " + entry.getValue().getType().getName() + "." + entry.getValue().getFieldName());
    ```
    without the conditional?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message