groovy-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keeganwitt <...@git.apache.org>
Subject [GitHub] incubator-groovy pull request: GROOVY-7486: In groovy.util.Node.de...
Date Mon, 13 Jul 2015 14:19:32 GMT
Github user keeganwitt commented on a diff in the pull request:

    https://github.com/apache/incubator-groovy/pull/59#discussion_r34467023
  
    --- Diff: src/main/groovy/util/Node.java ---
    @@ -537,26 +539,40 @@ private NodeList getByName(String name) {
     
         /**
          * Provides a collection of all the nodes in the tree
    -     * using a depth first traversal.
    +     * using a depth-first preorder traversal.
          *
          * @return the list of (depth-first) ordered nodes
          */
         public List depthFirst() {
    +        return depthFirst(true);
    +    }
    +
    +    /**
    +     * Provides a collection of all the nodes in the tree
    +     * using a depth-first traversal.
    +     *
    +     * @param preorder if false, a postorder depth-first traversal will be performed
    --- End diff --
    
    Solution doesn't provide In-order traversal, which was also requested in 7486.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message