Return-Path: X-Original-To: apmail-groovy-notifications-archive@minotaur.apache.org Delivered-To: apmail-groovy-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A600A18CC1 for ; Thu, 4 Jun 2015 09:50:39 +0000 (UTC) Received: (qmail 90327 invoked by uid 500); 4 Jun 2015 09:50:39 -0000 Delivered-To: apmail-groovy-notifications-archive@groovy.apache.org Received: (qmail 90304 invoked by uid 500); 4 Jun 2015 09:50:39 -0000 Mailing-List: contact notifications-help@groovy.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@groovy.incubator.apache.org Delivered-To: mailing list notifications@groovy.incubator.apache.org Received: (qmail 90295 invoked by uid 99); 4 Jun 2015 09:50:39 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Jun 2015 09:50:39 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 2F75ECB4F5 for ; Thu, 4 Jun 2015 09:50:39 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.77 X-Spam-Level: * X-Spam-Status: No, score=1.77 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id rMfydJaGyhSh for ; Thu, 4 Jun 2015 09:50:38 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with SMTP id 75FBE275EB for ; Thu, 4 Jun 2015 09:50:38 +0000 (UTC) Received: (qmail 89746 invoked by uid 99); 4 Jun 2015 09:50:38 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Jun 2015 09:50:38 +0000 Date: Thu, 4 Jun 2015 09:50:38 +0000 (UTC) From: "Paul King (JIRA)" To: notifications@groovy.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (GROOVY-7424) NPE in SecureASTCustomizer for interface method declarations MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/GROOVY-7424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul King resolved GROOVY-7424. ------------------------------- Resolution: Fixed Fix Version/s: 2.5.0-beta-1 2.4.4 Thanks for spotting the issue. > NPE in SecureASTCustomizer for interface method declarations > ------------------------------------------------------------ > > Key: GROOVY-7424 > URL: https://issues.apache.org/jira/browse/GROOVY-7424 > Project: Groovy > Issue Type: Bug > Components: Compiler > Affects Versions: 2.3.4, 2.3.11, 2.4.3 > Reporter: Carsten Mjartan > Assignee: Paul King > Fix For: 2.4.4, 2.5.0-beta-1 > > > if you apply the SecureASTCustomizer to code that contains an interface method declaration, you get a NullPointerException at SecureASTCustomizer, Row 558 (Groovy 2.4.3) > {code:java} > final SecuringCodeVisitor visitor = new SecuringCodeVisitor(); > ast.getStatementBlock().visit(visitor); > for (ClassNode clNode : ast.getClasses()) { > if (clNode!=classNode) { > checkMethodDefinitionAllowed(clNode); > for (MethodNode methodNode : clNode.getMethods()) { > if (!methodNode.isSynthetic()) { > => methodNode.getCode().visit(visitor); > } > } > } > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)