From dev-return-5964-archive-asf-public=cust-asf.ponee.io@groovy.apache.org Sun Mar 24 09:43:24 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 695EA18065B for ; Sun, 24 Mar 2019 10:43:23 +0100 (CET) Received: (qmail 22307 invoked by uid 500); 24 Mar 2019 09:43:22 -0000 Mailing-List: contact dev-help@groovy.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@groovy.apache.org Delivered-To: mailing list dev@groovy.apache.org Received: (qmail 22297 invoked by uid 99); 24 Mar 2019 09:43:21 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 24 Mar 2019 09:43:21 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 567E6C20EB for ; Sun, 24 Mar 2019 09:43:21 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.862 X-Spam-Level: *** X-Spam-Status: No, score=3.862 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=2, KAM_INFOUSMEBIZ=0.75, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, URI_HEX=1.313] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id sZm01_YNQ-ws for ; Sun, 24 Mar 2019 09:43:17 +0000 (UTC) Received: from mail-io1-f53.google.com (mail-io1-f53.google.com [209.85.166.53]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 7479B62447 for ; Sun, 24 Mar 2019 09:43:17 +0000 (UTC) Received: by mail-io1-f53.google.com with SMTP id u12so5175473iop.11 for ; Sun, 24 Mar 2019 02:43:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=/D99R6l86wyc+/hH7N82D9BM9ZsH/lTkFYQInb7AkUw=; b=n6SncJbz0F/YFWcs/kE//1uPu/ZM2QRP9qPlAwKl9Be4xP1MrD8TfhcmX31A7K4OSI Mg33aWK1grUSnFQtiTTqXTn9Uypk4PulhuuUPtD9d9vXAtW/6iuOQ+BPGB8C3KGtUk1P iaN2+cbVaC7eIFaVXye/TnK/caw2HItHTX5E1JSkX+uBpC4AWnodyMUAZkj+l1gAJ24A /LvRVzgs7BjvSm7BszMVGUdihZP/omnc3Jhg6KAWkQ8MFyNhrkfyI8vZKs+SknbIZTO7 laP93NshDEFWYi29+1DM+iD5IGHr69rDIp2ayPT7X0ycWulFzYsA+7aBBVDUPEuKNH0x HTZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=/D99R6l86wyc+/hH7N82D9BM9ZsH/lTkFYQInb7AkUw=; b=Fis27l0Bx3wJhcps/h8t4BwZVvWWuQcg1dQbpRplH38qPoTonLOLs3Bq7/w18CEF89 QuGkB+mQIBYxnpLCAUBqjnjHx/pvGpyBF9J0QYCAJ6dOZN6BTjjTz7xg/iV+NghCvQbc rYwp2h6+u2DQfm4bDhTecPXd5a33wzBT57xcjiLKZU6Z8qWN+xQSQ194VuXNYRrGV8QJ A9SmLUb77S4sLAIC9dnxRfOpDqiMJZRWIJ+jnjZub+UI3KOridmRAW5i7wfCMi44WoBs TIRKx6QjUrpqyD2dN+sAmA8jh45THbBrPHvZyShizl9zDlkMb8TQpFua3J/AZNCba46E Wuig== X-Gm-Message-State: APjAAAWfm32DosGo71cwTq12xWZL6nOdZtUthfgSUWGbNl4byhDvm59L 7T7mHpXfJ8TuDB2ve6tqZ3QkdwnmcJ4g+TRE3dalj1EK X-Google-Smtp-Source: APXvYqyVhSRKTRuJ19WQYOGGDi2siEZ05+FsQ10Y1b8tfkORj+KmbWucnrOvBkNdYzro6mlzSOvtm4kaNrJt024l2mE= X-Received: by 2002:a6b:d913:: with SMTP id r19mr5056987ioc.76.1553420591057; Sun, 24 Mar 2019 02:43:11 -0700 (PDT) MIME-Version: 1.0 References: <1553358777910-0.post@n5.nabble.com> <1553389516551-0.post@n5.nabble.com> In-Reply-To: From: Guillaume Laforge Date: Sun, 24 Mar 2019 10:43:00 +0100 Message-ID: Subject: Re: Rename method `visit` of `ASTNode` to `accept` To: Groovy_Developers , Paul King Content-Type: multipart/alternative; boundary="0000000000008453a20584d3ea34" --0000000000008453a20584d3ea34 Content-Type: text/plain; charset="UTF-8" What's the point of renaming that method? Is it just to use a more well known / common name from the visitor pattern? IMHO it's really not worth the hassle, and it's more pain for users who will ultimately have to recompile their code at some point. It doesn't bring anything to the users in any way. Or am I missing something? On Sun, Mar 24, 2019 at 3:31 AM Paul King wrote: > Once we have Java 9 as our minimum, we can use the `since` and > `forRemoval` Deprecated attributes > and that will allow us to make such deprecations a little clearer. > > On Sun, Mar 24, 2019 at 12:26 PM Paul King wrote: > >> If you want to deprecate now and not in the future, I think that would >> still warrant a question on the users list. >> People often feel compelled to get rid of the deprecation warnings and >> that still means two versions of their libraries would be required. >> I'd be inclined to wait until Groovy 4 for deprecation. >> >> >> On Sun, Mar 24, 2019 at 11:05 AM Daniel.Sun wrote: >> >>> OK. Let's add an alias method `accept` and mark method `visit` >>> deprecated. >>> >>> Cheers, >>> Daniel.Sun >>> >>> >>> >>> >>> ----- >>> Apache Groovy committer >>> Blog: http://blog.sunlan.me >>> Twitter: @daniel_sun >>> >>> -- >>> Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html >>> >> -- Guillaume Laforge Apache Groovy committer Developer Advocate @ Google Cloud Platform Blog: http://glaforge.appspot.com/ Twitter: @glaforge --0000000000008453a20584d3ea34 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
What's the point of renaming that method?

Is it just to use a more well known / common name from the visitor p= attern?
IMHO it's really not worth the hassle, and it's m= ore pain for users who will ultimately have to recompile their code at some= point.
It doesn't bring anything to the users in any way. Or= am I missing something?

On Sun, Mar 24, 2019 at 3:31 AM Paul King <= ;paulk@asert.com.au> wrote:
O= nce we have Java 9 as our minimum, we can use the `since` and `forRemoval` = Deprecated attributes
and that will allow us to make such deprecations = a little clearer.=C2=A0

On Sun, Mar 24, 2019 at 12:26 PM Paul King &l= t;paulk@asert.com.a= u> wrote:
If you want to deprecate now and not in the future, I thi= nk that would still warrant a question on the users list.
People often = feel compelled to get rid of the deprecation warnings and that still means = two versions of their libraries would be required.
I'd be inc= lined to wait until Groovy 4 for deprecation.

On Sun, M= ar 24, 2019 at 11:05 AM Daniel.Sun <sunlan@apache.org> wrote:
OK. Let's add an alias method `acce= pt` and mark method `visit` deprecated.

Cheers,
Daniel.Sun




-----
Apache Groovy committer
Blog: http://blog.sunlan.me
Twitter: @daniel_sun

--
Sent from: http://groovy.329449.n5.nabble.= com/Groovy-Dev-f372993.html


--
Guillaume Laforge
Apache Groovy co= mmitter
Developer Advocate @ Google Cloud Platform

--0000000000008453a20584d3ea34--