groovy-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guillaume Laforge <glafo...@gmail.com>
Subject Re: Rename method `visit` of `ASTNode` to `accept`
Date Sun, 24 Mar 2019 09:43:00 GMT
What's the point of renaming that method?

Is it just to use a more well known / common name from the visitor pattern?
IMHO it's really not worth the hassle, and it's more pain for users who
will ultimately have to recompile their code at some point.
It doesn't bring anything to the users in any way. Or am I missing
something?

On Sun, Mar 24, 2019 at 3:31 AM Paul King <paulk@asert.com.au> wrote:

> Once we have Java 9 as our minimum, we can use the `since` and
> `forRemoval` Deprecated attributes
> and that will allow us to make such deprecations a little clearer.
>
> On Sun, Mar 24, 2019 at 12:26 PM Paul King <paulk@asert.com.au> wrote:
>
>> If you want to deprecate now and not in the future, I think that would
>> still warrant a question on the users list.
>> People often feel compelled to get rid of the deprecation warnings and
>> that still means two versions of their libraries would be required.
>> I'd be inclined to wait until Groovy 4 for deprecation.
>>
>>
>> On Sun, Mar 24, 2019 at 11:05 AM Daniel.Sun <sunlan@apache.org> wrote:
>>
>>> OK. Let's add an alias method `accept` and mark method `visit`
>>> deprecated.
>>>
>>> Cheers,
>>> Daniel.Sun
>>>
>>>
>>>
>>>
>>> -----
>>> Apache Groovy committer
>>> Blog: http://blog.sunlan.me
>>> Twitter: @daniel_sun
>>>
>>> --
>>> Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html
>>>
>>

-- 
Guillaume Laforge
Apache Groovy committer
Developer Advocate @ Google Cloud Platform

Blog: http://glaforge.appspot.com/
Twitter: @glaforge <http://twitter.com/glaforge>

Mime
View raw message