From dev-return-5767-archive-asf-public=cust-asf.ponee.io@groovy.apache.org Tue Jan 15 08:05:22 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id C6C1E180609 for ; Tue, 15 Jan 2019 08:05:21 +0100 (CET) Received: (qmail 70041 invoked by uid 500); 15 Jan 2019 07:05:20 -0000 Mailing-List: contact dev-help@groovy.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@groovy.apache.org Delivered-To: mailing list dev@groovy.apache.org Received: (qmail 70029 invoked by uid 99); 15 Jan 2019 07:05:19 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Jan 2019 07:05:19 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 7B5011807EE for ; Tue, 15 Jan 2019 07:05:19 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.701 X-Spam-Level: X-Spam-Status: No, score=-0.701 tagged_above=-999 required=6.31 tests=[RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id g-o0-bK3_2_i for ; Tue, 15 Jan 2019 07:05:17 +0000 (UTC) Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 4A5195F3B3 for ; Tue, 15 Jan 2019 07:05:17 +0000 (UTC) Received: from [192.168.1.4] ([77.189.31.136]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0M6874-1hU0M23ap8-00y7Pa for ; Tue, 15 Jan 2019 08:05:16 +0100 Subject: Re: ASM class resolution To: dev@groovy.apache.org References: <3158A288-E9B0-4E93-94E3-95E3820C35BA@jetbrains.com> From: Jochen Theodorou Message-ID: <72bc36f9-a6df-ea38-8966-32964e460fe3@gmx.org> Date: Tue, 15 Jan 2019 08:05:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <3158A288-E9B0-4E93-94E3-95E3820C35BA@jetbrains.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:6dOCj5Dp1FCzdLUgMkyZq2Mi4StRK0gdcHrmNUOgiSjoO6hX3+t orIOzZqXXP9xjcOvaczHc142lswVkLpDED3qRmA0tCQ99SK2c+Z1zSRWZotZgc8IyTTrFke KbUh7/Dtc8gTPsGREAiuZfSEAzouc4JK55C2tqQf24HS5ADkDNQ6ozVxChXryettoEv4/w+ 8NOJ9lioESBhwdvLqYK6A== X-UI-Out-Filterresults: notjunk:1;V03:K0:ISam0rbikGc=:szn5POgss438XIb3dIB4jE WwJBJPE/H4+Gg4VZKwWKr5DS4u4f9diumWxNZhp9Lt+ltNAisWKm8/R+EYzUBSiPJXocyRR3O 6p2mqEH5Ln9gONDGf7A5ERxdl/avnANGCnjIRfFaHcC1HzOHY/t5R3KN9/oolstHjo+6lXqu0 8JLzhHDvie4E+3RiGObXkzbc3Qd4qncYzfuQhfQ5DbW011T9bKHuGglyxgSYk+cP1CtybGhX4 s6mdYeDwGpFxIxXyQoMr1fJD0HdE9Tdj52pwYsrD2JmnbLSilbZtZmDyWjYPAH88l/AzzuzLC YdR02QZf/XwonSIGXDRtSLahrLDTbyIf2a5/3K7xERTdRW0B4GZwE4qxRRTEasvJpJegnVq+h sIr5EXYjny/93ely87pgG1926HZ6g7+KACQzsqJYBWc7NU5VyfKJD9+qViV3IcvdCd87YwNRo 3qfXTR9N30jL4crxDGHmFtEFuUB3w4w0lpg9eUq2s7XLomIsyJjPXgoS4PrOFbC2GUWidQTwZ KaWiuv464pNKA5YF1nQyOMJtz3xmnvn4jSWkGEEF9vyj17GBnntuixwRtX7BBsG2FhGlHTihQ RoVTaWkpFO5fO0KxPkedx1ssFsxrpj/Ny0id1ZyvRJXYSwvV+RUQZf16cjyaGDMoztwbj9Eip Mjlv04BgcjHRUZy95oxWV9sEcL6EU9jE7gzz+Zy3KB0uAbx5n0QaV8Vjqjiy8zAkuwDY9a1X4 lPNZyThb0Ysf5bEckZ2HyxY/d/fYShmeqMPRk93L0AP6ws2l8C2xYGZ2gvupdfdMZVSGmgRFw sWvQhAFyApuxCXNa3x04SL1QaReymBYRZqdANDQdN2aPZYv6kqZYx4WpnkDxUzPCCpT3wc5P+ pxk3OuZ8ScAkj3O58BGM1JdESxQDvmibkOUIVhwcIRtGYYHIzHhl+H1wMfRz2H On 14.01.19 18:23, Daniil Ovchinnikov wrote: > Hi all - > > So I’ve been investigating https://youtrack.jetbrains.com/issue/IDEA-204305 for a while now > and found out that getClassNode() in anonymous ClassWriter in CompilationUnit#createClassVisitor > still uses class loader to obtain class node instead of relying on AsmReferenceResolver. > > Is this expected? You mean this here: https://github.com/apache/groovy/blob/master/src/main/java/org/codehaus/groovy/control/CompilationUnit.java#L899 you are correct in that this is wrong and should instead use getClassNodeResolver(). bye Jochen