groovy-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Paul King <pa...@asert.com.au>
Subject Re: More Default String Methods
Date Fri, 14 Dec 2018 07:28:01 GMT
My suggestions:

* alter your code style to match the existing style
* rename `after` to `takeAfter`
* rename `before` to `takeBefore`
* rename `between` to `takeBetween`
* no need for `stripLeft` since that is what `drop` does - with a minor
difference in behavior for the -1 case
* rename `stripRight` to `dropRight` and align -1 behavior to `drop`
* no need for GString variants of startsWith/endsWith/containsIgnoreCase
(CharSequence variant works fine by itself for GString unless we want to
have a better return type)
* I'd suggest picking a better name for the occurrence counter, e.g. `int
occurrence` instead of `int item`

Cheers, Paul.


On Sun, Nov 25, 2018 at 9:11 PM adithyank <adi.k.dev@gmail.com> wrote:

> I have created a PR for this change and kept in my fork itself. Link below
>
> https://github.com/adithyank/groovy/pull/1
>
> I have a doubt whether a jira issue be created for every commit...
>
> How should I Proceed...
>
> Kindly advice
>
>
>
> -----
> Thanks,
>
> Adithyan K
> India
> --
> Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html
>

Mime
View raw message