From dev-return-5587-archive-asf-public=cust-asf.ponee.io@groovy.apache.org Fri Nov 2 10:04:29 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id A51E018062B for ; Fri, 2 Nov 2018 10:04:28 +0100 (CET) Received: (qmail 14484 invoked by uid 500); 2 Nov 2018 09:04:27 -0000 Mailing-List: contact dev-help@groovy.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@groovy.apache.org Delivered-To: mailing list dev@groovy.apache.org Received: (qmail 14474 invoked by uid 99); 2 Nov 2018 09:04:26 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Nov 2018 09:04:26 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 761051A30DB for ; Fri, 2 Nov 2018 09:04:26 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.202 X-Spam-Level: *** X-Spam-Status: No, score=3.202 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_DKIMWL_WL_MED=-0.01, URI_HEX=1.313] autolearn=disabled Authentication-Results: spamd2-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id TB9LmC-mJBex for ; Fri, 2 Nov 2018 09:04:25 +0000 (UTC) Received: from mail-it1-f177.google.com (mail-it1-f177.google.com [209.85.166.177]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 465E55F41C for ; Fri, 2 Nov 2018 09:04:25 +0000 (UTC) Received: by mail-it1-f177.google.com with SMTP id w7-v6so2287070itd.1 for ; Fri, 02 Nov 2018 02:04:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=AsIFB2xWBYQeT1BAE/zDv196uI7/hl95feFb53NgvDU=; b=k4KRaOhLREF3j3tS9ttTVbu5UrU8zIusxAdM0NhwKlIS+Jy5ACd1QtMoFiAMm4TGex W8J80nOuM2KYCggQe6HTKJfrXk2+PsO1vFpQYJysvyHQmHIbaS9IZ8jhvvwvHPKtpSEh bgB6fX0xyqR0Y/ascAis3ErdSA0nMojNSiTMjLKaaNqFD8ILr6bH0QqitNxefYb8wTWX 2zzAfMSkwpulqZOV2xJ/Vnhurpy0+EuYkmhmbtJIrXQvJ1taJgPNZCOkM+5V1MnEuEZf 0JD1r7oLsooPEKoGOdG35PSxI3Q4uSKziZ8Vt+ojk51GmbJZSCfs6l3qiI7cW8vppStw y0fQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=AsIFB2xWBYQeT1BAE/zDv196uI7/hl95feFb53NgvDU=; b=MELF9w4AlK0qrf0hacnU2CEhl/5lqvxKB1ySDBGtIoyw3Qde/1xRi1vE9FNVMC6U7T 3T7j7+z4cJ6L1NJQEi1kRKS6MzY0OIXqO4xfQraTj4juUuBxAkJHXoNMo8Bdq/DgqLAY zgW4Ilbt0mxryAxLrNdlsAMWvyFmA3kMFVIr17VwT1MjWojQmDWdN76s60TiK3AJfnbk ooGxyIjBbrZDCXyOWLyW17lrg5LEnvUxE/OBixnJSDDs8NMAcpGHvj1NVYRF5L2rdA/9 iSVf7aRXBswV65TbOk+9cjfBJPtDUakDe3ZUatwNXGVvd8pjEd0QtT2lepJ9hWyqm/h1 I8QQ== X-Gm-Message-State: AGRZ1gIk74ow1jDqbjou3Oojug3BxcKHkPxO/mR8ch9J2LIRvz3PqTtY mlEHGE6+XEM7Ut6mq85TP4QaP5bT2rSW/drBFbeEVQ== X-Google-Smtp-Source: AJdET5fwo41opRwzJmMxRuBTUya8fxZnEVnuVqtDPCKecY7kjft54mMDnwd8d/aIi4X/HfHFk8f90c95WIiE+Fi/KM0= X-Received: by 2002:a24:940f:: with SMTP id j15-v6mr56835ite.34.1541149464086; Fri, 02 Nov 2018 02:04:24 -0700 (PDT) MIME-Version: 1.0 References: <1541116003074-0.post@n5.nabble.com> <422D5E5F-8719-4DDC-A5F6-DA050E239FAC@gmail.com> <1541126998626-0.post@n5.nabble.com> <338AF5E2-7692-4631-B367-61AF1BC712DD@gmail.com> <1541128509998-0.post@n5.nabble.com> In-Reply-To: From: Guillaume Laforge Date: Fri, 2 Nov 2018 10:04:11 +0100 Message-ID: Subject: Re: Groovy 2.5.4 planning To: dev@groovy.apache.org, Paul King Content-Type: multipart/alternative; boundary="0000000000005a50250579aad27a" --0000000000005a50250579aad27a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I was also thinking of a Boolean in a constructor. Le ven. 2 nov. 2018 =C3=A0 07:23, Paul King a =C3=A9cr= it : > While I think security is very important to consider, I am unsure whether > the switch is the way to go. Such switches are global in nature and that > means you can't as easily as you might like use different GProperty > instances in different contexts with different security contexts. > > Given use of GProperties is totally opt-in, I am wondering if a switch is > needed but I am open to others thoughts on this topic. If a switch is > needed, my suggestion would be different constructors with some boolean > flags to indicate what features are enabled for a particular instance. > > Cheers, Paul. > > > On Fri, Nov 2, 2018 at 1:15 PM Daniel Sun wrote= : > >> Hi Andres, >> >> > if GProperties is added to core I=E2=80=99d suggest to set that = flag to >> false as default. >> Agreed :) >> >> > Additionally, couldn=E2=80=99t this behavior be added to ConfigS= lurper? >> As you can see, `GProperties` is a subclass of `Properties`, I >> recommend groovy users to use the enhanced `Properties` by >> default(`GProperties` to `Properties` is similar with `GString` to >> `String`), which can handle properties smartly and handle input >> stream/reader properly >> >> Cheers, >> Daniel.Sun >> >> >> >> -- >> Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html >> > --0000000000005a50250579aad27a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I was also thinking of a Boolean in a constructor.
<= br>
Le ven. 2 nov. 2018 =C3=A0 0= 7:23, Paul King <paulk@asert.com.a= u> a =C3=A9crit=C2=A0:
While I think security is very important to consider, I am unsu= re whether the switch is the way to go. Such switches are global in nature = and that means you can't as easily as you might like use different GPro= perty instances in different contexts with different security contexts.
Given use of GProperties is totally opt-in, I am wondering if a s= witch is needed but I am open to others thoughts on this topic. If a switch= is needed, my suggestion would be different constructors with some boolean= flags to indicate what features are enabled for a particular instance.

Cheers, Paul.


On Fri, Nov 2, 2018 at 1:15 PM Dan= iel Sun <realbluesun@hotmail.com> wrote:
Hi Andres,

=C2=A0 =C2=A0 =C2=A0 > if GProperties is added to core I=E2=80=99d sugge= st to set that flag to
false as default.
=C2=A0 =C2=A0 =C2=A0 Agreed :)

=C2=A0 =C2=A0 =C2=A0 > Additionally, couldn=E2=80=99t this behavior be a= dded to ConfigSlurper?
=C2=A0 =C2=A0 =C2=A0 As you can see, `GProperties` is a subclass of `Proper= ties`, I
recommend groovy users to use the enhanced `Properties` by
default(`GProperties` to `Properties` is similar with `GString` to
`String`), which can handle properties smartly and handle input
stream/reader properly

Cheers,
Daniel.Sun



--
Sent from: http://groovy.329449= .n5.nabble.com/Groovy-Dev-f372993.html
--0000000000005a50250579aad27a--