From dev-return-5155-archive-asf-public=cust-asf.ponee.io@groovy.apache.org Sat Aug 4 00:16:58 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 01E6E180647 for ; Sat, 4 Aug 2018 00:16:57 +0200 (CEST) Received: (qmail 16824 invoked by uid 500); 3 Aug 2018 22:16:57 -0000 Mailing-List: contact dev-help@groovy.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@groovy.apache.org Delivered-To: mailing list dev@groovy.apache.org Received: (qmail 16813 invoked by uid 99); 3 Aug 2018 22:16:56 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Aug 2018 22:16:56 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 08D241A145E for ; Fri, 3 Aug 2018 22:16:56 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.033 X-Spam-Level: **** X-Spam-Status: No, score=4.033 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=2, KAM_INFOUSMEBIZ=0.75, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, T_DKIMWL_WL_MED=-0.01, URI_HEX=1.313] autolearn=disabled Authentication-Results: spamd2-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=asert-com-au.20150623.gappssmtp.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id fGhz-pqC8Axr for ; Fri, 3 Aug 2018 22:16:54 +0000 (UTC) Received: from mail-oi0-f50.google.com (mail-oi0-f50.google.com [209.85.218.50]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 06C645F2AA for ; Fri, 3 Aug 2018 22:16:53 +0000 (UTC) Received: by mail-oi0-f50.google.com with SMTP id k12-v6so12447224oiw.8 for ; Fri, 03 Aug 2018 15:16:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=asert-com-au.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:reply-to:from:date:message-id :subject:to; bh=g3P8uoe2qK2IA1MjCYtiOYHsAXNyKgWt75PpegNfpA4=; b=npMEbnu6qhmzZMYGvtE3DXBN7AebmSD1DwhsWO0QGJvLIe0g7VWp4TB7NmKe1ZoYrA lO2fsgQlPDeZcv7+5wJiYhHSk4Zgvn593Vvr56XqeCnMmzcdRWN4778nG+lmAyySx+PS tNwqHByNrYeEf7bfJcGwPFJiR9Qex3aCYHESc2L2PmOofnPPOmbyt1QFqf5je3+aN/E3 NjHykocM5gsZfxavHTFze+KYLFZmeHcFubE91Kz5Tajfy+aA1CvMmSExD1Tx359R90ry 6HAjH5WPVIVnKlKh9i/fyaROsN16EY+/qSCQGDderLd1ucP5dDLQuloF1QWV+D+iefOh FZTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to; bh=g3P8uoe2qK2IA1MjCYtiOYHsAXNyKgWt75PpegNfpA4=; b=B1a1MsEdnKO2jat4Cw8hq0JMUmkSmQ439brEP9zhvZuya+avrz3Iz7RpIFQmZ6G6xg a5KOV0J3RMVy120YBNrRjQ8BYSl97XiLGj0TU29AxfBiGHZEoXsFvar73EjE4etAsdnY /R8YMo3y1yUYvjPDONie62XbrXTY7rsutg/9L0hywRq6VOyN3l/DEmYJSx8TIrPyyFZC qTm0f9iqTVunwGILVC6Hl7NtZMUCGwORQlfKzY4G5FdjldkDuYSQKICVQ5mt2rx8/OVw xpoU9G4nnGj52yI3STkSa3cWmgYsHGw0j04nuC7AablMoD+hj27UPZWg8otRFiES3aoS OaDA== X-Gm-Message-State: AOUpUlGm2U1G8bf7xm+U2Mi/jmsPuWDJznIOqM2RkP8bAJVPyZe7x5CG UAa3nRm32xBkCI8/z9Jtmo2WHx2y+pwsVc1hWLmogLDY X-Google-Smtp-Source: AAOMgpfJ/Jl1vBgsRMURWROeqDDc9b941EYXoSrOLZiZL4Yt/5PSdoeN3NuWLluqSyEa+nspVBZHsN/zSY5eVcOAS54= X-Received: by 2002:aca:e510:: with SMTP id c16-v6mr5372877oih.44.1533334612591; Fri, 03 Aug 2018 15:16:52 -0700 (PDT) MIME-Version: 1.0 References: <1533333151224-0.post@n5.nabble.com> In-Reply-To: <1533333151224-0.post@n5.nabble.com> Reply-To: paulk@asert.com.au From: Paul King Date: Sat, 4 Aug 2018 08:16:43 +1000 Message-ID: Subject: Re: About the additional resolving phase of compilation To: dev@groovy.apache.org Content-Type: multipart/alternative; boundary="000000000000e7df1905728f4842" --000000000000e7df1905728f4842 Content-Type: text/plain; charset="UTF-8" I think that is worth exploring. There was a valid reason but I can't remember just now. I'll try to jog my memory from the code/mailing archives. FYI, I was thinking in fact we might have to go the other way. And repeat also Canonical. That way our Java stubs would be much better for joint compilation. We'd have to make a whole lot of steps idempotent before that would work though. If we do it right, we could skip a lot the second time through - which we might even be able to improve for the current repeated phase. Cheers, Paul. On Sat, Aug 4, 2018 at 7:52 AM Daniel.Sun wrote: > Hi all, > > As we all know, resolving is quite complicated and time consuming in > Groovy, but the resolving is applied twice currently. The additional > resolving is applied here: > > https://github.com/apache/groovy/blob/master/src/main/java/org/codehaus/groovy/control/CompilationUnit.java#L581-L584 > > If the additional resoving is removed, only one test fails. > > Could you recall why we have to resolve twice? And can we try to > apply > resolving only once for better performance? > > Cheers, > Daniel.Sun > > > > > ----- > Daniel Sun > Apache Groovy committer > Blog: http://blog.sunlan.me > Twitter: @daniel_sun > > -- > Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html > --000000000000e7df1905728f4842 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I think that is worth exploring. There was a valid reason = but I can't remember just now.
I'll try to jog my memory from t= he code/mailing archives.

FYI, I was thinking in fact we= might have to go the other way. And repeat also Canonical.
That = way our Java stubs would be much better for joint compilation. We'd hav= e to
make a whole lot of steps idempotent before that would work = though. If we do it right,
we could skip a lot the second time th= rough - which we might even be able to improve
for the current re= peated phase.

Cheers, Paul.



On= Sat, Aug 4, 2018 at 7:52 AM Daniel.Sun <sunlan@apache.org> wrote:
Hi all,

=C2=A0 =C2=A0 =C2=A0 As we all know, resolving is quite complicated and tim= e consuming in
Groovy, but the resolving is applied twice currently. The additional
resolving is applied here:
https://github.com/apache/groovy/blob/master/src/main/java= /org/codehaus/groovy/control/CompilationUnit.java#L581-L584

=C2=A0 =C2=A0 =C2=A0 If the additional resoving is removed, only one test f= ails.

=C2=A0 =C2=A0 =C2=A0 Could you recall why we have to resolve twice? And can= we try to apply
resolving only once for better performance?

Cheers,
Daniel.Sun




-----
Daniel Sun
Apache Groovy committer
Blog: http://blog.sunlan.me
Twitter: @daniel_sun

--
Sent from: http://groovy.329449.n5.nabble.= com/Groovy-Dev-f372993.html
--000000000000e7df1905728f4842--