From dev-return-5153-archive-asf-public=cust-asf.ponee.io@groovy.apache.org Fri Aug 3 23:52:39 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 7ADF1180647 for ; Fri, 3 Aug 2018 23:52:39 +0200 (CEST) Received: (qmail 68781 invoked by uid 500); 3 Aug 2018 21:52:38 -0000 Mailing-List: contact dev-help@groovy.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@groovy.apache.org Delivered-To: mailing list dev@groovy.apache.org Received: (qmail 68771 invoked by uid 99); 3 Aug 2018 21:52:38 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Aug 2018 21:52:38 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 32381C5D06 for ; Fri, 3 Aug 2018 21:52:38 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.034 X-Spam-Level: *** X-Spam-Status: No, score=3.034 tagged_above=-999 required=6.31 tests=[KAM_INFOUSMEBIZ=0.75, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_SOFTFAIL=0.972, URI_HEX=1.313] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id w0oIKclAwK4V for ; Fri, 3 Aug 2018 21:52:37 +0000 (UTC) Received: from n5.nabble.com (n5.nabble.com [162.253.133.81]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 4C7875F118 for ; Fri, 3 Aug 2018 21:52:37 +0000 (UTC) Received: from n5.nabble.com (localhost [127.0.0.1]) by n5.nabble.com (Postfix) with ESMTP id 378377DE68D9 for ; Fri, 3 Aug 2018 14:52:31 -0700 (MST) Date: Fri, 3 Aug 2018 14:52:31 -0700 (MST) From: "Daniel.Sun" To: dev@groovy.incubator.apache.org Message-ID: <1533333151224-0.post@n5.nabble.com> Subject: About the additional resolving phase of compilation MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Hi all, As we all know, resolving is quite complicated and time consuming in Groovy, but the resolving is applied twice currently. The additional resolving is applied here: https://github.com/apache/groovy/blob/master/src/main/java/org/codehaus/groovy/control/CompilationUnit.java#L581-L584 If the additional resoving is removed, only one test fails. Could you recall why we have to resolve twice? And can we try to apply resolving only once for better performance? Cheers, Daniel.Sun ----- Daniel Sun Apache Groovy committer Blog: http://blog.sunlan.me Twitter: @daniel_sun -- Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html