From dev-return-5040-archive-asf-public=cust-asf.ponee.io@groovy.apache.org Fri Jun 15 17:38:34 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 280A6180636 for ; Fri, 15 Jun 2018 17:38:33 +0200 (CEST) Received: (qmail 70844 invoked by uid 500); 15 Jun 2018 15:38:33 -0000 Mailing-List: contact dev-help@groovy.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@groovy.apache.org Delivered-To: mailing list dev@groovy.apache.org Received: (qmail 70833 invoked by uid 99); 15 Jun 2018 15:38:32 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Jun 2018 15:38:32 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 185291A28F7 for ; Fri, 15 Jun 2018 15:38:32 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.201 X-Spam-Level: X-Spam-Status: No, score=-0.201 tagged_above=-999 required=6.31 tests=[KAM_NUMSUBJECT=0.5, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 5i6ZLWufINIX for ; Fri, 15 Jun 2018 15:38:31 +0000 (UTC) Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 412DB5F432 for ; Fri, 15 Jun 2018 15:38:30 +0000 (UTC) Received: from [192.168.1.5] ([89.13.120.121]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0Lyj4F-1gGKXq3NB9-01681T for ; Fri, 15 Jun 2018 17:38:29 +0200 Subject: Re: module information creation for Groovy 3 To: dev@groovy.apache.org References: <1064017222.1792050.1529045900406.JavaMail.zimbra@u-pem.fr> From: Jochen Theodorou Message-ID: <6ecc61a4-f715-7d91-fadd-f13eb99e1636@gmx.org> Date: Fri, 15 Jun 2018 17:38:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <1064017222.1792050.1529045900406.JavaMail.zimbra@u-pem.fr> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:gBVFcSTbWEGFJKjzxRTmg4rNnq1x2coSRP5kSQEHtXONiakmHUo oJ22URckg/4nYEu/UsEFlSfEmfkRoSG21t+XGAxLPP2mIeYc17sntXv+bXhYsR5Ivk+dn1k 7nnpk6VG9t1YsJ0QXuG+eYRbZYGAIDvjc2TQ3S0UBZ0/XesNnarTkmQlpm8yCGgqzPaMGBC Gg1hS2aD+zplJ6Y4D2Lbw== X-UI-Out-Filterresults: notjunk:1;V01:K0:QKbwMIoLQJE=:Z+ROYkwyTGDQow2NOy6KIb diRnb2z773eZ0r5I3tSr4X1bZM6j037WJeCFQYajW8069+elOwTsbf2ZCddW9Q0agkov0nxs9 vhzm5tDO8qWjoBxw9yihct2HDcuW/G3kPmXBvAfNKhUPCRufYHMDWS2BS59mwuOxpbrhHwqjj eblM+7i4VRjUuz9HbUEiPqPrxXYZguQ9dB7xUO0QBGq9JzW1rEpSK8TlyTs8S2XjyWRp1Hmmf brJKz5O87y2S/Wf24S5N3KhINKfEA91TLLQzFze2vH/xwyM7jURPAcvaGjSiRQh/CRwOIAjzG PDSG4YyUN9z50BFcxzEo1g23xqtcjWb0uvWFjghqDofE6VbdoyyD3hjlPXbJvetzYVEmQ29gv J6wPww1CPGT41GQeASi6jzV5x31NKi0Bx78lWLn4fF6fjbLjT0asvoK77CJo/vNk25mrYBnYX QXyGOZ3FTtmj0ZEmO1ZgkKe8bB/GdlmvzWVLBdVkCjsaK+T3fIedUs1fKj/YC80vfs6TvwLNp ONuXHPtiJEJWE7ks3WE+KkrdCJ8RYlUT0KuUZE/irCAtkTA3kyHhBUDO4S+t4UN7Y3nnUMCTu hmODIIVhVNoeXtwyIyOoG64IZB9j/s6iPizZ7+LPqwEpnAQMYgv7QLf20xx3+zu6zJ2JJymuH q+u/bxI62ZzhWuRmC4FTBi696NFEKfmjAHYwY/K/0nkybuOwgcNOHvmmN0EhlPSm8bbh0Nbdh 1RAf/cVUYq0G3x/5XFfEG8Jx64YoYmadv8qCzSPu2hV56t+f/v/IJ3/+FeaGNVA27oApOoyCi DWFRoGO Am 15.06.2018 um 08:58 schrieb Remi Forax: > Hi, > moditech provides two different things, > - if you are an application, you can add the module-info to your dependencies, from the POV of the VM, it means all your code will be modular so you can use jlink to create a minimal docker file > - you can add module-info to your own jar > > The first case is fully valid, i do the same thing but fully automatically (doing a static analysis) with pro [1], it's great but only works if you are the final application, not a library, > the second case adds maintenance burden because the module-info doesn't get updated when you change the code source or the pom.xml, so you can have the pom and the module-info disagreeing on the dependency, a package you have just added being exported by default exported (instead of been non-exported by default), a service being declared in the META-INF but not in the module-info etc. > > So it means that you have to test your produced jars twice, with the classpath and with the module-path to catch the regressions you may have introduced by not updating the moditech plugin configuration to the changes done in the source code. Without modifying the test to run twice, you will get nasty surprises :( that might be true, but don't I have to do this anyway? And not only that. I have to test as a system module as well. bye Jochen