From dev-return-4901-archive-asf-public=cust-asf.ponee.io@groovy.apache.org Fri May 25 13:52:57 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 00BCA180627 for ; Fri, 25 May 2018 13:52:56 +0200 (CEST) Received: (qmail 64061 invoked by uid 500); 25 May 2018 11:52:55 -0000 Mailing-List: contact dev-help@groovy.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@groovy.apache.org Delivered-To: mailing list dev@groovy.apache.org Received: (qmail 64051 invoked by uid 99); 25 May 2018 11:52:55 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 25 May 2018 11:52:55 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id CD43CC02CF for ; Fri, 25 May 2018 11:52:54 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.701 X-Spam-Level: X-Spam-Status: No, score=-0.701 tagged_above=-999 required=6.31 tests=[RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id bDrWep_mzjlX for ; Fri, 25 May 2018 11:52:52 +0000 (UTC) Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 3958E5F581 for ; Fri, 25 May 2018 11:52:52 +0000 (UTC) Received: from [192.168.0.138] ([195.141.68.118]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MNw0t-1fRvlu3AbL-007VKU for ; Fri, 25 May 2018 13:52:45 +0200 Subject: Re: Performance of the compiler To: dev@groovy.apache.org References: <1527236242181-0.post@n5.nabble.com> <1527245471913-0.post@n5.nabble.com> From: Jochen Theodorou Message-ID: Date: Fri, 25 May 2018 13:52:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <1527245471913-0.post@n5.nabble.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:fJUamE1txx6guXp2TSpYHt4cERYJET07mPp/SeP5mcqGQ9YA24d N6Ze/paWVDAGKEL6OnxEZwr6J2tY4Hzgz6WFpuujqFX1ncn7bupa8XaXnHvg2CwHv4IRZoq J7CTqZ3O2LNrnPbFoZJNgsfxFtIb1pN4zgcYou9wCOgw/Jmd3pnSH/oyIs2/T7ApwuPBguN IkU2ggy9JxjNk13LoUO/Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:2dEsEbWuvcM=:Bn/7bQA4+s424FxtTWAiuM AIF0xpgK4yyrUL0fOvVJsNnSXCmQu6RxnvxcZerU9Qnn0i16c5uS5s6unSj15uFr0HQPKCUlt cb/HHSeVcTFYkPogTtbm24Z+5qYJW+i0P376j/i1ZfgbR1zkPj09q8blmUt5YVzl4cnSu/YVt JHeCV3XncWx4f0rNvLY83YMTf51WMqywjTU+uS/hGCnOjybeFs45YOmfR0nBTNpiABVFzjPt/ o3RBubft74DN55ma272QiFQ0rLBZ+/ZiamfpyRgPUHzVwYGgoQYHZ48fRG+GImOeRXHuP2JOk YSMCPiE9blZjJFwb9r7e8MizCVkdmxZYTDnYvq2mf24Lg2E5fA2GweF4j4OelzcqFnOda4ldq P+HlfrtW6UqlpDoFc1XUFuOQ8dFnTD2WCp1jyZNqB7Z0HDLgnsBHywVsOC11AUWeXPdYyUPgw S1pxyZTvspqNynnb5pzU8/6JxuKjM9+eO5+bmlN63IWJPhpkxAY82uweHoVGJU7+tSPqSnCvZ iDRful4oxABWQ8OvJFeZM5eV1T1w7A2YnnYrd0cHROn7ctEKClFUH5OFJ3nc3dV18+wfBWqwU f0N2dvv0w9PyD0mDjagJJmAxB9wMGOGwpSJkfaFGqqT4lp/Rp1cY+DY3/PJTOcZrFcdy79d6c 773DpGVyWvgXCjw4+Ia/rVcowlG5LwXybHkDD8b6B2N0IaRAYdByZZB/+lXzKnkAOAfWWpAM0 55XFVi5m9BKWClWxUJTbNKGHuWupTTS9Esp3vOzOa13qKgkccWD+DZlhaNOV4is/wFx428d4Q hkb5LmO Am 25.05.2018 um 12:51 schrieb Daniel.Sun: > Hi Cédric, > > I am not going to cache ClassNode instance(just cache class names, > which are `String`), but I want to add a check whether the name of the > ClassNode being resolved is possibly in the default imported packages, e.g. > If a ClassNode instance's name is `Foobar`(apparently it could not be in any > default imported packages), then we can `return false` immediately and the > further resolving can be eliminated. but this means we will have to manually update the list for java.lang, java.util, java.io and java.net Take for example Module. It is new in Java 9 and is in java.lang. If we had this logic already in say Groovy 2.0 I am pretty sure the last versions till Groovy 2.3 would not be able to resolve this class anymore then. I think there would be no problem with Java10, but think of Java 11... we do not know yet. bye Jochen