From dev-return-4834-archive-asf-public=cust-asf.ponee.io@groovy.apache.org Tue May 22 07:37:53 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id D8181180638 for ; Tue, 22 May 2018 07:37:52 +0200 (CEST) Received: (qmail 79984 invoked by uid 500); 22 May 2018 05:37:46 -0000 Mailing-List: contact dev-help@groovy.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@groovy.apache.org Delivered-To: mailing list dev@groovy.apache.org Received: (qmail 79606 invoked by uid 99); 22 May 2018 05:37:46 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 May 2018 05:37:46 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 2E972CD569 for ; Tue, 22 May 2018 02:52:36 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.471 X-Spam-Level: ** X-Spam-Status: No, score=2.471 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=2, HTML_OBFUSCATE_05_10=0.001, KAM_NUMSUBJECT=0.5, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, T_DKIMWL_WL_MED=-0.01] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=asert-com-au.20150623.gappssmtp.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id Wd9z5xM4TJ7n for ; Tue, 22 May 2018 02:52:34 +0000 (UTC) Received: from mail-oi0-f42.google.com (mail-oi0-f42.google.com [209.85.218.42]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 3A2335F35A for ; Tue, 22 May 2018 02:52:34 +0000 (UTC) Received: by mail-oi0-f42.google.com with SMTP id k5-v6so14868059oiw.0 for ; Mon, 21 May 2018 19:52:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=asert-com-au.20150623.gappssmtp.com; s=20150623; h=mime-version:reply-to:in-reply-to:references:from:date:message-id :subject:to; bh=0scV/htiukeODeOxD//C9JsnDPI961LP8h655rVmN70=; b=X8+Ai0qrHgjogxBdLJoA1MVgM6LGzUuMKwc7fBRIIgC43Euk2wY4YC9dms1kP/3KRt Uifz9FiKtVaE+3qeHxctzA6md9q35l2HVAeXrgjOG3pMjBPoxRS1O8QtaFbA1u1UMz7J qosn3c+swnkppFEeRxrZaChX/C/JbBNOT2A0J2rHT7x9J8VYr+nMvvfnh2odL+2hfKbC lO733UgWeUnIJdPjrTQOcCkAZr1tZbq1no1D6iC3+rX6pjj5mMsxpIyvSXw+ETqjpa++ SIJl6FnHeD8BoQarXmPwpg4AOiBbSCqX+neFJ5e5yU5RImub1WuxshZ5UHo3a/PfFpw1 lS2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to; bh=0scV/htiukeODeOxD//C9JsnDPI961LP8h655rVmN70=; b=kHqpq6ozwmKTbixCeqtc1ugFTvwq5zHUkXQBMDfmVeffpl/6ryES8zqYmVmHvmWogk eYoxxqPNHj61rqWZV0HoZHnVAhiO3C0PqkQzo2Cyd4cSfH7wqDJWJPc8IfyGmhICGH9O WbFt/aBy8UxFfjlBXAbhc3WObBbmipTH4/wYU3O9n5pwsVMvtbhRFYF9WMpMRqTeGaBg rG43M1DQ8GUwhFyH7e5Pud/Tu3T1r/hotbj2oZW3ziDvvKLfvvHBm9EFhCgzTWr0Vkdm UEFK45VWsf5/bJG5djwnS3puMq8ScvlR9cxx7ZTw+O2fV+X2pQs8acY04USCZzHkFd6O IQ4w== X-Gm-Message-State: ALKqPwdq/6PvDyptQyOWsG8WO3EKsuwM/VUl8P0vT5RyMiu/ifdUmCNE gk5cEOmSoIxTYBKJQhDC4BD6pBZRPeKZyNAJIvVo2w== X-Google-Smtp-Source: AB8JxZrkp9zajPjgl+A2w4Ehv4TjnFTUgT2fHXEo+6ekxE8shHIPvBYOrY++jFkbmKeZwfMh0JCLBtd75oAVyZizSOQ= X-Received: by 2002:aca:4bcb:: with SMTP id y194-v6mr13782094oia.208.1526957553257; Mon, 21 May 2018 19:52:33 -0700 (PDT) MIME-Version: 1.0 Received: by 10.74.165.209 with HTTP; Mon, 21 May 2018 19:52:32 -0700 (PDT) Reply-To: paulk@asert.com.au In-Reply-To: References: <6d720829-8bb4-e070-32df-f2f8ce4a2910@gmx.org> From: Paul King Date: Tue, 22 May 2018 12:52:32 +1000 Message-ID: Subject: Fwd: [VOTE] Release Apache Groovy 2.5.0-rc-3 To: dev@groovy.apache.org Content-Type: multipart/alternative; boundary="0000000000008c9cdf056cc28246" --0000000000008c9cdf056cc28246 Content-Type: text/plain; charset="UTF-8" Sorry, I accidentally went off-list. ---------- Forwarded message ---------- From: Paul King Date: Tue, May 22, 2018 at 12:22 PM Subject: Re: [VOTE] Release Apache Groovy 2.5.0-rc-3 To: Remko Popma The warnings are by design. The java.time classes are only in JDK8, so our extensions wouldn't make sense to load in JDK7. The windows warning is I guess a bug that we've never addressed. If you go into windows registry via regedit and create the "Prefs" directory manually, the error will go away on that machine. I believe we are just using Java classes to write out preferences and the assumption was that it was a Java bug that would eventually be fixed. Perhaps it's worth re-looking at. The consequence is that it won't remember if you change the groovyConsole window size or default font size etc. but everything else will still work as expected. On Tue, May 22, 2018 at 8:58 AM, Remko Popma wrote: > Potential Java 7 issue: > > When I run the grape, groovyDoc, groovyConsole or groovysh command line > tools with environment variable JAVA_HOME set to my JDK-7 installation, I > see two warnings that the extensions and the static extensions for Date > could not be installed. > > $ groovyDoc > May 22, 2018 7:52:28 AM org.codehaus.groovy.runtime.m12n.MetaInfExtensionModule > newModule > WARNING: Module [groovy-datetime] - Unable to load extension class > [org.apache.groovy.datetime.extensions.DateTimeExtensions] > May 22, 2018 7:52:28 AM org.codehaus.groovy.runtime.m12n.MetaInfExtensionModule > newModule > WARNING: Module [groovy-datetime] - Unable to load extension class > [org.apache.groovy.datetime.extensions.DateTimeStaticExtensions] > > With groovyConsole I additionally see a warning about preferences: > > $ groovyConsole -h > May 22, 2018 7:55:58 AM org.codehaus.groovy.runtime.m12n.MetaInfExtensionModule > newModule > WARNING: Module [groovy-datetime] - Unable to load extension class > [org.apache.groovy.datetime.extensions.DateTimeExtensions] > May 22, 2018 7:55:58 AM org.codehaus.groovy.runtime.m12n.MetaInfExtensionModule > newModule > WARNING: Module [groovy-datetime] - Unable to load extension class > [org.apache.groovy.datetime.extensions.DateTimeStaticExtensions] > May 22, 2018 7:55:58 AM java.util.prefs.WindowsPreferences > WARNING: Could not open/create prefs root node Software\JavaSoft\Prefs at > root 0x80000002. Windows RegCreateKeyEx(...) returned error code 5. > > Is anyone else also seeing this? > > Remko > > On Tue, May 22, 2018 at 0:27 Paul King wrote: > >> If you run: ./gradlew rat >> It should exclude all the necessary files using the excludes in >> gradle/quality.gradle >> (the excludes list actually has some extra entries so you can run it on >> the full repo - which includes a few things we don't put in the src zip) >> >> As for the other tools still using commons CLI, it was intentional >> originally as a way to test the legacy CliBuilder support but I think >> we have that in hand now, so PRs welcome. >> >> I fixed the getParser typo. Thanks for spotting that. It would have still >> worked but not achieved the desired outcome. >> >> We'll have to check all of the doco. There are numerous adoc files for >> tools-groovy, tools-groovyc, groovydoc, etc. >> >> Cheers, Paul. >> >> >> On Tue, May 22, 2018 at 12:04 AM, Remko Popma >> wrote: >> >>> +1 >>> >>> When building the GROOVY_2_5_X branch, I see failing RAT tests: >>> >>> $project/subprojects/groovy-templates/out/test/resources/inc >>> ludes/hello-escaped.txt >>> $project/subprojects/groovy-templates/out/test/resources/inc >>> ludes/hello.html >>> $project/subprojects/groovy-templates/out/test/resources/raw.txt >>> $project/subprojects/groovy-templates/out/test/resources/to_ >>> be_escaped.txt >>> >>> Not a showstopper, but can these be excluded from the RAT checks somehow? >>> >>> >>> Other things I noticed (none of them showstoppers, I believe): >>> >>> Out of the command line tools in bin, three were migrated from >>> commons-cli to picocli (groovy, groovyc and grape), so they show usage help >>> in ANSI colors and have consistent version, help and classpath switches. >>> The others (groovysh, groovyConsole and groovydoc) either explicitly >>> import groovy.cli.commons.CliBuilder or implicitly import >>> groovy.util.CliBuilder. This means that these tools don't show help in ANSI >>> colors. Their version, help and classpath switches also look different than >>> the first-mentioned tools. If this was intentional then no problem. >>> Otherwise it may be good to import groovy.cli.picocli.CliBuilder so they >>> all have usage help in ANSI colors, and perhaps align the switches. If >>> there is interest I would like to generate auto-completion scripts for all >>> tools, if they are all picocli-based that becomes easier. >>> >>> groovy.util.CliBuilder now has two deprecated setParser methods. I >>> believe the intention is that the one on line 60 should be named getParser >>> instead? >>> Also, should a deprecated getter/setter for Options be added? >>> >>> The docs for the grape command line tool (groovy-2.5.0-rc-3/html/docume >>> ntation/grape.html#Grape-CommandLineTool) is a bit out of date: missing >>> the uninstall subcommand and missing the classifier argument for the >>> install subcommand. >>> >>> >>> >>> >>> >>> >>> On Mon, May 21, 2018 at 4:03 AM, Jochen Theodorou >>> wrote: >>> >>>> +1 >>>> >>>> On 19.05.2018 17:40, Paul King wrote: >>>> >>>>> >>>>> Dear development community, >>>>> >>>>> I am happy to start the VOTE thread for a Groovy 2.5.0-rc-3 release! >>>>> >>>>> This release includes 27 bug fixes/improvements as outlined in the >>>>> changelog: >>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje >>>>> ctId=12318123&version=12343166 >>>>> >>>>> Tag: https://git1-us-west.apache.org/repos/asf?p=groovy.git;a=tag >>>>> ;h=refs/tags/GROOVY_2_5_0_RC_3 >>>>> Tag commit id: 6bff836d8373ff58f27f31106e9179eb4ab6b3ad >>>>> >>>>> The artifacts to be voted on are located as follows (r27001). >>>>> Source release: https://dist.apache.org/repos/ >>>>> dist/dev/groovy/2.5.0-rc-3/sources >>>>> Convenience binaries: https://dist.apache.org/repos/ >>>>> dist/dev/groovy/2.5.0-rc-3/distribution >>>>> >>>>> Release artifacts are signed with a key from the following file: >>>>> https://dist.apache.org/repos/dist/dev/groovy/KEYS >>>>> >>>>> Please vote on releasing this package as Apache Groovy 2.5.0-rc-3. >>>>> >>>>> Reminder on ASF release approval requirements for PMC members: >>>>> http://www.apache.org/legal/release-policy.html#release-approval >>>>> Hints on validating checksums/signatures (but replace md5sum with >>>>> sha256sum): >>>>> https://www.apache.org/info/verification.html >>>>> >>>>> The vote is open for the next 72 hours and passes if a majority of at >>>>> least three +1 PMC votes are cast. >>>>> >>>>> [ ] +1 Release Apache Groovy 2.5.0-rc-3 >>>>> [ ] 0 I don't have a strong opinion about this, but I assume it's ok >>>>> [ ] -1 Do not release Apache Groovy 2.5.0-rc-3 because... >>>>> >>>>> Here is my vote: >>>>> >>>>> +1 (binding) >>>>> >>>>> >>>> >>> >> --0000000000008c9cdf056cc28246 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Sorry, I accidentally went off-list.
---------- Forwarded message ----------
Fro= m: Paul King <paulk@asert.com.au>
Date: = Tue, May 22, 2018 at 12:22 PM
Subject: Re: [VOTE] Release Apache Groovy = 2.5.0-rc-3
To: Remko Popma <= remko.popma@gmail.com>


The warnings are = by design. The java.time classes are only in JDK8, so our extensions wouldn= 't make sense to load in JDK7.

The windows warning i= s I guess a bug that we've never addressed. If you go into windows regi= stry via regedit
and create the "Prefs" directory manua= lly, the error will go away on that machine. I believe we are just using
Java classes to write out preferences and the assumption was that i= t was a Java bug that would eventually be fixed.
Perhaps it's= worth re-looking at. The consequence is that it won't remember if you = change the groovyConsole window
size or default font size etc. bu= t everything else will still work as expected.


On Tue, May 22, 2018 at 8:58 AM, Remko = Popma <remko.popma@gmail.com> wrote:
Potential Java 7 issue:

When I run the grape, groovyDoc, groovyConsole or groo= vysh command line tools with environment variable JAVA_HOME set to my JDK-7= installation, I see two warnings that the extensions and the static extens= ions for Date could not be installed.=C2=A0

$ groovyDoc
May 22, 2018 7:52:28 AM org= .codehaus.groovy.runtime.m12n.MetaInfExtensionModule newModule
WARNING: Module [groovy-datetime] - Unable to load extension class [org.= apache.groovy.datetime.extensions.DateTimeExtensions]
May 22= , 2018 7:52:28 AM org.codehaus.groovy.runtime.m12n.MetaInfExtensionMod= ule newModule
WARNING: Module [groovy-datetime] - Unable to load = extension class [org.apache.groovy.datetime.extensions.DateTimeStaticE= xtensions]

With groovyConsole I additionally = see a warning about preferences:

$ groovyCons= ole -h
May 22, 2018 7:55:58 AM org.codehaus.groovy.runtime.m12n.MetaInfExtensionModule newModule
WARNING: Module [groovy-date= time] - Unable to load extension class [org.apache.groovy.datetime.ext= ensions.DateTimeExtensions]
May 22, 2018 7:55:58 AM org.codehaus.= groovy.runtime.m12n.MetaInfExtensionModule newModule
WARNING= : Module [groovy-datetime] - Unable to load extension class [org.apache.gro= ovy.datetime.extensions.DateTimeStaticExtensions]
May 2= 2, 2018 7:55:58 AM java.util.prefs.WindowsPreferences <init>
WARNING: Could not open/create prefs root node Software\JavaSoft\Pre= fs at root 0x80000002. Windows RegCreateKeyEx(...) returned error code 5.

Is anyone else also seeing this?

Remko=C2=A0

On Tue, May 22, 2018 at 0:27 Paul King <paulk@asert.com.au> wrote= :
If you ru= n: ./gradlew rat
It should exclude all the necessary files using the ex= cludes in gradle/quality.gradle
(the excludes list actually has s= ome extra entries so you can run it on the full repo - which includes a few= things we don't put in the src zip)

As for th= e other tools still using commons CLI, it was intentional originally as a w= ay to test the legacy CliBuilder support but I think
we have that= in hand now, so PRs welcome.

I fixed the getParse= r typo. Thanks for spotting that. It would have still worked but not achiev= ed the desired outcome.

We'll have to check al= l of the doco. There are numerous adoc files for tools-groovy, tools-groovy= c, groovydoc, etc.

Cheers, Paul.


On Tue, = May 22, 2018 at 12:04 AM, Remko Popma <remko.popma@gmail.com> wrote:=
+1

When building the GROOVY_2_5_X branch, I see failing RAT t= ests:
$project/subprojects/groovy-templates/out/test/resourc= es/includes/hello-escaped.txt
$project/subproject= s/groovy-templates/out/test/resources/includes/hello.html
$project/subprojects/groovy-templates/out/test/resources= /raw.txt
$project/subprojects/groovy-templat= es/out/test/resources/to_be_escaped.txt
N= ot a showstopper, but can these be excluded from the RAT checks somehow?


Other things I noticed (none of them = showstoppers, I believe):

Out of the command line = tools in bin, three were migrated from commons-cli to picocli (groovy, groo= vyc and grape), so they show usage help in ANSI colors and have consistent = version, help and classpath switches. The others (groovysh, groovyConsole a= nd groovydoc) either explicitly import=C2=A0groovy.cli.commons.CliBuil= der or implicitly import groovy.util.CliBuilder.=C2=A0This means that these= tools don't show help in ANSI colors. Their version, help and classpat= h switches also look different than the first-mentioned tools. If this was = intentional then no problem. Otherwise it may be good to import groovy.cli.= picocli.CliBuilder so they all have usage help in ANSI colors, and perhaps = align the switches. If there is interest I would like to generate auto-comp= letion scripts for all tools, if they are all picocli-based that becomes ea= sier.

groovy.util.CliBuilder now has two deprecate= d setParser methods. I believe the intention is that the one on line 60 sho= uld be named getParser instead?
Also, should a deprecated getter/= setter for Options be added?

The docs for the grap= e command line tool (groovy-2.5.0-rc-3/html/documentation/grape.html#G= rape-CommandLineTool) is a bit out of date: missing the uninstall subc= ommand and missing the classifier argument for the install subcommand.
<= /div>

=C2=A0



On Mon,= May 21, 2018 at 4:03 AM, Jochen Theodorou <blackdrag@gmx.org> wrote:
+1

On 19.05.2018 17:40, Paul King wrote:

Dear development community,

I am happy to start the VOTE thread for a Groovy 2.5.0-rc-3 release!

This release includes 27 bug fixes/improvements as outlined in the changelo= g:
ht= tps://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=3D= 12318123&version=3D12343166

Tag: https://git1-us-west.apache.org/repos/asf?p=3Dgroovy.git;a=3Dtag;h=3Drefs/tags/GROOVY_2_5_0_RC_3
Tag commit id: 6bff836d8373ff58f27f31106e9179eb4ab6b3ad

The artifacts to be voted on are located as follows (r27001).
Source release: https://dist.apache.= org/repos/dist/dev/groovy/2.5.0-rc-3/sources
Convenience binaries: https://d= ist.apache.org/repos/dist/dev/groovy/2.5.0-rc-3/distribution<= br>
Release artifacts are signed with a key from the following file:
https://dist.apache.org/repos/dist/dev/groovy= /KEYS

Please vote on releasing this package as Apache Groovy 2.5.0-rc-3.

Reminder on ASF release approval requirements for PMC members:
http://www.apache.org/legal/rel= ease-policy.html#release-approval
Hints on validating checksums/signatures (but replace md5sum with sha256sum= ):
https://www.apache.org/info/verification.html<= br>
The vote is open for the next 72 hours and passes if a majority of at least= three +1 PMC votes are cast.

[ ] +1 Release Apache Groovy 2.5.0-rc-3
[ ]=C2=A0 0 I don't have a strong opinion about this, but I assume it&#= 39;s ok
[ ] -1 Do not release Apache Groovy 2.5.0-rc-3 because...

Here is my vote:

+1 (binding)






--0000000000008c9cdf056cc28246--