From dev-return-4899-archive-asf-public=cust-asf.ponee.io@groovy.apache.org Fri May 25 13:10:58 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 8FDEA180627 for ; Fri, 25 May 2018 13:10:57 +0200 (CEST) Received: (qmail 1796 invoked by uid 500); 25 May 2018 11:10:51 -0000 Mailing-List: contact dev-help@groovy.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@groovy.apache.org Delivered-To: mailing list dev@groovy.apache.org Received: (qmail 1775 invoked by uid 99); 25 May 2018 11:10:50 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 25 May 2018 11:10:50 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 4D0701A0908 for ; Fri, 25 May 2018 11:10:50 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.192 X-Spam-Level: *** X-Spam-Status: No, score=3.192 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, URI_HEX=1.313] autolearn=disabled Authentication-Results: spamd2-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id eZyb82z1FgEI for ; Fri, 25 May 2018 11:10:49 +0000 (UTC) Received: from mail-it0-f51.google.com (mail-it0-f51.google.com [209.85.214.51]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id D24165F169 for ; Fri, 25 May 2018 11:10:48 +0000 (UTC) Received: by mail-it0-f51.google.com with SMTP id p3-v6so6308826itc.0 for ; Fri, 25 May 2018 04:10:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NhL7s8HQT9r13PW5BCvGSo1MpMoO5WPA24tx3chn9rU=; b=KgNn+M5awtGb4b+5uIBBIaGRPYAUC7/6rGRo34gMIRanmYD9RssjuIrsKqLgOjrpt3 3xIxLYdrYUXlIsg7FQd0myMhGpzYCvHYZ/ITYFouZOB1VPf5yQTmtxV8mcOuBwkD74V9 HCCduZEUTnsawy+AF0o/h7mPm8wOMz00UJ4aIvjd9STpeSUlutfo2n16UtJFSUjQTMQ1 TWixCqWV/hIwZeRC3eb8QxPDIbMANFuT6vXnzdbON9fgMa3Div5bciUZFNnYgyEgMCq0 KsTlyyNNboWHYi+kmkp1qeip8ttlk/yFl1dbNoDtEv49eJYfFINNMm06Y0dAd60g6WBr khqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NhL7s8HQT9r13PW5BCvGSo1MpMoO5WPA24tx3chn9rU=; b=CDGr6a7ZMHWBeSQyi6JZcdhenvOMaoCNud+BmxoSxDB9vyDRkcN1XwxQTHX8yPLLSv GZuhLyVDjj5FqYRSLvfWuVm1SDT08Qwpnrbc2mpYonguB6i4hzFvNHr/677h/MJhgl5N NurC0j5uGI//E6+evWctVGksYSbBVdDBz9jTdskhcH+leKvtUmXRnLbXqzpZ0Vd+DGi8 jatKiLCtAmJ79ZbMyxauChGoKdOCrfZ8tD6z42yAAoY+FtYWBrlfQoZKKKLYCDG1XnOT vfIZ/zJyQzK5lxrxGDwlBauq1G4fW+/jlTEdDIPGt0JsEWP1yLJm84xYQpQOVtoe9keU gvzA== X-Gm-Message-State: ALKqPwfMweBcoMSv9dJaQQZTHrwMStbIIWU2oaN4GaJAvkvG+KdOzWfe ta7uV+Q1v7WcxU8MBEet9UBO9o2oY6WGQHv/DGIYDQ== X-Google-Smtp-Source: ADUXVKLsnH6L+RJHyO1ABMixw7iiov6CcFi0o6yCQ+1E73ub681XhSlVxKGdoUsrSl4khOWIompY2kvGF3lxUwYBCm8= X-Received: by 2002:a24:64c8:: with SMTP id t191-v6mr1454226itc.5.1527246641288; Fri, 25 May 2018 04:10:41 -0700 (PDT) MIME-Version: 1.0 References: <1527236242181-0.post@n5.nabble.com> <1527245471913-0.post@n5.nabble.com> In-Reply-To: <1527245471913-0.post@n5.nabble.com> From: =?UTF-8?Q?C=C3=A9dric_Champeau?= Date: Fri, 25 May 2018 13:10:29 +0200 Message-ID: Subject: Re: Performance of the compiler To: dev@groovy.apache.org Cc: Groovy_Developers Content-Type: multipart/alternative; boundary="00000000000089e76d056d05d1c2" --00000000000089e76d056d05d1c2 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable FWIW, I tried with compileOptions.optimizationOptions.put("asmResolving", true) and it doesn't improve much the situation. Sometimes it's even slower. I didn't investigate why. Le ven. 25 mai 2018 =C3=A0 12:51, Daniel.Sun a =C3=A9cr= it : > Hi C=C3=A9dric, > > I am not going to cache ClassNode instance(just cache class names, > which are `String`), but I want to add a check whether the name of the > ClassNode being resolved is possibly in the default imported packages, e.= g. > If a ClassNode instance's name is `Foobar`(apparently it could not be in > any > default imported packages), then we can `return false` immediately and th= e > further resolving can be eliminated. > > Cheers, > Daniel.Sun > > > > -- > Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html > --00000000000089e76d056d05d1c2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
FWIW, I tried with compileOptions.optimizationOptions= .put("asmResolving", true)

and it doesn't improv= e much the situation. Sometimes it's even slower. I didn't investig= ate why.

Le=C2=A0v= en. 25 mai 2018 =C3=A0=C2=A012:51, Daniel.Sun <sunlan@apache.org> a =C3=A9crit=C2=A0:
Hi C=C3=A9dric,

=C2=A0 =C2=A0 =C2=A0I am not going to cache ClassNode instance(just cache c= lass names,
which are `String`), but I want to add a check whether the name of the
ClassNode being resolved is possibly in the default imported packages, e.g.=
If a ClassNode instance's name is `Foobar`(apparently it could not be i= n any
default imported packages), then we can `return false` immediately and the<= br> further resolving can be eliminated.

Cheers,
Daniel.Sun



--
Sent from: http://groovy.329449.n5.nabble.= com/Groovy-Dev-f372993.html
--00000000000089e76d056d05d1c2--