From dev-return-4902-archive-asf-public=cust-asf.ponee.io@groovy.apache.org Fri May 25 14:24:57 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 37D69180627 for ; Fri, 25 May 2018 14:24:57 +0200 (CEST) Received: (qmail 19347 invoked by uid 500); 25 May 2018 12:24:55 -0000 Mailing-List: contact dev-help@groovy.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@groovy.apache.org Delivered-To: mailing list dev@groovy.apache.org Received: (qmail 19335 invoked by uid 99); 25 May 2018 12:24:54 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 25 May 2018 12:24:54 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 679E2C0157 for ; Fri, 25 May 2018 12:24:54 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.102 X-Spam-Level: X-Spam-Status: No, score=-0.102 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=googlemail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id Xwh3hyifqoWw for ; Fri, 25 May 2018 12:24:52 +0000 (UTC) Received: from mail-wr0-f176.google.com (mail-wr0-f176.google.com [209.85.128.176]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 5C59A5F205 for ; Fri, 25 May 2018 12:24:51 +0000 (UTC) Received: by mail-wr0-f176.google.com with SMTP id a15-v6so8925133wrm.0 for ; Fri, 25 May 2018 05:24:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-transfer-encoding; bh=7rzD060eX5YLNvu4egJ1ncJp5QrjZV4mhrerKBpNX58=; b=djOvfvBkVAxHZTLVWjguNEdxw4uXZ0A3R/3ByS9kBsRMuhCHDocLWhpOoVT9a5GVVB PYlLRdFoGPlRqB8iRIbQwLB/swoJxGWcSFt5AAEJrtpdeWb+RhxLryjZ+bPkAUmMwEVg vvxsqMhfdrAHqbzRcxhbnZfLSChktPzU/B5dwiY0obqLsIqfT+e6HZyNo+aii4e01c0r Dy/C5nY3X3WPHgWGQ5fWBv3QOsnnOR5CIJiAhSd3FkZjWybCSel6lC5M40psA2C7lyhj be8poIK6dMRaH3qxhZfjtH2gK20LyCZgDyGslhQ3kcEwJ0h4blkksWB2B8Plh4NrG80R VAwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:content-transfer-encoding; bh=7rzD060eX5YLNvu4egJ1ncJp5QrjZV4mhrerKBpNX58=; b=bQqVrVmUl7BBKGQHlsUb4lB2gWpvH1NLu96zm/KjAmqeHo0fwhtQJXcbyhCNbdUbj/ PNdwlEs/o/ZGJKTvWFGBQOVFFe6n9krhLsjG2DR7Y25ffHTKGF3zpXRnaaFaGU45qC3s Lsbgn7bi2eixiWpawmZlpB0EbHJTJnxy9QI7CuLJzqiEGRvwyv3NdP0NZTSgFI0LnDtw UFlwApOFieZKyBmU9iWEg0Jp+M7LH1zRm256Z4TzeAnmWmgVUeBaQPyMGoLcuDrtlMKj n5iyOonSHPxtSlTU527YLqH6dXdLN9AmYteLSjXvwxbsB2tGuH+6mm0W5lRxbmxcXgdw Sq2A== X-Gm-Message-State: ALKqPwfo+48pJ8kh6xwxA2Jkj0/6x2YFdx5+mrro6wccLo4HYRhSsqwL 16oh58AJMsaxbQ7j4ENCHt6n2hfwzD3bnGp74NI= X-Google-Smtp-Source: ADUXVKLy4bgHzefuIr6dLBRux9ay0RN13ZmOHFaEE6F+GnlXNg96VKcldGqTzmWj8XO/jwGHxFbQ+z9Gozxqe7YN1zY= X-Received: by 2002:a19:c3d6:: with SMTP id t205-v6mr1360334lff.127.1527251089597; Fri, 25 May 2018 05:24:49 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a19:c945:0:0:0:0:0 with HTTP; Fri, 25 May 2018 05:24:48 -0700 (PDT) In-Reply-To: References: <1527236242181-0.post@n5.nabble.com> <1527245471913-0.post@n5.nabble.com> From: Thibault Kruse Date: Fri, 25 May 2018 21:24:48 +0900 Message-ID: Subject: Re: Performance of the compiler To: dev@groovy.apache.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Would the test performance be improved if @CompileStatic were used? I think gradle uses Spock, and last time I checked Spock could not be used with @CompileStatic. But Spock could also be removed with some effort... On Fri, May 25, 2018 at 8:52 PM, Jochen Theodorou wrote= : > > > Am 25.05.2018 um 12:51 schrieb Daniel.Sun: >> >> Hi C=C3=A9dric, >> >> I am not going to cache ClassNode instance(just cache class names, >> which are `String`), but I want to add a check whether the name of the >> ClassNode being resolved is possibly in the default imported packages, >> e.g. >> If a ClassNode instance's name is `Foobar`(apparently it could not be in >> any >> default imported packages), then we can `return false` immediately and t= he >> further resolving can be eliminated. > > > but this means we will have to manually update the list for java.lang, > java.util, java.io and java.net > > Take for example Module. It is new in Java 9 and is in java.lang. If we h= ad > this logic already in say Groovy 2.0 I am pretty sure the last versions t= ill > Groovy 2.3 would not be able to resolve this class anymore then. > > I think there would be no problem with Java10, but think of Java 11... we= do > not know yet. > > bye Jochen