From dev-return-4478-archive-asf-public=cust-asf.ponee.io@groovy.apache.org Sun Mar 25 09:16:22 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id AD1F718063B for ; Sun, 25 Mar 2018 09:16:21 +0200 (CEST) Received: (qmail 30775 invoked by uid 500); 25 Mar 2018 07:16:20 -0000 Mailing-List: contact dev-help@groovy.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@groovy.apache.org Delivered-To: mailing list dev@groovy.apache.org Received: (qmail 30761 invoked by uid 99); 25 Mar 2018 07:16:19 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 25 Mar 2018 07:16:19 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 58237C0249 for ; Sun, 25 Mar 2018 07:16:19 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.999 X-Spam-Level: * X-Spam-Status: No, score=1.999 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=asert-com-au.20150623.gappssmtp.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id stCjNwIRXE0S for ; Sun, 25 Mar 2018 07:16:17 +0000 (UTC) Received: from mail-ot0-f169.google.com (mail-ot0-f169.google.com [74.125.82.169]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id A60C25F4E4 for ; Sun, 25 Mar 2018 07:16:17 +0000 (UTC) Received: by mail-ot0-f169.google.com with SMTP id n40-v6so604238otd.3 for ; Sun, 25 Mar 2018 00:16:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=asert-com-au.20150623.gappssmtp.com; s=20150623; h=mime-version:reply-to:in-reply-to:references:from:date:message-id :subject:to; bh=fsXtSrIUSZtpu1o7C0nzoOpni4Ia2AFTTLi59/qr3aM=; b=GFSxgsRfaQVh0eB48N1jJKi0X8QPPsy0IEXB8hZpJ8Ba1NWXNCkkkZtg1Wf6RwipN4 /KMT2/guPnEJML4/Zjurb2w581jlXh7mXP+InCjBb+XuaZKtqo7n7Ro5hLAutY2RSHhN sbkcw3o72pkPxxB9ApU4xRUPjVYF0X6ulYCVwWrtVCC7r7en4VlS/xjgghBD/Lvr1N6X uvR66ISzSuH9PRJpdLeHppEWm9xsFIC9nnWvcpS+mCeAO8AmZkHC6AhGlt047JlJlkhZ 4g52EoimCO86cSotbSKqtRwPm0UFMYdy9KTe4OEzvP47pJygGYXBuOMgdPue1IOvq+xt 1Qtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to; bh=fsXtSrIUSZtpu1o7C0nzoOpni4Ia2AFTTLi59/qr3aM=; b=mFGLVeXajldFEAEqehyWv3q7QGXRsi1jvnb8ysM4Tcnpo47hXu1caJDP0f2ZAjRR92 Co5uk543DGlKFxrvvpytkBNG6MXeFSpfD10x3NjeY5Pv5xV2rulds6zaP+JUoblmdZQw 6kdsddez74JRDMEFde30+95ZlqEXf1nImuyAsYJpUxoQW1Z1bUgVbRFGP51lXi0+tGp8 jvr0PViZX2srqzN+4Cs/3B2wgFX1ttbKK8OWzBtTbfuBvP4Wev+oB5pYJlYlTglvwRrd I9vTY8efAJOIMC0zjXdAlbcyZonJkCDwoN9tklQsHQNi0lJXaMuH4GnHueL8RvrZDxUE FYGg== X-Gm-Message-State: AElRT7E82pGmVij1rHe7QeHPjOYyOJbHyTS5OlcUk8Z6SVzVDXy6pVb+ 3UsQ1ptoVDrTUxl7JwucPKJ/8VvzxkkMqCAUd/SRGQ== X-Google-Smtp-Source: AIpwx48Cx15gQDXHCFO6/GcA5wIyVaM/dGgAdQbrekSWkloUi8IGKP54IFX46sjiVgGDbSTjAlOL5aVTiy95vTjNC44= X-Received: by 2002:a9d:310d:: with SMTP id e13-v6mr3047560otc.184.1521962171009; Sun, 25 Mar 2018 00:16:11 -0700 (PDT) MIME-Version: 1.0 Received: by 10.74.22.148 with HTTP; Sun, 25 Mar 2018 00:16:10 -0700 (PDT) Reply-To: paulk@asert.com.au In-Reply-To: References: From: Paul King Date: Sun, 25 Mar 2018 17:16:10 +1000 Message-ID: Subject: Re: picocli-based CliBuilder backwards compatibility To: dev@groovy.apache.org Content-Type: multipart/alternative; boundary="00000000000090a46b0568376e45" --00000000000090a46b0568376e45 Content-Type: text/plain; charset="UTF-8" I think they are much less widely used than other features so feel free to change them. If similar functionality is available via picocli, please use the same property name if it makes sense to expose that functionality for greater control. We will likely create a separate module (groovy-cli-commons or similar) with the existing CliBuilder implementation (but with probably a package name change) that won't be referenced in the groovy-all pom. If folks are relying on those bits of the functionality, they can use the legacy version. The goal should be to have commons-cli being a dependency of only that module. Cheers, Paul. On Sun, Mar 25, 2018 at 1:58 PM, Remko Popma wrote: > CliBuilder exposed some commons-cli classes (see below). > > Is it okay to remove these, or should these be left as deprecated > properties in the CliBuilder class to retain binary compatibility with > pre-2.5 versions? > > Note that if these properties remain the new picocli-based implementation > will ignore them, so the behaviour will change. > > /** > * Normally set internally but allows you full customisation of the underlying processing engine. > */ > CommandLineParser parser = null > > /** > * Normally set internally but can be overridden if you want to customise how the usage message is displayed. > */ > HelpFormatter formatter = new HelpFormatter() > > /** > * Not normally accessed directly but full access to underlying options if needed. > */ > Options options = new Options() > > > --00000000000090a46b0568376e45 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I think they are much less widely used than other fea= tures so feel free to change them. If similar functionality is available vi= a picocli, please use the same property name if it makes sense to expose th= at functionality for greater control.

We will likely cr= eate a separate module (groovy-cli-commons or similar) with the existing Cl= iBuilder implementation (but with probably a package name change) that won&= #39;t be referenced in the groovy-all pom. If folks are relying on those bi= ts of the functionality, they can use the legacy version. The goal should b= e to have commons-cli being a dependency of only that module.

Cheers, Paul.

On Sun, Mar 25, 2018 at 1:58 PM, Remko Popma <remko.popm= a@gmail.com> wrote:
CliBuilder exposed some commons-cli classes (see below).

=
Is it okay to remove these, or should these be left as deprecated prop= erties in the CliBuilder class to retain binary compatibility with pre-2.5 = versions?=C2=A0

Note that if=20 these properties remain the new picocli-based implementation will ignore them, so the behavi= our will change.

/**
 * Normally set internally bu=
t allows you full customisation of the underlying processing engine.
 */
=
CommandLineParser pa=
rser =3D null
=

/**
 * Normally set internally but can be overridden if you wa=
nt to customise how the usage message is displayed.
 */
HelpFormatter <=
span style=3D"color:rgb(102,14,122);font-weight:bold">formatter =3D =
new HelpFormatter=
()
/**
 * Not normally accessed directly but full access to underl=
ying options if needed.
 */
Options options =3D new Options()


--00000000000090a46b0568376e45--