groovy-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jochen Theodorou <blackd...@gmx.org>
Subject Re: groovy git commit: Increase the possible size of value in GString instance
Date Thu, 25 Jan 2018 22:06:59 GMT
On 25.01.2018 07:32, sunlan@apache.org wrote:
> Repository: groovy
> Updated Branches:
>    refs/heads/master 031fc238f -> 7be5f2f82
> 
> 
> Increase the possible size of value in GString instance
[...]
> -        initialCapacity += values.length * Math.max(initialCapacity / strings.length,
1);
> +        initialCapacity += values.length * Math.max(initialCapacity / strings.length,
8);
>   
>           return Math.max((int) (initialCapacity  * 1.2), 16);
>       }


I would wish here for a comment or at least a commit message why this 
metric has been chosen. Otherwise the next change may very well undo 
this again and nobody is really more wise here.

bye Jochen


Mime
View raw message