groovy-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Paul King <pa...@asert.com.au>
Subject Re: About making ProxyGenerator singleton
Date Thu, 04 Jan 2018 22:49:36 GMT
While Groovy's internal use of ProxyGenerator mainly follows the singleton
pattern, it was designed to be generally used outside Groovy's internals -
so it would be removal of a public api.
We generally avoid that but if there is a great gain we could poll the
users and see if it is in widespread use and if not deprecate it (if no use
found) or make an internal copy.
Also, I am not sure
whether org.codehaus.groovy.vmplugin.v7.TypeTransformers usage is via the
INSTANCE.

Cheers, Paul.

On Fri, Jan 5, 2018 at 12:49 AM, Daniel.Sun <sunlan@apache.org> wrote:

> Hi all,
>
>          I found ProxyGenerator is instantiated only in tests(i.e. `new
> ProxyGenerator()`) and in the ProxyGenerator itself[1]. In order to share
> the adapter cache globally[2] and maximize the usage of the cache, how
> about
> make ProxyGenerator singleton?  In addition, how about increase the default
> size of the cache?(e.g. 64)
>
>          Any thoughts?
>
> Cheers,
> Daniel.Sun
>
> [1]
> https://github.com/apache/groovy/blob/master/src/main/groovy/groovy/util/
> ProxyGenerator.java#L69
> [2]
> https://github.com/apache/groovy/blob/master/src/main/groovy/groovy/util/
> ProxyGenerator.java#L77
>
>
>
>
> --
> Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html
>

Mime
View raw message