Mailing-List: contact dev-help@groovy.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@groovy.apache.org
MIME-Version: 1.0
In-Reply-To: <9a9eb52a-8037-93eb-8d44-4c66d05e627d@bruenings-it.net>
References: <CADQzvmkZ5GacKYyzVTGksh0+3+mTn=CbTzkEnfU8Qb=rJGGFgA@mail.gmail.com>
 <9C9EDCDC-A295-4137-B6B0-4C78896A4C7C@univ-mlv.fr> <9a9eb52a-8037-93eb-8d44-4c66d05e627d@bruenings-it.net>
From: =?UTF-8?Q?C=C3=A9dric_Champeau?= <cedric.champeau@gmail.com>
Date: Sun, 3 Dec 2017 19:03:09 +0100
Message-ID: <CADQzvmnF1N3yBisTpFp+1++ri_2v21Q7+Jt=D-vOZ=HsRypJ9A@mail.gmail.com>
Subject: Re: [VOTE] Automatic module names
To: dev@groovy.apache.org
Content-Type: multipart/alternative; boundary="f403045e35fc1e5bd4055f736a6f"
archived-at: Sun, 03 Dec 2017 18:03:16 -0000

--f403045e35fc1e5bd4055f736a6f
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Right, the exact name of the module can be discussed. I have nothing
against org.apache.groovy.json.


2017-12-03 18:38 GMT+01:00 Leonard Br=C3=BCnings <groovy-dev@bruenings-it.n=
et>:

> +1 with the amendment from R=C3=A9mi
>
> Am 03.12.2017 um 11:39 schrieb Remi Forax:
>
> Cedric,
> you can not have a dash in the name if you want the module name be
> referenced in a module-info.java.
>
> so it should be org.apache.groovy.json
>
> cheers,
> R=C3=A9mi
>
>
> On December 3, 2017 10:31:27 AM GMT+01:00, "C=C3=A9dric Champeau"
> <cedric.champeau@gmail.com> <cedric.champeau@gmail.com> wrote:
>>
>> Hi fellow Groovy devs,
>>
>> We had 2 different conversations in the past weeks regarding automatic
>> module names for Groovy. We also starting receiving notifications that s=
ome
>> 3rd party projects are blocked by Groovy when upgrading to modules (whic=
h
>> is no surprise). Logback for one.
>>
>> We need to move forward, and take small steps forward. So, here's the
>> plan:
>>
>> 1a. Replace the groovy-all jar with a groovy-all POM with just
>> dependencies, so that those depending on groovy-all.jar would now get
>> groovy.jar, groovy-json.jar and friends, instead of the all jar.
>> 1b. Add automatic module names for all jars we have. Since we know
>> breaking changes are coming, I'd suggest using "org.codehaus.groovy",
>> "org.codehaus.groovy-json", ...
>> 2. Fix split packages
>> 3. When this is fixed, change module names to "org.apache.groovy",
>> "org.apache.groovy-json", ...
>>
>> I would do 1a and 1b as soon as possible (2.5).
>> I would do 2 and 3 for 3.0, since those are binary breaking changes. Thi=
s
>> is also why I would leverage that to move to org.apache module names.
>>
>> I am against providing another -all jar, which would be confusing. Also
>> we have to get rid, as a larger community (java), of the bad habit of us=
ing
>> fat jars as dependencies. Those should only be used in final application=
s,
>> not libraries, so should be transparent to consumers.
>>
>> Please vote, so that we can move forward.
>>
>> [ ] +1 The plan sounds good
>> [ ] 0 I don't understand enough of the context to have an opinion
>> [ ] -1 because...
>>
>> Thanks a lot,
>>
>>
> --
> Sent from my Android device with K-9 Mail. Please excuse my brevity.
>
>
>

--f403045e35fc1e5bd4055f736a6f
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Right, the exact name of the module can be discussed. I ha=
ve nothing against org.apache.groovy.json.<div><br></div></div><div class=
=3D"gmail_extra"><br><div class=3D"gmail_quote">2017-12-03 18:38 GMT+01:00 =
Leonard Br=C3=BCnings <span dir=3D"ltr">&lt;<a href=3D"mailto:groovy-dev@br=
uenings-it.net" target=3D"_blank">groovy-dev@bruenings-it.net</a>&gt;</span=
>:<br><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-l=
eft:1px #ccc solid;padding-left:1ex">
 =20
   =20
 =20
  <div text=3D"#000000" bgcolor=3D"#FFFFFF">
    <p>+1 with the amendment from R=C3=A9mi </p><div><div class=3D"h5">
    <br>
    <div class=3D"m_756008803575663017moz-cite-prefix">Am 03.12.2017 um 11:=
39 schrieb Remi
      Forax:<br>
    </div>
    <blockquote type=3D"cite">Cedric,<br>
      you can not have a dash in the name if you want the module name be
      referenced in a <a href=3D"http://module-info.java" target=3D"_blank"=
>module-info.java</a>.<br>
      <br>
      so it should be org.apache.groovy.json<br>
      <br>
      cheers,<br>
      R=C3=A9mi <br>
      <br>
      <br>
      <div class=3D"gmail_quote">On December 3, 2017 10:31:27 AM
        GMT+01:00, &quot;C=C3=A9dric Champeau&quot; <a class=3D"m_756008803=
575663017moz-txt-link-rfc2396E" href=3D"mailto:cedric.champeau@gmail.com" t=
arget=3D"_blank">&lt;cedric.champeau@gmail.com&gt;</a>
        wrote:
        <blockquote class=3D"gmail_quote" style=3D"margin:0pt 0pt 0pt 0.8ex=
;border-left:1px solid rgb(204,204,204);padding-left:1ex">
          <div dir=3D"ltr">Hi fellow Groovy devs,
            <div><br>
            </div>
            <div>We had 2 different conversations in the past weeks
              regarding automatic module names for Groovy. We also
              starting receiving notifications that some 3rd party
              projects are blocked by Groovy when upgrading to modules
              (which is no surprise). Logback for one.</div>
            <div><br>
            </div>
            <div>We need to move forward, and take small steps forward.
              So, here&#39;s the plan:</div>
            <div><br>
            </div>
            <div>1a. Replace the groovy-all jar with a groovy-all POM
              with just dependencies, so that those depending on
              groovy-all.jar would now get groovy.jar, groovy-json.jar
              and friends, instead of the all jar.</div>
            <div>1b. Add automatic module names for all jars we have.
              Since we know breaking changes are coming, I&#39;d suggest
              using &quot;org.codehaus.groovy&quot;, &quot;org.codehaus.gro=
ovy-json&quot;,
              ...</div>
            <div>2. Fix split packages</div>
            <div>3. When this is fixed, change module names to
              &quot;org.apache.groovy&quot;, &quot;org.apache.groovy-json&q=
uot;, ...</div>
            <div><br>
            </div>
            <div>I would do 1a and 1b as soon as possible (2.5).</div>
            <div>I would do 2 and 3 for 3.0, since those are binary
              breaking changes. This is also why I would leverage that
              to move to org.apache module names.</div>
            <div><br>
            </div>
            <div>I am against providing another -all jar, which would be
              confusing. Also we have to get rid, as a larger community
              (java), of the bad habit of using fat jars as
              dependencies. Those should only be used in final
              applications, not libraries, so should be transparent to
              consumers.</div>
            <div><br>
            </div>
            <div>Please vote, so that we can move forward.</div>
            <div><br>
            </div>
            <div>[ ] +1 The plan sounds good</div>
            <div>[ ] 0 I don&#39;t understand enough of the context to have
              an opinion</div>
            <div>[ ] -1 because...</div>
            <div><br>
            </div>
            <div>Thanks a lot,</div>
            <div><br>
            </div>
          </div>
        </blockquote>
      </div>
      <br>
      -- <br>
      Sent from my Android device with K-9 Mail. Please excuse my
      brevity.
    </blockquote>
    <br>
  </div></div></div>

</blockquote></div><br></div>

--f403045e35fc1e5bd4055f736a6f--