Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 21975200D4A for ; Tue, 14 Nov 2017 05:29:53 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 20102160BF3; Tue, 14 Nov 2017 04:29:53 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 186C0160C06 for ; Tue, 14 Nov 2017 05:29:51 +0100 (CET) Received: (qmail 54338 invoked by uid 500); 14 Nov 2017 04:29:51 -0000 Mailing-List: contact dev-help@groovy.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@groovy.apache.org Delivered-To: mailing list dev@groovy.apache.org Received: (qmail 54258 invoked by uid 99); 14 Nov 2017 04:29:50 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Nov 2017 04:29:50 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 015191A0F6A for ; Tue, 14 Nov 2017 04:29:50 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.794 X-Spam-Level: *** X-Spam-Status: No, score=3.794 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=2, KAM_NUMSUBJECT=0.5, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, URIBL_BLOCKED=0.001, URI_HEX=1.313] autolearn=disabled Authentication-Results: spamd2-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=asert-com-au.20150623.gappssmtp.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id wOLDH4q-0tYu for ; Tue, 14 Nov 2017 04:29:46 +0000 (UTC) Received: from mail-ot0-f174.google.com (mail-ot0-f174.google.com [74.125.82.174]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 2F8D65F39D for ; Tue, 14 Nov 2017 04:29:44 +0000 (UTC) Received: by mail-ot0-f174.google.com with SMTP id b49so12247487otj.5 for ; Mon, 13 Nov 2017 20:29:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=asert-com-au.20150623.gappssmtp.com; s=20150623; h=mime-version:reply-to:in-reply-to:references:from:date:message-id :subject:to; bh=mzVB6x0jS7F70R2lErAthcQjfqGqcF0jw3k1szt/nJA=; b=YmIGJAu6gFB2g29h4E1M0oDcljBYGe3xZ0iQUIrk459vakKVyabfH2y/mdrwRFmE9c y0d7MbRsnGLA7yJQBCHwwNEcFO5Ev7gnfV+PHnvXPaL2duykU3DJ6ORH3QBf9BPTOkru FhwTLVfq2GpAk2eYzQ1HziKsu+Q9RtSZAJWjs7vZcqcYKE0o71xqpMy/pfbsHHnvO1ki xXwSiaJ4z5p/RvA8L69Mkwh2msEA1/unxkeSJwLCGZPdgtQg1OYbvPYhDeNI1hAuqQjt 6c4cr9w4xLjpChk6gyfSunENt4O1kHtexcttvbtbtqB5SxWJYOOif/9QLHW4IYbb8Hp0 lmMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to; bh=mzVB6x0jS7F70R2lErAthcQjfqGqcF0jw3k1szt/nJA=; b=nxSonOm+FOPeRK6mSMTAD7sq/iCyP8MvYwYpjCFnQSiahZx6r3wlsjiSRlP+h6zML7 q6UALH4LtlARKTWkCIppqEiw1SELDCgQGYYbQrlPsoPeFxCb2GvmvUng9lU8M9BjPBJu TZUfghb8Jw5gpklsQX8EGlQvAmeJmSjtMX/fNALoynnaFcPiVIzSA7GEyhDgm81jOENh SmXlQIwa+VVL6VfUimk6O5kgfFYRyQMVlv6/IvKnRzEd+aIP8h1iwFivvgl3wp6lJ5wE T6tfAXYfeyBu/p1e4H97dOIm04nh9n99IhKBuhBLwZahwTCqW8alrtn6PNBAUYRxVMpT ZX4A== X-Gm-Message-State: AJaThX6PyOoT1q/lbiPp/bgXvawwrkWM5elaTMXWoCN5LQ14a01xwv3R TYr4Se1PxycLtMNxLEiQhozYSR1NdERXT2ugM4VCAQ== X-Google-Smtp-Source: AGs4zMZOjA6SjNKJTZSSqrI4zxCX84mplrxqW3GyfsTrPPuHlu/JBj5qMAbd/Ztf3JsZA/I/FUEfZRTFTovw/RaaC+M= X-Received: by 10.157.55.181 with SMTP id x50mr6753416otb.252.1510633777546; Mon, 13 Nov 2017 20:29:37 -0800 (PST) MIME-Version: 1.0 Received: by 10.74.14.68 with HTTP; Mon, 13 Nov 2017 20:29:36 -0800 (PST) Reply-To: paulk@asert.com.au In-Reply-To: References: <1510413846351-0.post@n5.nabble.com> <1510574451259-0.post@n5.nabble.com> <1510581184356-0.post@n5.nabble.com> From: Paul King Date: Tue, 14 Nov 2017 14:29:36 +1000 Message-ID: Subject: Re: [VOTE] Release Apache Groovy 2.6.0-alpha-2 To: dev@groovy.apache.org Content-Type: multipart/alternative; boundary="001a114094c8b25f6e055de9d502" archived-at: Tue, 14 Nov 2017 04:29:53 -0000 --001a114094c8b25f6e055de9d502 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I tweaked the build files and README so that the bootstrapping instructions now read: gradle -b wrapper.gradle wrapper Since that file has no plugins, it should hopefully make us much more Gradle version resilient. It doesn't mean we might not want to consider Cos' proposal since (at the expense of having to keep updating the custom wrapper) it would eliminate the need to have gradle installed for bootstrapping. Also, it doesn't stop us from continuing to ask for permission to include the wrapper so that builders from source aren't second class citizens - needing the extra download. Perhaps that should be a section in our next board report? Anyway, we should get those changes for the next prepared releases. Cheers, Paul. On Tue, Nov 14, 2017 at 4:18 AM, Konstantin Boudnik wrote: > Current release includes a binary file (gradle/wrapper/*jar), which > isn't compatible with Apache release policy (ie source-only releases). > In all honestly, this isn't the first release with the same issue. I > was talking about it for too long and I am sorry I didn't address this > issue earlier. > > Here's https://issues.apache.org/jira/browse/GROOVY-8378 that has the > patch for the issue. I don't think we should block this release, but > let's make backport it into the next one, if there's no objections. > > Incidentally, I can't assign the ticket to myself for whatever reason. > But the patch is there ;) Thanks! > -- > With regards, > Konstantin (Cos) Boudnik > 2CAC 8312 4870 D885 8616 6115 220F 6980 1F27 E622 > > Disclaimer: Opinions expressed in this email are those of the author, > and do not necessarily represent the views of any company the author > might be affiliated with at the moment of writing. > > > On Mon, Nov 13, 2017 at 5:40 PM, C=C3=A9dric Champeau > wrote: > > This will not always be possible. The source zip will live for years. Y= ou > > can only do this at release time, and there's nothing that guarantees > that > > all plugins will all be compatible with the latest version of Gradle at > the > > moment you release for a branch that uses an old version. It's just a > > miracle it works. Instead, let's make our point to the foundation: the > > wrapper MUST be endorsed. > > > > 2017-11-13 15:38 GMT+01:00 Guillaume Laforge : > >> > >> I'm voting +1 > >> > >> But let's get sure we can build from source the next time when someone > has > >> a recent version of Gradle installed locally. > >> At the very minimum, we should indicate in the README that we have to > use > >> some range of Gradle version for generating the wrapper in the first > place. > >> > >> On Mon, Nov 13, 2017 at 2:53 PM, Daniel.Sun wrote: > >>> > >>> Hi Guillaume, > >>> > >>> I've understood what you mean :-) > >>> > >>> As to the version of plugin, we can not satisfy everyone becaus= e > >>> gradle 3+ and gradle 4+ requires different versions of plugin. So I > >>> sugguest > >>> we should clarify the requirement of gradle version, which must be > 3.5.1 > >>> to > >>> generate the wrapper and build Apache Groovy from source. > >>> > >>> At last, I want to know, your vote is ? ;-) > >>> > >>> > >>> Cheers, > >>> Daniel.Sun > >>> > >>> > >>> > >>> -- > >>> Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html > >> > >> > >> > >> > >> -- > >> Guillaume Laforge > >> Apache Groovy committer & PMC Vice-President > >> Developer Advocate @ Google Cloud Platform > >> > >> Blog: http://glaforge.appspot.com/ > >> Social: @glaforge / Google+ > > > > > --001a114094c8b25f6e055de9d502 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I tweaked the build files and README so that the bootstrap= ping instructions now read:

gradle -b wrapper.gradle wrapper
Since that file has no plugins, it should hopefully make us muc= h more Gradle version resilient.

It doesn't me= an we might not want to consider Cos' proposal since (at the expense of= having to keep updating the custom wrapper) it would eliminate the need to= have gradle installed for bootstrapping.

Also, it= doesn't stop us from continuing to ask for permission to include the w= rapper so that builders from source aren't second class citizens - need= ing the extra download. Perhaps that should be a section in our next board = report?

Anyway, we should get those changes for th= e next prepared releases.

Cheers, Paul.
=

O= n Tue, Nov 14, 2017 at 4:18 AM, Konstantin Boudnik <cos@apache.org> wrote:
Current release includes a bi= nary file (gradle/wrapper/*jar), which
isn't compatible with Apache release policy (ie source-only releases).<= br> In all honestly, this isn't the first release with the same issue. I was talking about it for too long and I am sorry I didn't address this<= br> issue earlier.

Here's https://issues.apache.org/jira/brow= se/GROOVY-8378 that has the
patch for the issue. I don't think we should block this release, but let's make backport it into the next one, if there's no objections.=

Incidentally, I can't assign the ticket to myself for whatever reason.<= br> But the patch is there ;) Thanks!
--
=C2=A0 With regards,
Konstantin (Cos) Boudnik
2CAC 8312 4870 D885 8616=C2=A0 6115 220F 6980 1F27 E622

Disclaimer: Opinions expressed in this email are those of the author,
and do not necessarily represent the views of any company the author
might be affiliated with at the moment of writing.


On Mon, Nov 13, 2017 at 5:40 PM, C=C3=A9dric Champeau
<cedric.champeau@gmail.com<= /a>> wrote:
> This will not always be possible. The source zip will live for years. = You
> can only do this at release time, and there's nothing that guarant= ees that
> all plugins will all be compatible with the latest version of Gradle a= t the
> moment you release for a branch that uses an old version. It's jus= t a
> miracle it works. Instead, let's make our point to the foundation:= the
> wrapper MUST be endorsed.
>
> 2017-11-13 15:38 GMT+01:00 Guillaume Laforge <glaforge@gmail.com>:
>>
>> I'm voting +1
>>
>> But let's get sure we can build from source the next time when= someone has
>> a recent version of Gradle installed locally.
>> At the very minimum, we should indicate in the README that we have= to use
>> some range of Gradle version for generating the wrapper in the fir= st place.
>>
>> On Mon, Nov 13, 2017 at 2:53 PM, Daniel.Sun <sunlan@apache.org> wrote:
>>>
>>> Hi Guillaume,
>>>
>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0I've understood what you mean :-= )
>>>
>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0As to the version of plugin, we can = not satisfy everyone because
>>> gradle 3+ and gradle 4+ requires different versions of plugin.= So I
>>> sugguest
>>> we should clarify the requirement of gradle version, which mus= t be 3.5.1
>>> to
>>> generate the wrapper and build Apache Groovy from source.
>>>
>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 At last, I want to know, your vote = is ?=C2=A0 =C2=A0;-)
>>>
>>>
>>> Cheers,
>>> Daniel.Sun
>>>
>>>
>>>
>>> --
>>> Sent from: http://groovy.3294= 49.n5.nabble.com/Groovy-Dev-f372993.html
>>
>>
>>
>>
>> --
>> Guillaume Laforge
>> Apache Groovy committer & PMC Vice-President
>> Developer Advocate @ Google Cloud Platform
>>
>> Blog: http://glaforge.appspot.com/
>> Social: @glaforge / Google+
>
>

--001a114094c8b25f6e055de9d502--