Mailing-List: contact dev-help@groovy.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@groovy.apache.org
MIME-Version: 1.0
Reply-To: cchampeau@apache.org
From: =?UTF-8?Q?C=C3=A9dric_Champeau?= <cchampeau@apache.org>
Date: Wed, 5 Jul 2017 18:28:57 +0200
Message-ID: <CADQzvm=8Qmv+SGRz+DHVAVAov=4ng29UzeVZxHMu9TOvnqfsKQ@mail.gmail.com>
Subject: trySetAccessible for Java 9
To: dev@groovy.apache.org
Content-Type: multipart/alternative; boundary="94eb2c1cbe2c31ecaa0553947f64"
archived-at: Wed, 05 Jul 2017 16:29:01 -0000

--94eb2c1cbe2c31ecaa0553947f64
Content-Type: text/plain; charset="UTF-8"

Hi folks,

We've made some good progress on making Gradle compatible with Java 9 as a
runtime. However, since the latest release, builds easily get bloated with
warnings like this:

WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by
org.codehaus.groovy.reflection.CachedClass
(file:/home/cchampeau/.gradle/caches/modules-2/files-2.1/org.codehaus.groovy/groovy-all/2.4.11/444a64af79c540aad257e49d95050e7c189f1309/groovy-all-2.4.11.jar)
to method java.lang.Object.finalize()

Which is, I think, related to calls to AccessibleObject#setAccessible
in org.codehaus.groovy.reflection.CachedClass#makeAccessible.

However, this class precisely _tries_ to set accessible members of a class,
but doesn't necessarily _have to_. That is, precisely the semantics of the
new `trySetAccessible` method in AccessibleObject on JDK 9, so I would
suggest we use it.

However, as you may understand, things are never so easy: for binary and
runtime compatibility, we need to be able to use this method only if JDK 9
is available, so it either requires using reflection, or method handles if
we are using Java 8.

It would be nice to have this in the next 2.x release of Groovy, so that we
can get rid of those nasty error messages, but then it also means no
MethodHandle, so no fast call of that `trySetAccessible` method. We cannot
use the `Java7` or `Java8` approach either, without actually _building_ on
JDK 9, which would be a problem itself.

Any suggestion?

--94eb2c1cbe2c31ecaa0553947f64
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi folks,<div><br></div><div>We&#39;ve made some good prog=
ress on making Gradle compatible with Java 9 as a runtime. However, since t=
he latest release, builds easily get bloated with warnings like this:</div>=
<div><br></div><div><div>WARNING: An illegal reflective access operation ha=
s occurred</div><div>WARNING: Illegal reflective access by org.codehaus.gro=
ovy.reflection.CachedClass (file:/home/cchampeau/.gradle/caches/modules-2/f=
iles-2.1/org.codehaus.groovy/groovy-all/2.4.11/444a64af79c540aad257e49d9505=
0e7c189f1309/groovy-all-2.4.11.jar) to method java.lang.Object.finalize()</=
div></div><div><br></div><div>Which is, I think, related to calls to Access=
ibleObject#setAccessible in=C2=A0org.codehaus.groovy.reflection.CachedClass=
#makeAccessible.</div><div><br></div><div>However, this class precisely _tr=
ies_ to set accessible members of a class, but doesn&#39;t necessarily _hav=
e to_. That is, precisely the semantics of the new `trySetAccessible` metho=
d in AccessibleObject on JDK 9, so I would suggest we use it.</div><div><br=
></div><div>However, as you may understand, things are never so easy: for b=
inary and runtime compatibility, we need to be able to use this method only=
 if JDK 9 is available, so it either requires using reflection, or method h=
andles if we are using Java 8.</div><div><br></div><div>It would be nice to=
 have this in the next 2.x release of Groovy, so that we can get rid of tho=
se nasty error messages, but then it also means no MethodHandle, so no fast=
 call of that `trySetAccessible` method. We cannot use the `Java7` or `Java=
8` approach either, without actually _building_ on JDK 9, which would be a =
problem itself.</div><div><br></div><div>Any suggestion?</div></div>

--94eb2c1cbe2c31ecaa0553947f64--