Mailing-List: contact dev-help@groovy.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@groovy.apache.org
MIME-Version: 1.0
Reply-To: paulk@asert.com.au
In-Reply-To: <CAL6R17CGwqLhOYbgwtz+ngkLthJKav63GUqYwE2UKVZ28C+2bA@mail.gmail.com>
References: <CAL6R17CGwqLhOYbgwtz+ngkLthJKav63GUqYwE2UKVZ28C+2bA@mail.gmail.com>
From: Paul King <paulk@asert.com.au>
Date: Thu, 25 May 2017 09:52:39 +1000
Message-ID: <CAMbkE7RB1j2yhwDY0WpXGGtdjp69KFVVmFM3UoSzFUQ-xzs3vg@mail.gmail.com>
Subject: Re: Help with task: Groovydoc improved comment extraction
To: dev@groovy.apache.org
Content-Type: multipart/alternative; boundary="001a113d54c4b2157905504dccd2"
archived-at: Wed, 24 May 2017 23:52:47 -0000

--001a113d54c4b2157905504dccd2
Content-Type: text/plain; charset="UTF-8"

Ah, yes I had forgotten about that when I wrote the ticket. I'll rework the
ticket in a little while.

Cheers, Paul.

On Wed, May 24, 2017 at 8:02 AM, Emilian Bold <emilian.bold@gmail.com>
wrote:

> I would like to help out with the task listed at
> https://helpwanted.apache.org/task.html?6afc5096
>
> I've only briefly explored the code, but it seems to me
> SimpleGroovyClassDocAssembler#getJavaDocCommentsBeforeNode() is called
> with the ANTLR 2.7.7 parsers JavaRecognizer and GroovyRecognizer which
> produce org.codehaus.groovy.antlr.GroovySourceAST trees.
>
> Parrot will produce org.codehaus.groovy.ast.ASTNode trees.
>
> So the issue isn't just about changing getJavaDocCommentsBeforeNode and
> using the comment node (assuming we have EXTRACTING_DOC_COMMENT_ENABLED).
>
> SimpleGroovyClassDocAssembler must more or less be rewritten for the
> Parrot parser.
>
> --emi
>
>

--001a113d54c4b2157905504dccd2
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Ah, yes I had forgotten about that when I wrote the ticket=
. I&#39;ll rework the ticket in a little while.<div><br></div><div>Cheers, =
Paul.</div></div><div class=3D"gmail_extra"><br><div class=3D"gmail_quote">=
On Wed, May 24, 2017 at 8:02 AM, Emilian Bold <span dir=3D"ltr">&lt;<a href=
=3D"mailto:emilian.bold@gmail.com" target=3D"_blank">emilian.bold@gmail.com=
</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quote" style=3D"margin=
:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir=3D"ltr">I=
 would like to help out with the task listed at <a href=3D"https://helpwant=
ed.apache.org/task.html?6afc5096" target=3D"_blank">https://helpwanted.apac=
he.org/<wbr>task.html?6afc5096</a><br><br><div>I&#39;ve only briefly explor=
ed the code, but it seems to me=C2=A0<wbr>SimpleGroovyClassDocAssembler#<wb=
r>getJavaDocCommentsBeforeNode() is called with the ANTLR 2.7.7 parsers=C2=
=A0JavaRecognizer and=C2=A0GroovyRecognizer which produce=C2=A0org.codehaus=
.groovy.<wbr>antlr.GroovySourceAST trees.</div><div><br></div><div>Parrot w=
ill produce=C2=A0org.codehaus.groovy.<wbr>ast.ASTNode trees.</div><div><br>=
</div><div>So the issue isn&#39;t just about changing getJavaDocCommentsBef=
oreNode and using the comment node (assuming we have EXTRACTING_DOC_COMMENT=
_<wbr>ENABLED).</div><div><br></div><div>SimpleGroovyClassDocAssembler must=
 more or less be rewritten for the Parrot parser.<br></div><div><br></div><=
div>--emi</div><div><br></div></div>
</blockquote></div><br></div>

--001a113d54c4b2157905504dccd2--