Mailing-List: contact dev-help@groovy.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@groovy.apache.org
MIME-Version: 1.0
From: James Laverack <james@jameslaverack.com>
Date: Sun, 14 May 2017 20:02:12 +0000
Message-ID: <CAJ2o6c5MKZU1bjrsS0BzTh7NVxHOAWjHosbc6U32Mb-tL=9VXw@mail.gmail.com>
Subject: GROOVY-7979 and Index Overlay JSON parser behaviour
To: dev@groovy.apache.org
Content-Type: multipart/alternative; boundary="001a113d318eb834aa054f816ada"
archived-at: Sun, 14 May 2017 20:02:36 -0000

--001a113d318eb834aa054f816ada
Content-Type: text/plain; charset="UTF-8"

Hi all,

I'm interested in contributing to Groovy development, so I've taken a look
at the bug tracker and taken up GROOVY-7979. Most of this is pretty
straightforward, but I'm having a bit of difficulty with figuring out how
the index overlay parsers (`INDEX_OVERLAY` and `LAX`) should behave.

The ticket seems to imply that like the other parser implementations they
should throw a JsonException when attempting to parse the string "[-]". But
because the index overlay parser doesn't parse the value in the array until
it's called for, simply doing `parser.parseText('[-]')` won't throw an
exception whereas `parser.parseText('[-]')[0]` would. (With the fixes I've
implemented to the number parsing code that fix the other parsers anyway.)

Is it acceptable to have the lax parser behave like this and not throw the
exception until the value is accessed, or should the implementation of
`NumberValue` check for this case when it's created?

Thanks,
James Laverack

--001a113d318eb834aa054f816ada
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div><div><div><div>Hi all,<br><br></div>I&#39;m intereste=
d in contributing to Groovy development, so I&#39;ve taken a look at the bu=
g tracker and taken up GROOVY-7979. Most of this is pretty straightforward,=
 but I&#39;m having a bit of difficulty with figuring out how the index ove=
rlay parsers (`INDEX_OVERLAY` and `LAX`) should behave.<br><br>The ticket s=
eems to imply that like the other parser implementations they should throw =
a JsonException when attempting to parse the string &quot;[-]&quot;. But be=
cause the index overlay parser doesn&#39;t parse the value in the array unt=
il it&#39;s called for, simply doing `parser.parseText(&#39;[-]&#39;)` won&=
#39;t throw an exception whereas `parser.parseText(&#39;[-]&#39;)[0]` would=
. (With the fixes I&#39;ve implemented to the number parsing code that fix =
the other parsers anyway.)<br><br></div>Is it acceptable to have the lax pa=
rser behave like this and not throw the exception until the value is access=
ed, or should the implementation of `NumberValue` check for this case when =
it&#39;s created?<br><br></div>Thanks,<br></div>James Laverack<br></div>

--001a113d318eb834aa054f816ada--