Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D75A4200C73 for ; Wed, 26 Apr 2017 00:03:15 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id D5DF3160BB6; Tue, 25 Apr 2017 22:03:15 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D09DC160BB3 for ; Wed, 26 Apr 2017 00:03:14 +0200 (CEST) Received: (qmail 71338 invoked by uid 500); 25 Apr 2017 22:03:14 -0000 Mailing-List: contact dev-help@groovy.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@groovy.apache.org Delivered-To: mailing list dev@groovy.apache.org Received: (qmail 71328 invoked by uid 99); 25 Apr 2017 22:03:13 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Apr 2017 22:03:13 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 5F9E5C074C for ; Tue, 25 Apr 2017 22:03:13 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.795 X-Spam-Level: X-Spam-Status: No, score=-0.795 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-2.796, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=asert-com-au.20150623.gappssmtp.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id lyOfwsRYmOST for ; Tue, 25 Apr 2017 22:03:11 +0000 (UTC) Received: from mail-io0-f171.google.com (mail-io0-f171.google.com [209.85.223.171]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id BE7825FBE5 for ; Tue, 25 Apr 2017 22:03:10 +0000 (UTC) Received: by mail-io0-f171.google.com with SMTP id p80so106712012iop.3 for ; Tue, 25 Apr 2017 15:03:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=asert-com-au.20150623.gappssmtp.com; s=20150623; h=mime-version:reply-to:in-reply-to:references:from:date:message-id :subject:to:cc; bh=acJH2mOPzUhb7CKdzIuY/CZl7d7BiSM86RfQ5heNPGQ=; b=SayiH+SU+0CM3CKcdlpDWBH+9UJwN1CmeqhUkfGSZFGk3/8hZg0RFPOeZZL8HfIYxZ VyzS2dR976u6+q2/BfPMS1QhW7j8JyRBphJ8LTUm9uYrCiYcv9ZrXTwNjGkt83xzyTOG gXLr4vVD0NOsJvyOXgFZ7V6ZzfFeRsjLg1x9dlxTGkIHJJTDMqybCDQGki79Z7plqX9a tcwuokSiUNwT35w9At31UbYN2L6AUJixt3CedBTh7hvqCbv9kHxRHzbt/62htNfMDKoE jwK78RfV8KpzhBg0JWQTHf4T1O+alw6UZ3rv/WqUwSCG+q5CyHkdz91x5BqULr8zmnyq l4PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc; bh=acJH2mOPzUhb7CKdzIuY/CZl7d7BiSM86RfQ5heNPGQ=; b=HYLymjkcqvAI+H/oXAhrWW2ceV4nPqoa2HihQ6arDNa6vo3hccaV4Nw/7nvu4rJXGN oP1zg5Hb1UKTGYaaV4XDEqAFVoG1kPhfaJpvkZvDnpigiSDgqFRg8xxe1tyTCUhWy79y pJjN6jhQnUdI3hWepFV4ZKALSIKZVsKh+Qdyqhaxz7rC/OMeslaQGV+Mn2mdFq02aDeH STKtDU+s6bK/gL1tOily9CeV3h7+mtJvLc9MTz+/KLno+IsAha9Bd8X8G8DjJoZLrgM7 TTvzALowWLhNnWRazBDb5k5O01aaepDcSRJiJataSStorPFdB6tA89zBPTCIgN8F1/w/ S28g== X-Gm-Message-State: AN3rC/5uGorhcy7DGA6BtXYuQYvZWqS5bgc8N9/yNN+K6jc4PIDdXeCy psiENwXTt+OqiBpiSKpA7YC2eWVMINuv X-Received: by 10.107.6.224 with SMTP id f93mr17786654ioi.210.1493157789518; Tue, 25 Apr 2017 15:03:09 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.11.194 with HTTP; Tue, 25 Apr 2017 15:03:08 -0700 (PDT) Reply-To: paulk@asert.com.au In-Reply-To: References: From: Paul King Date: Wed, 26 Apr 2017 08:03:08 +1000 Message-ID: Subject: Re: Raising my hand To: Yazad Khambata Cc: dev@groovy.apache.org Content-Type: multipart/alternative; boundary=001a113fb632a367b7054e04e379 archived-at: Tue, 25 Apr 2017 22:03:16 -0000 --001a113fb632a367b7054e04e379 Content-Type: text/plain; charset=UTF-8 Hi Yazad, Thanks for your excellent analysis. You have confirmed what my suspicions were. The one advantage of adding the extra implicit objects would be to assist with people copying and pasting between JSP/Servlets and GSP/Groovlets. But the current support covers a lot of cases and we haven't had as fair as I know any user demand to cover the other cases. I suggest we close this issue and let user demand drive further work. Cheers, Paul. On Wed, Apr 26, 2017 at 2:18 AM, Yazad Khambata wrote: > Hi Paul, > > I have added comments on the JIRA > (https://issues.apache.org/jira/browse/GROOVY-1200) > > Brief summary - page, pageContext, and config are not supported by > groovlets but for the most parts they would be redundant and/or not > very useful since, > > 1. config pulls initialization config for a specific JSP (or Servlet) > from the web.xml - and we do not define declare individual groovlets > in the web.xml this feature may not make sense. > 2. page and pageContext - page is not useful as-is as it is literally > java.lang.Object reference referring to "this" JSP. pageContext is > more useful and used heavily when working with Tag Libraries. However > since we don't support tag libraries in groovlets this feature may not > be very useful. > 3. All other features supported by config, page and pageContext can > work worked around by using the other implicit objects supported by > groovlets. > > Conclusion: In the context of groovlets there is little reason to miss > these 3 objects, HOWEVER, all 3 are easy to incorporate and make > groovlet compatible with the Implicit Object requirement of the JSP > Specification v2.3. > > Please let me know if you need any more info and how you would like me > to proceed. Thank you. > > Regards, > Yazad Khambata > > > > > On Thu, Apr 20, 2017 at 12:24 AM, Paul King wrote: > > > > Just forwarding - didn't realise it wasn't to the list. > > > > ---------- Forwarded message ---------- > > From: Paul King > > Date: Thu, Apr 20, 2017 at 1:19 PM > > Subject: Re: Raising my hand > > To: Yazad Khambata > > > > > > Updating the ticket would be great. We can report a summary back here if > > needed once the path forward is a bit clearer. > > > > Cheers, Paul. > > > > On Thu, Apr 20, 2017 at 1:15 PM, Yazad Khambata > wrote: > >> > >> Thank you Paul, I can take up reviewing and provide you with the > >> difference if any between the current JSP spec and the current > >> implementation in GroovyServlet. Would you prefer me providing the diff > on > >> the mail list or would you rather have me document that on the ticket? > >> > >> Thanks again. > >> > >> Cheers, > >> Yazad > >> > >> On Wed, Apr 19, 2017 at 8:09 PM Paul King wrote: > >>> > >>> Hi Yazad, > >>> > >>> We are always keen to see progress being made on the code base. > >>> GROOVY-1200 looks a little old and I wonder whether some of the > >>> functionality is already in place. I left a comment on the issue > suggesting > >>> we review what was being asked for in that issue and what is currently > >>> supported. If there are still gaps in what is currently supported or > >>> non-conflicting improvements we can make to better support JSP to GSP > >>> translation, then we'd be keen for work on those to be made. The 2.4 > stream > >>> is in maintenance mode so I suspect that 2.5.0 would be the target > version. > >>> > >>> Cheers, Paul. > >>> > >>> On Thu, Apr 20, 2017 at 12:21 AM, Yazad Khambata > >>> wrote: > >>>> > >>>> Hi, > >>>> > >>>> I was thinking of picking up > >>>> https://issues.apache.org/jira/browse/GROOVY-1200 > >>>> > >>>> "include appropriate JSP 2.0/EL implicit variables in Groovlets" > >>>> > >>>> Besides the fix, I will also write the test case and update docs. > >>>> > >>>> Would this be something you would consider for 2.4.12 or a later > >>>> release? > >>>> > >>>> Please suggest. Thank you. > >>>> > >>>> Cheers, > >>>> Yazad > >>> > >>> > > > > > --001a113fb632a367b7054e04e379 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi=C2=A0Yazad,
=
Thank= s for your excellent analysis. You have confirmed what my suspicions were. = The one advantage of adding the extra implicit objects would be to assist w= ith people copying and pasting between JSP/Servlets and GSP/Groovlets. But = the current support covers a lot of cases and we haven't had as fair as= I know any user demand to cover the other cases. I suggest we close this i= ssue and let user demand drive further work.

=
Cheers, Paul.

On = Wed, Apr 26, 2017 at 2:18 AM, Yazad Khambata <yazad3@gmail.com> wrote:
Hi Paul,

I have added comments on the JIRA
(https://issues.apache.org/jira/browse/GROOVY-= 1200)

Brief summary - page, pageContext, and config are not supported by
groovlets but for the most parts they would be redundant and/or not
very useful since,

1. config pulls initialization config for a specific JSP (or Servlet)
from the web.xml - and we do not define declare individual groovlets
in the web.xml this feature may not make sense.
2. page and pageContext - page is not useful as-is as it is literally
java.lang.Object reference referring to "this" JSP. pageContext i= s
more useful and used heavily when working with Tag Libraries. However
since we don't support tag libraries in groovlets this feature may not<= br> be very useful.
3. All other features supported by config, page and pageContext can
work worked around by using the other implicit objects supported by
groovlets.

Conclusion: In the context of groovlets there is little reason to miss
these 3 objects, HOWEVER, all 3 are easy to incorporate and make
groovlet compatible with the Implicit Object requirement of the JSP
Specification v2.3.

Please let me know if you need any more info and how you would like me
to proceed. Thank you.

Regards,
Yazad Khambata




On Thu, Apr 20, 2017 at 12:24 AM, Paul King <paulk@asert.com.au> wrote:
>
> Just forwarding - didn't realise it wasn't to the list.
>
> ---------- Forwarded message ----------
> From: Paul King <paulk@asert.= com.au>
> Date: Thu, Apr 20, 2017 at 1:19 PM
> Subject: Re: Raising my hand
> To: Yazad Khambata <yazad3@gmai= l.com>
>
>
> Updating the ticket would be great. We can report a summary back here = if
> needed once the path forward is a bit clearer.
>
> Cheers, Paul.
>
> On Thu, Apr 20, 2017 at 1:15 PM, Yazad Khambata <yazad3@gmail.com> wrote:
>>
>> Thank you Paul, I can take up reviewing and provide you with the >> difference if any between the current JSP spec and the current
>> implementation in GroovyServlet. Would you prefer me providing the= diff on
>> the mail list or would you rather have me document that on the tic= ket?
>>
>> Thanks again.
>>
>> Cheers,
>> Yazad
>>
>> On Wed, Apr 19, 2017 at 8:09 PM Paul King <paulk@asert.com.au> wrote:
>>>
>>> Hi Yazad,
>>>
>>> We are always keen to see progress being made on the code base= .
>>> GROOVY-1200 looks a little old and I wonder whether some of th= e
>>> functionality is already in place. I left a comment on the iss= ue suggesting
>>> we review what was being asked for in that issue and what is c= urrently
>>> supported. If there are still gaps in what is currently suppor= ted or
>>> non-conflicting improvements we can make to better support JSP= to GSP
>>> translation, then we'd be keen for work on those to be mad= e. The 2.4 stream
>>> is in maintenance mode so I suspect that 2.5.0 would be the ta= rget version.
>>>
>>> Cheers, Paul.
>>>
>>> On Thu, Apr 20, 2017 at 12:21 AM, Yazad Khambata <yazad3@gmail.com>
>>> wrote:
>>>>
>>>> Hi,
>>>>
>>>> I was thinking of picking up
>>>> https://issues.apache.org/jir= a/browse/GROOVY-1200
>>>>
>>>> "include appropriate JSP 2.0/EL implicit variables in= Groovlets"
>>>>
>>>> Besides the fix, I will also write the test case and updat= e docs.
>>>>
>>>> Would this be something you would consider for 2.4.12 or a= later
>>>> release?
>>>>
>>>> Please suggest. Thank you.
>>>>
>>>> Cheers,
>>>> Yazad
>>>
>>>
>
>

--001a113fb632a367b7054e04e379--