Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D1F77200C62 for ; Wed, 26 Apr 2017 16:27:00 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id D0819160BA8; Wed, 26 Apr 2017 14:27:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id CA24B160B95 for ; Wed, 26 Apr 2017 16:26:59 +0200 (CEST) Received: (qmail 50963 invoked by uid 500); 26 Apr 2017 14:26:59 -0000 Mailing-List: contact dev-help@groovy.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@groovy.apache.org Delivered-To: mailing list dev@groovy.apache.org Received: (qmail 50953 invoked by uid 99); 26 Apr 2017 14:26:58 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Apr 2017 14:26:58 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 4D5971B05A4 for ; Wed, 26 Apr 2017 14:26:58 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.531 X-Spam-Level: ** X-Spam-Status: No, score=2.531 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=2, HTML_OBFUSCATE_05_10=0.001, KAM_LOTSOFHASH=0.25, KAM_NUMSUBJECT=0.5, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_SORBS_SPAM=0.5] autolearn=disabled Authentication-Results: spamd2-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=asert-com-au.20150623.gappssmtp.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id OH2wHU8XOSqL for ; Wed, 26 Apr 2017 14:26:55 +0000 (UTC) Received: from mail-it0-f54.google.com (mail-it0-f54.google.com [209.85.214.54]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 1A5EF617D5 for ; Wed, 26 Apr 2017 14:22:14 +0000 (UTC) Received: by mail-it0-f54.google.com with SMTP id g66so40033333ite.1 for ; Wed, 26 Apr 2017 07:22:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=asert-com-au.20150623.gappssmtp.com; s=20150623; h=mime-version:reply-to:from:date:message-id:subject:to; bh=bH4URH4qEl40Tf11RMgLfUUS/Ivs0HjVk6+JQ6vg55Y=; b=DwddOIckKQ3PkB2/spekjR8kN1lpUob2bWqxWQPBKhA7fF2y+Hugr/y5rsYGT1ZEpz tOPYZWz8vJSryJrhccsUWdFEVt1TDVDF65prHaryILpjY7ODyOi6+KY0cmDLgZ+iHPNU 7BixMgIP6FWVoISbd/8y5ZzD+u/DzbtDrtvwPMoHQHVUFfM4MmV+AcjY1jvPqNW9baM9 TrS7qf+KxHmjx/tysii7S9Om264fdcn5J9oJruZERBIUxeSRrvdykmUQprrixzt18heZ I4ek94zS5/Im512AjqnpZUDrCjhn3xcboX/HiWHtbcRDO1vjwO7W9PczyHNDIyMiyyP+ V6hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:from:date:message-id :subject:to; bh=bH4URH4qEl40Tf11RMgLfUUS/Ivs0HjVk6+JQ6vg55Y=; b=foUxUPYhQMADOLXxL3yFr/H1ki47BChA71xy+W2iZAVBMbim3Eyz5ql82qbibFIpq5 zpBKNyweb1f0U72569cxKtMlICKvIXBqmEBqvOQQqW1quo5KqckyNszBk1/wefswMGSD 21AKz33cNS74iQZ4a+pJWE3tIdsrao+xnF8ArgEYhJUIQhINQQdptv5LxDk2K9t/CW+g mUu8vcD/5MIJxlSW8hiA6K8LU/DEFCRda+CI2/X7ae3HvZFlfSPp0eHkA0Oy2rj+6gqe zTJoaIoHQGb2wtXzBjhJTmF/QJEtR2+YXDTWqD1Ure6/k8C+9iModIALyKWWbJug0pzJ 1dUA== X-Gm-Message-State: AN3rC/7BHMN08adMJo7Lm/WIIvIpqOMj3wJcxNYzfIkAiAlkSoapkegM l6Q3YqbmxvFphFa3xVwkVC2bmfB2Iw== X-Received: by 10.36.84.85 with SMTP id t82mr11436617ita.114.1493216533113; Wed, 26 Apr 2017 07:22:13 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.11.194 with HTTP; Wed, 26 Apr 2017 07:22:12 -0700 (PDT) Reply-To: paulk@asert.com.au From: Paul King Date: Thu, 27 Apr 2017 00:22:12 +1000 Message-ID: Subject: [CANCELLED][VOTE] Release Apache Groovy 2.4.11 To: dev@groovy.apache.org Content-Type: multipart/alternative; boundary=001a1134f5e407928f054e12916c archived-at: Wed, 26 Apr 2017 14:27:01 -0000 --001a1134f5e407928f054e12916c Content-Type: text/plain; charset=UTF-8 As per previous message, I'll cancel and re-try. Cheers, Paul. On Thu, Apr 27, 2017 at 12:20 AM, Paul King wrote: > I think John that it is because of the GROOVY-8127 bug that those tests > are failing. The datastoreVersion of 6.1.1 will be built with a version of > Groovy containing that bug. Building with 2.4.7 or earlier or 2.4.11 and > later should be okay. I haven't tested all of the versions in between but I > think some will fail. Using a local snapshot build (6.1.3-BUILD-SNAPSHOT) > built with 2.4.11 works for me, i.e. all tests in grails-core pass. > > But while investigating I did find something not quite right with the fix > for GROOVY-8127 fix. It's the value we pass through for a generally > (always?) unused parameter and I couldn't actually trigger an error with > the bad value in place (optimised away?) but in the interests of being > conservative I will re-cut the build. > > Cheers, Paul. > > On Wed, Apr 26, 2017 at 7:09 PM, Paul King wrote: > >> John, what steps are you using to test? >> >> On Wed, Apr 26, 2017 at 3:10 PM, John Wagenleitner < >> john.wagenleitner@gmail.com> wrote: >> >>> 0 (binding) >>> >>> I am finding that the fix [1] for GROOVY-8127 is causing a number of >>> test failures [2] on the Grails master branch mostly related to the >>> DirtyCheckable trait [3]. Same tests pass with 2.4.10. Lack of knowledge >>> in this area so thus the neutral vote instead of -1. >>> >>> [1] https://github.com/apache/groovy/commit/3ab66db22e59baf6 >>> 9aa2977c838881f2e93d16bc >>> >>> [2] just a sample, but all failures seem to be related to the >>> DirtyCheckable trait >>> >>> java.lang.ExceptionInInitializerError >>> .... >>> Caused by: groovy.lang.MissingMethodException: No signature of method: >>> static org.grails.datastore.mapping.dirty.checking.DirtyCheckable.$ >>> static$init$org_grails_datastore_mapping_dirty_checking_Dirt >>> yCheckable__DIRTY_CLASS_MARKER() is applicable for argument types: >>> (java.lang.Class) values: [class org.grails.plugins.web.rest.re >>> nder.hal.Product] >>> at >>> >>> [3] https://github.com/grails/grails-data-mapping/blob/4bbba >>> 4a20d180244bd1f06e226879e50c36a92c7/grails-datastore-core/sr >>> c/main/groovy/org/grails/datastore/mapping/dirty/checking/Di >>> rtyCheckable.groovy >>> >>> On Mon, Apr 24, 2017 at 3:09 PM, Paul King wrote: >>> >>>> Dear community, >>>> >>>> I am happy to start the VOTE thread for a Groovy 2.4.11 release! >>>> >>>> This release includes 11 bug fixes/improvements as outlined in the >>>> changelog: >>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje >>>> ctId=12318123&version=12340047 >>>> >>>> Tag: https://git1-us-west.apache.org/repos/asf?p=groovy.git;a=tag >>>> ;h=refs/tags/GROOVY_2_4_11 >>>> Tag commit id: 76fece1ebb942eccc0af291932bc2a33fd7946c7 >>>> >>>> The artifacts to be voted on are located as follows (r19245). >>>> Source release: https://dist.apache.org/repos/ >>>> dist/dev/groovy/2.4.11/sources >>>> Convenience binaries: https://dist.apache.org/repos/ >>>> dist/dev/groovy/2.4.11/distribution >>>> >>>> Release artifacts are signed with a key from the following file: >>>> https://dist.apache.org/repos/dist/dev/groovy/KEYS >>>> >>>> Please vote on releasing this package as Apache Groovy 2.4.11. >>>> >>>> The vote is open for the next 72 hours and passes if a majority of at >>>> least three +1 PMC votes are cast. >>>> >>>> [ ] +1 Release Apache Groovy 2.4.11 >>>> [ ] 0 I don't have a strong opinion about this, but I assume it's ok >>>> [ ] -1 Do not release Apache Groovy 2.4.11 because... >>>> >>>> Here is my vote: >>>> >>>> +1 (binding) >>>> >>>> >>> >> > --001a1134f5e407928f054e12916c Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

As per previous message, I&= #39;ll cancel and re-try.

Cheers, Paul.

On Thu, Apr 27, 2017 at 12:20 AM, Paul King <paulk@= asert.com.au> wrote:
I think John that it is because of the GROOVY-8127 bug that thos= e tests are failing. The datastoreVersion of 6.1.1 will be built with a ver= sion of Groovy containing that bug. Building with 2.4.7 or earlier or 2.4.1= 1 and later should be okay. I haven't tested all of the versions in bet= ween but I think some will fail. Using a local snapshot build (6.1.3-BUILD-= SNAPSHOT) built with 2.4.11 works for me, i.e. all tests in grails-core pas= s.

But while investigating I did find something not quite righ= t with the fix for GROOVY-8127 fix. It's the value we pass through for = a generally (always?) unused parameter and I couldn't actually trigger = an error with the bad value in place (optimised away?) but in the interests= of being conservative I will re-cut the build.

<= div>Cheers, Paul.

On Wed, Apr 26, 2017 at= 7:09 PM, Paul King <paulk@asert.com.au> wrote:
John, what steps are you using to t= est?

= On Wed, Apr 26, 2017 at 3:10 PM, John Wagenleitner <john.wagenle= itner@gmail.com> wrote:
0 (binding)

I am finding that the fix [1] = for GROOVY-8127 is causing a number of test failures [2] on the Grails mast= er branch mostly related to the DirtyCheckable trait [3].=C2=A0 Same tests = pass with 2.4.10.=C2=A0 Lack of knowledge in this area so thus the neutral = vote instead of -1.


[2] just a samp= le, but all failures seem to be related to the DirtyCheckable trait

java.lang.ExceptionInInitializerError
= ....
Caused by: groovy.lang.MissingMethodException: No = signature of method: static org.grails.datastore.mapping.dirty.checkin= g.DirtyCheckable.$static$init$org_grails_datastore_mapping_dirty_= checking_DirtyCheckable__DIRTY_CLASS_MARKER() is applicable for a= rgument types: (java.lang.Class) values: [class org.grails.plugins.web.rest.re= nder.hal.Product]
at=C2=A0

=

On Mon, Apr 24, 2017 at 3:09 PM, Paul King <paulk@asert.com.au>= ; wrote:
Dear community,

I am happy to star= t the VOTE thread for a Groovy 2.4.11 release!

Thi= s release includes 11 bug fixes/improvements as outlined in the changelog:<= /div>

Tag= commit id: 76fece1ebb942eccc0af291932bc2a33fd7946c7

The artifacts to be voted on are located as follows (r19245).
=

Release artifacts are signed with= a key from the following file:

Please vote on re= leasing this package as Apache Groovy 2.4.11.

The = vote is open for the next 72 hours and passes if a majority of at least thr= ee +1 PMC votes are cast.

[ ] +1 Release Apache Gr= oovy 2.4.11
[ ] =C2=A00 I don't have a strong opinion about t= his, but I assume it's ok
[ ] -1 Do not release Apache Groovy= 2.4.11 because...

Here is my vote:

=
+1 (binding)





--001a1134f5e407928f054e12916c--