groovy-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From John Wagenleitner <john.wagenleit...@gmail.com>
Subject Re: Trying to determine if a change in 2.4.8 was deliberate...
Date Sun, 02 Apr 2017 15:43:16 GMT
I created https://issues.apache.org/jira/browse/GROOVY-8140 for this and
will remove the method.

On Sat, Apr 1, 2017 at 2:14 PM, Jochen Theodorou <blackdrag@gmx.org> wrote:

> On 01.04.2017 20:04, John Wagenleitner wrote:
>
>> I remember looking at this and seeing that the commit that originally
>> introduced the check was 2f077109 [1].  Subsequent commits switched to
>> CachedClass and later back to Class for the argument type to that method
>> but things got out of sync between MethodIndexAction and the local
>> MOPIter class leaving the method unused which looked like a regression
>> (albeit way back in 1.8) and not intentional.
>>
>> I can revert the commit or maybe just remove the skipClass method
>> altogether from MOPIter.
>>
>> [1]
>> https://github.com/apache/groovy/commit/2f077109#diff-c1354c
>> 0d7df171ad8cafcb3d1bf63857R223
>>
>
> It is very possible that changes back then introduced something that was
> not intended. But we did built on top of it. I think removing the skipClass
> method would be best.
>
> bye Jochen
>

Mime
View raw message