Mailing-List: contact dev-help@groovy.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@groovy.apache.org
MIME-Version: 1.0
References: <CADRx3POZ+O_A2OsPwQPVdBFUxrjh9KdPJK8xkrXVFL1Egx_qXQ@mail.gmail.com>
 <CAAJdKXkfw8haEPCCyRFPcm5++eXgy1tUWjkcTmnQ0kT4+MJKGA@mail.gmail.com>
 <24919e0c-8ff7-c53d-c540-9a4168288ba7@gmx.org> <CAAJdKXmqLp1oMx1P1FTWmQp1Yq+nS0yd78Vt+XojVcpSnr588g@mail.gmail.com>
In-Reply-To: <CAAJdKXmqLp1oMx1P1FTWmQp1Yq+nS0yd78Vt+XojVcpSnr588g@mail.gmail.com>
From: Sergei Egorov <bsideup@gmail.com>
Date: Wed, 29 Mar 2017 15:24:49 +0000
Message-ID: <CAAJdKXm2gy=t04=GwROig1zyFoQKbiU=2gfCRAhnYNYm9tzFmQ@mail.gmail.com>
Subject: Re: [VOTE] Release Apache Groovy 2.5.0-alpha-1 (take 2)
To: dev@groovy.apache.org
Content-Type: multipart/alternative; boundary=94eb2c1928caf56ce9054be02dbe
archived-at: Wed, 29 Mar 2017 15:25:05 -0000

--94eb2c1928caf56ce9054be02dbe
Content-Type: text/plain; charset=UTF-8

Guillaume,

Yes, I fixed this test already, builds are running, locally is green as
well.

I had two long flights from 6am, please excuse me for today :)

On Wed, Mar 29, 2017 at 5:22 PM Sergei Egorov <bsideup@gmail.com> wrote:

> Jochen,
>
> This is a good question :)
>
> I'm going to present them tomorrow on my workshop at Greach, will collect
> some feedback and then will start writing the docs.
>
> The only explanation you can find now is here
> https://github.com/bsideup/groovy-macro-methods-proposal
>
> There are open questions tho. Would be really nice if at least some of you
> will provide your opinions on them :)
>
> FYI the refactorings didn't affect an API. Everything statement from
> "groovy-macro-methods-proposal" should be up to date, at least as far as I
> remember, so it's definitely a good start to learn about them.
>
> On Wed, Mar 29, 2017 at 5:16 PM Jochen Theodorou <blackdrag@gmx.org>
> wrote:
>
>
>
> On 29.03.2017 17:06, Sergei Egorov wrote:
> > -1
> > We have 1 failing test ( "MacroTest > testNotAMacroCall" )
> >
> > Was caused by my recent change when I renamed extension module, sorry.
> >
> > I pushed a test fix. Assumption was incorrect, see the commit for an
> > explanation.
>
> on a side note... where can I find the current up-to-date documentation
> for macros... I mean if there is one ;)
>
> bye Jochen
>
>

--94eb2c1928caf56ce9054be02dbe
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Guillaume,<br><br>Yes, I fixed this test already, builds a=
re running, locally is green as well.<div><br></div><div>I had two long fli=
ghts from 6am, please excuse me for today :)</div></div><br><div class=3D"g=
mail_quote"><div dir=3D"ltr">On Wed, Mar 29, 2017 at 5:22 PM Sergei Egorov =
&lt;<a href=3D"mailto:bsideup@gmail.com">bsideup@gmail.com</a>&gt; wrote:<b=
r></div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border=
-left:1px #ccc solid;padding-left:1ex"><div dir=3D"ltr" class=3D"gmail_msg"=
>Jochen,<br class=3D"gmail_msg"><div class=3D"gmail_msg"><br class=3D"gmail=
_msg"></div><div class=3D"gmail_msg">This is a good question :)</div><div c=
lass=3D"gmail_msg"><br class=3D"gmail_msg"></div><div class=3D"gmail_msg">I=
&#39;m going to present them tomorrow on my workshop at Greach, will collec=
t some feedback and then will start writing the docs.=C2=A0</div><div class=
=3D"gmail_msg"><br class=3D"gmail_msg"></div><div class=3D"gmail_msg">The o=
nly explanation you can find now is here=C2=A0<a href=3D"https://github.com=
/bsideup/groovy-macro-methods-proposal" class=3D"gmail_msg" target=3D"_blan=
k">https://github.com/bsideup/groovy-macro-methods-proposal</a></div><div c=
lass=3D"gmail_msg"><br class=3D"gmail_msg"></div><div class=3D"gmail_msg">T=
here are open questions tho. Would be really nice if at least some of you w=
ill provide your opinions on them :)</div><div class=3D"gmail_msg"><br clas=
s=3D"gmail_msg"></div><div class=3D"gmail_msg">FYI the refactorings didn=
9;t affect an API. Everything statement from &quot;groovy-macro-methods-pro=
posal&quot; should be up to date, at least as far as I remember, so it&#39;=
s definitely a good start to learn about them.</div></div><br class=3D"gmai=
l_msg"><div class=3D"gmail_quote gmail_msg"><div dir=3D"ltr" class=3D"gmail=
_msg">On Wed, Mar 29, 2017 at 5:16 PM Jochen Theodorou &lt;<a href=3D"mailt=
o:blackdrag@gmx.org" class=3D"gmail_msg" target=3D"_blank">blackdrag@gmx.or=
g</a>&gt; wrote:<br class=3D"gmail_msg"></div><blockquote class=3D"gmail_qu=
ote gmail_msg" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;paddin=
g-left:1ex"><br class=3D"gmail_msg">
<br class=3D"gmail_msg">
On 29.03.2017 17:06, Sergei Egorov wrote:<br class=3D"gmail_msg">
&gt; -1<br class=3D"gmail_msg">
&gt; We have 1 failing test ( &quot;MacroTest &gt; testNotAMacroCall&quot; =
)<br class=3D"gmail_msg">
&gt;<br class=3D"gmail_msg">
&gt; Was caused by my recent change when I renamed extension module, sorry.=
<br class=3D"gmail_msg">
&gt;<br class=3D"gmail_msg">
&gt; I pushed a test fix. Assumption was incorrect, see the commit for an<b=
r class=3D"gmail_msg">
&gt; explanation.<br class=3D"gmail_msg">
<br class=3D"gmail_msg">
on a side note... where can I find the current up-to-date documentation<br =
class=3D"gmail_msg">
for macros... I mean if there is one ;)<br class=3D"gmail_msg">
<br class=3D"gmail_msg">
bye Jochen<br class=3D"gmail_msg">
</blockquote></div></blockquote></div>

--94eb2c1928caf56ce9054be02dbe--