groovy-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guillaume Laforge <glafo...@gmail.com>
Subject Re: [CANCEL][VOTE] Release Apache Groovy 2.4.10
Date Tue, 14 Mar 2017 11:21:17 GMT
There's indeed a problem with cleanliness.
I get Antlr related problems in AntlrParserPlugin when not cleaning.

I'm gonna try with the wrapper, just in case, as suggested by Paul.

On Tue, Mar 14, 2017 at 11:12 AM, Cédric Champeau <cedric.champeau@gmail.com
> wrote:

> Actually got the same error as Guillaume using Gradle 2.3:
> https://gradle.com/s/5d6oqw3wsbtny
>
> There's something wrong with the build somehow. I guess this one happens
> when the build isn't clean. It definitely needs a rewrite to benefit from
> all the latest Gradle nifties.
>
>
> 2017-03-14 10:53 GMT+01:00 Cédric Champeau <cedric.champeau@gmail.com>:
>
>> I think the error comes from using the latest Gradle release with the
>> 2.4.x branch: they don't seem to be compatible. Master uses latest Gradle,
>> not 2.4.x.
>>
>> 2017-03-14 9:01 GMT+01:00 Guillaume Laforge <glaforge@gmail.com>:
>>
>>> I upgraded my local Groovy and Gradle to the latest SDKman-available
>>> versions (2.4.9 and 3.4.1 respectively).
>>> Re-launching the dist build with --stacktrace, I have something
>>> different now...
>>>
>>> :groovydocAll FAILED
>>>
>>>
>>> FAILURE: Build failed with an exception.
>>>
>>>
>>> * What went wrong:
>>>
>>> Execution failed for task ':groovydocAll'.
>>>
>>> > java.lang.ExceptionInInitializerError (no error message)
>>>
>>>
>>> * Try:
>>>
>>> Run with *--info* or *--debug* option to get more log output.
>>>
>>>
>>> * Exception is:
>>>
>>> org.gradle.api.tasks.TaskExecutionException: Execution failed for task
>>> ':groovydocAll'.
>>>
>>>         at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskEx
>>> ecuter.executeActions(ExecuteActionsTaskExecuter.java:84)
>>>
>>>         at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskEx
>>> ecuter.execute(ExecuteActionsTaskExecuter.java:55)
>>>
>>>         at org.gradle.api.internal.tasks.execution.SkipUpToDateTaskExec
>>> uter.execute(SkipUpToDateTaskExecuter.java:62)
>>>
>>>         at org.gradle.api.internal.tasks.execution.ValidatingTaskExecut
>>> er.execute(ValidatingTaskExecuter.java:58)
>>>
>>>         at org.gradle.api.internal.tasks.execution.SkipEmptySourceFiles
>>> TaskExecuter.execute(SkipEmptySourceFilesTaskExecuter.java:88)
>>>
>>>         at org.gradle.api.internal.tasks.execution.ResolveTaskArtifactS
>>> tateTaskExecuter.execute(ResolveTaskArtifactStateTaskExecuter.java:46)
>>>
>>>         at org.gradle.api.internal.tasks.execution.SkipTaskWithNoAction
>>> sExecuter.execute(SkipTaskWithNoActionsExecuter.java:51)
>>>
>>>         at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecut
>>> er.execute(SkipOnlyIfTaskExecuter.java:54)
>>>
>>>         at org.gradle.api.internal.tasks.execution.ExecuteAtMostOnceTas
>>> kExecuter.execute(ExecuteAtMostOnceTaskExecuter.java:43)
>>>
>>>         at org.gradle.api.internal.tasks.execution.CatchExceptionTaskEx
>>> ecuter.execute(CatchExceptionTaskExecuter.java:34)
>>>
>>>         at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$Even
>>> tFiringTaskWorker$1.execute(DefaultTaskGraphExecuter.java:236)
>>>
>>>         at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$Even
>>> tFiringTaskWorker$1.execute(DefaultTaskGraphExecuter.java:228)
>>>
>>>         at org.gradle.internal.Transformers$4.transform(Transformers.ja
>>> va:169)
>>>
>>>         at org.gradle.internal.progress.DefaultBuildOperationExecutor.r
>>> un(DefaultBuildOperationExecutor.java:106)
>>>
>>>         at org.gradle.internal.progress.DefaultBuildOperationExecutor.r
>>> un(DefaultBuildOperationExecutor.java:61)
>>>
>>>         at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$Even
>>> tFiringTaskWorker.execute(DefaultTaskGraphExecuter.java:228)
>>>
>>>         at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$Even
>>> tFiringTaskWorker.execute(DefaultTaskGraphExecuter.java:215)
>>>
>>>         at org.gradle.execution.taskgraph.AbstractTaskPlanExecutor$Task
>>> ExecutorWorker.processTask(AbstractTaskPlanExecutor.java:77)
>>>
>>>         at org.gradle.execution.taskgraph.AbstractTaskPlanExecutor$Task
>>> ExecutorWorker.run(AbstractTaskPlanExecutor.java:58)
>>>
>>>         at org.gradle.execution.taskgraph.DefaultTaskPlanExecutor.proce
>>> ss(DefaultTaskPlanExecutor.java:32)
>>>
>>>         at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter.exec
>>> ute(DefaultTaskGraphExecuter.java:113)
>>>
>>>         at org.gradle.execution.SelectedTaskExecutionAction.execute(Sel
>>> ectedTaskExecutionAction.java:37)
>>>
>>>         at org.gradle.execution.DefaultBuildExecuter.execute(DefaultBui
>>> ldExecuter.java:37)
>>>
>>>         at org.gradle.execution.DefaultBuildExecuter.access$000(Default
>>> BuildExecuter.java:23)
>>>
>>>         at org.gradle.execution.DefaultBuildExecuter$1.proceed(DefaultB
>>> uildExecuter.java:43)
>>>
>>>         at org.gradle.execution.DryRunBuildExecutionAction.execute(DryR
>>> unBuildExecutionAction.java:32)
>>>
>>>         at org.gradle.execution.DefaultBuildExecuter.execute(DefaultBui
>>> ldExecuter.java:37)
>>>
>>>         at org.gradle.execution.DefaultBuildExecuter.execute(DefaultBui
>>> ldExecuter.java:30)
>>>
>>>         at org.gradle.initialization.DefaultGradleLauncher$RunTasksActi
>>> on.execute(DefaultGradleLauncher.java:256)
>>>
>>>         at org.gradle.initialization.DefaultGradleLauncher$RunTasksActi
>>> on.execute(DefaultGradleLauncher.java:253)
>>>
>>>         at org.gradle.internal.Transformers$4.transform(Transformers.ja
>>> va:169)
>>>
>>>         at org.gradle.internal.progress.DefaultBuildOperationExecutor.r
>>> un(DefaultBuildOperationExecutor.java:106)
>>>
>>>         at org.gradle.internal.progress.DefaultBuildOperationExecutor.r
>>> un(DefaultBuildOperationExecutor.java:56)
>>>
>>>         at org.gradle.initialization.DefaultGradleLauncher.doBuildStage
>>> s(DefaultGradleLauncher.java:175)
>>>
>>>         at org.gradle.initialization.DefaultGradleLauncher.doBuild(Defa
>>> ultGradleLauncher.java:119)
>>>
>>>         at org.gradle.initialization.DefaultGradleLauncher.run(DefaultG
>>> radleLauncher.java:102)
>>>
>>>         at org.gradle.launcher.exec.GradleBuildController.run(GradleBui
>>> ldController.java:71)
>>>
>>>         at org.gradle.tooling.internal.provider.ExecuteBuildActionRunne
>>> r.run(ExecuteBuildActionRunner.java:28)
>>>
>>>         at org.gradle.launcher.exec.ChainingBuildActionRunner.run(Chain
>>> ingBuildActionRunner.java:35)
>>>
>>>         at org.gradle.launcher.exec.InProcessBuildActionExecuter.execut
>>> e(InProcessBuildActionExecuter.java:41)
>>>
>>>         at org.gradle.launcher.exec.InProcessBuildActionExecuter.execut
>>> e(InProcessBuildActionExecuter.java:26)
>>>
>>>         at org.gradle.tooling.internal.provider.ContinuousBuildActionEx
>>> ecuter.execute(ContinuousBuildActionExecuter.java:75)
>>>
>>>         at org.gradle.tooling.internal.provider.ContinuousBuildActionEx
>>> ecuter.execute(ContinuousBuildActionExecuter.java:49)
>>>
>>>         at org.gradle.tooling.internal.provider.ServicesSetupBuildActio
>>> nExecuter.execute(ServicesSetupBuildActionExecuter.java:49)
>>>
>>>         at org.gradle.tooling.internal.provider.ServicesSetupBuildActio
>>> nExecuter.execute(ServicesSetupBuildActionExecuter.java:31)
>>>
>>>         at org.gradle.launcher.daemon.server.exec.ExecuteBuild.doBuild(
>>> ExecuteBuild.java:67)
>>>
>>>         at org.gradle.launcher.daemon.server.exec.BuildCommandOnly.exec
>>> ute(BuildCommandOnly.java:36)
>>>
>>>         at org.gradle.launcher.daemon.server.api.DaemonCommandExecution
>>> .proceed(DaemonCommandExecution.java:120)
>>>
>>>         at org.gradle.launcher.daemon.server.exec.WatchForDisconnection
>>> .execute(WatchForDisconnection.java:47)
>>>
>>>         at org.gradle.launcher.daemon.server.api.DaemonCommandExecution
>>> .proceed(DaemonCommandExecution.java:120)
>>>
>>>         at org.gradle.launcher.daemon.server.exec.ResetDeprecationLogge
>>> r.execute(ResetDeprecationLogger.java:26)
>>>
>>>         at org.gradle.launcher.daemon.server.api.DaemonCommandExecution
>>> .proceed(DaemonCommandExecution.java:120)
>>>
>>>         at org.gradle.launcher.daemon.server.exec.RequestStopIfSingleUs
>>> edDaemon.execute(RequestStopIfSingleUsedDaemon.java:34)
>>>
>>>         at org.gradle.launcher.daemon.server.api.DaemonCommandExecution
>>> .proceed(DaemonCommandExecution.java:120)
>>>
>>>         at org.gradle.launcher.daemon.server.exec.ForwardClientInput$2.
>>> call(ForwardClientInput.java:74)
>>>
>>>         at org.gradle.launcher.daemon.server.exec.ForwardClientInput$2.
>>> call(ForwardClientInput.java:72)
>>>
>>>         at org.gradle.util.Swapper.swap(Swapper.java:38)
>>>
>>>         at org.gradle.launcher.daemon.server.exec.ForwardClientInput.ex
>>> ecute(ForwardClientInput.java:72)
>>>
>>>         at org.gradle.launcher.daemon.server.api.DaemonCommandExecution
>>> .proceed(DaemonCommandExecution.java:120)
>>>
>>>         at org.gradle.launcher.daemon.server.exec.LogAndCheckHealth.exe
>>> cute(LogAndCheckHealth.java:55)
>>>
>>>         at org.gradle.launcher.daemon.server.api.DaemonCommandExecution
>>> .proceed(DaemonCommandExecution.java:120)
>>>
>>>         at org.gradle.launcher.daemon.server.exec.LogToClient.doBuild(L
>>> ogToClient.java:60)
>>>
>>>         at org.gradle.launcher.daemon.server.exec.BuildCommandOnly.exec
>>> ute(BuildCommandOnly.java:36)
>>>
>>>         at org.gradle.launcher.daemon.server.api.DaemonCommandExecution
>>> .proceed(DaemonCommandExecution.java:120)
>>>
>>>         at org.gradle.launcher.daemon.server.exec.EstablishBuildEnviron
>>> ment.doBuild(EstablishBuildEnvironment.java:72)
>>>
>>>         at org.gradle.launcher.daemon.server.exec.BuildCommandOnly.exec
>>> ute(BuildCommandOnly.java:36)
>>>
>>>         at org.gradle.launcher.daemon.server.api.DaemonCommandExecution
>>> .proceed(DaemonCommandExecution.java:120)
>>>
>>>         at org.gradle.launcher.daemon.server.exec.StartBuildOrRespondWi
>>> thBusy$1.run(StartBuildOrRespondWithBusy.java:50)
>>>
>>>         at org.gradle.launcher.daemon.server.DaemonStateCoordinator$1.r
>>> un(DaemonStateCoordinator.java:297)
>>>
>>>         at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecord
>>> Failures.onExecute(ExecutorPolicy.java:63)
>>>
>>>         at org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(S
>>> toppableExecutorImpl.java:46)
>>>
>>> Caused by: java.lang.ExceptionInInitializerError
>>>
>>>         at org.gradle.api.internal.classloading.GroovySystemLoaderFacto
>>> ry.forClassLoader(GroovySystemLoaderFactory.java:44)
>>>
>>>         at org.gradle.api.internal.project.antbuilder.ClassPathToClassL
>>> oaderCache.withCachedClassLoader(ClassPathToClassLoaderCache.java:115)
>>>
>>>         at org.gradle.api.internal.project.antbuilder.DefaultIsolatedAn
>>> tBuilder.execute(DefaultIsolatedAntBuilder.java:127)
>>>
>>>         at org.gradle.api.internal.tasks.AntGroovydoc.getGroovyVersion(
>>> AntGroovydoc.java:113)
>>>
>>>         at org.gradle.api.internal.tasks.AntGroovydoc.execute(AntGroovy
>>> doc.java:74)
>>>
>>>         at org.gradle.api.tasks.javadoc.Groovydoc.generate(Groovydoc.ja
>>> va:98)
>>>
>>>         at org.gradle.internal.reflect.JavaMethod.invoke(JavaMethod.jav
>>> a:73)
>>>
>>>         at org.gradle.api.internal.project.taskfactory.DefaultTaskClass
>>> InfoStore$StandardTaskAction.doExecute(DefaultTaskClassInfoS
>>> tore.java:141)
>>>
>>>         at org.gradle.api.internal.project.taskfactory.DefaultTaskClass
>>> InfoStore$StandardTaskAction.execute(DefaultTaskClassInfoStore.java:134)
>>>
>>>         at org.gradle.api.internal.project.taskfactory.DefaultTaskClass
>>> InfoStore$StandardTaskAction.execute(DefaultTaskClassInfoStore.java:123)
>>>
>>>         at org.gradle.api.internal.AbstractTask$TaskActionWrapper.execu
>>> te(AbstractTask.java:632)
>>>
>>>         at org.gradle.api.internal.AbstractTask$TaskActionWrapper.execu
>>> te(AbstractTask.java:615)
>>>
>>>         at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskEx
>>> ecuter.executeAction(ExecuteActionsTaskExecuter.java:95)
>>>
>>>         at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskEx
>>> ecuter.executeActions(ExecuteActionsTaskExecuter.java:76)
>>>
>>>         ... 70 more
>>>
>>> Caused by: groovy.lang.GroovyRuntimeException: Unable to load module
>>> META-INF descriptor
>>>
>>>         ... 84 more
>>>
>>> Caused by: java.io.FileNotFoundException: JAR entry
>>> META-INF/services/org.codehaus.groovy.runtime.ExtensionModule not found
>>> in /Users/glaforge/Downloads/groovy-2.4.10/subprojects/groovy-x
>>> ml/target/libs/groovy-xml-2.4.10.jar
>>>
>>>         ... 84 more
>>>
>>>
>>>
>>> BUILD FAILED
>>>
>>> On Tue, Mar 14, 2017 at 6:13 AM, Paul King <paulk@asert.com.au> wrote:
>>>
>>>> Okay, I am going to cancel the vote and try again with the commit
>>>> removed for the issue John found. I'll have to work out why one of my
>>>> CI builds didn't trigger that error.
>>>>
>>>> I'll start a new vote shortly. Cédric/Guillaume, I'm keen for any
>>>> further feedback on why you were having issues with the 'dist' task.
>>>> That remains unexplained and unreproducible from my end.
>>>>
>>>> Cheers, Paul.
>>>>
>>>> On Mon, Mar 13, 2017 at 5:16 PM, Paul King <paulk@asert.com.au> wrote:
>>>> > Hi John,
>>>> >
>>>> > I did a bit more testing for the non-spock case and perhaps there is
>>>> > an issue there. I'll see if Jochen or Cédric have a little more
>>>> > knowledge on whether that case should be allowed. Certainly some paths
>>>> > give you ClassFormatError with the dot in the name but there seems to
>>>> > be other paths which may not depending on how you run it - like the
>>>> > test you showed.
>>>> >
>>>> > Cheers, Paul.
>>>> >
>>>> > On Mon, Mar 13, 2017 at 10:38 AM, Paul King <paulk@asert.com.au>
>>>> wrote:
>>>> >> Hi John, the Spock example is fine since that isn't left as the
>>>> method
>>>> >> name by the time the test is run. I am puzzled how the other one
>>>> could
>>>> >> have ever run.
>>>> >>
>>>> >> Cheers, Paul.
>>>> >>
>>>> >> On Sun, Mar 12, 2017 at 9:28 AM, John Wagenleitner
>>>> >> <john.wagenleitner@gmail.com> wrote:
>>>> >>> +1
>>>> >>>
>>>> >>> Just wanted to note that in testing I came across some method
names
>>>> in tests
>>>> >>> that had characters that are now no longer allowed in method
names
>>>> [1] [2].
>>>> >>> I know this is related to the fix for GROOVY-6792, just thought
it
>>>> was odd
>>>> >>> that it seems to have worked in some cases before.
>>>> >>>
>>>> >>> [1]
>>>> >>> https://github.com/grails/grails-core/blob/521f733530160407b
>>>> 92020ff0ed6430858767ed1/grails-test-suite-web/src/test/groov
>>>> y/org/grails/web/codecs/CodecSpec.groovy#L40
>>>> >>>
>>>> >>> [2]
>>>> >>> https://github.com/grails/grails-core/blob/521f733530160407b
>>>> 92020ff0ed6430858767ed1/grails-core/src/test/groovy/org/grai
>>>> ls/compiler/injection/DefaultDomainClassInjectorSpec.groovy#L17
>>>> >>>
>>>> >>> On Thu, Mar 9, 2017 at 2:29 PM, Paul King <paulk@asert.com.au>
>>>> wrote:
>>>> >>>>
>>>> >>>> Dear community,
>>>> >>>>
>>>> >>>> I am happy to start the VOTE thread for a Groovy 2.4.10
release!
>>>> >>>>
>>>> >>>> This release includes 9 bug fixes/improvements as outlined
in the
>>>> >>>> changelog:
>>>> >>>>
>>>> >>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje
>>>> ctId=12318123&version=12339743
>>>> >>>>
>>>> >>>> Tag:
>>>> >>>> https://git1-us-west.apache.org/repos/asf?p=groovy.git;a=tag
>>>> ;h=refs/tags/GROOVY_2_4_10
>>>> >>>> Tag commit id: f2796bad0c5e5d1304e51331244b671ece60c351
>>>> >>>>
>>>> >>>> The artifacts to be voted on are located as follows (r18648).
>>>> >>>> Source release:
>>>> >>>> https://dist.apache.org/repos/dist/dev/groovy/2.4.10/sources
>>>> >>>> Convenience binaries:
>>>> >>>> https://dist.apache.org/repos/dist/dev/groovy/2.4.10/distribution
>>>> >>>>
>>>> >>>> Release artifacts are signed with a key from the following
file:
>>>> >>>> https://dist.apache.org/repos/dist/dev/groovy/KEYS
>>>> >>>>
>>>> >>>> Please vote on releasing this package as Apache Groovy 2.4.10.
>>>> >>>>
>>>> >>>> The vote is open for the next 72 hours and passes if a majority
of
>>>> at
>>>> >>>> least three +1 PMC votes are cast.
>>>> >>>>
>>>> >>>> [ ] +1 Release Apache Groovy 2.4.10
>>>> >>>> [ ]  0 I don't have a strong opinion about this, but I assume
it's
>>>> ok
>>>> >>>> [ ] -1 Do not release Apache Groovy 2.4.10 because...
>>>> >>>>
>>>> >>>> Here is my vote:
>>>> >>>>
>>>> >>>> +1 (binding)
>>>> >>>
>>>> >>>
>>>>
>>>
>>>
>>>
>>> --
>>> Guillaume Laforge
>>> Apache Groovy committer & PMC Vice-President
>>> Developer Advocate @ Google Cloud Platform
>>>
>>> Blog: http://glaforge.appspot.com/
>>> Social: @glaforge <http://twitter.com/glaforge> / Google+
>>> <https://plus.google.com/u/0/114130972232398734985/posts>
>>>
>>
>>
>


-- 
Guillaume Laforge
Apache Groovy committer & PMC Vice-President
Developer Advocate @ Google Cloud Platform

Blog: http://glaforge.appspot.com/
Social: @glaforge <http://twitter.com/glaforge> / Google+
<https://plus.google.com/u/0/114130972232398734985/posts>

Mime
View raw message