groovy-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guillaume Laforge <glafo...@gmail.com>
Subject Re: [CANCEL][VOTE] Release Apache Groovy 2.4.10
Date Tue, 14 Mar 2017 11:36:07 GMT
Rebuilding from a fresh source zip, using gradlew, I still get the error:

* What went wrong:

Execution failed for task ':groovydocAll'.

> java.lang.VerifyError: Bad type on operand stack

  Exception Details:

    Location:


org/codehaus/groovy/tools/groovydoc/GroovyRootDocBuilder.getJavaParser(Ljava/lang/String;Lorg/codehaus/groovy/antlr/SourceBuffer;)Lorg/codehaus/groovy/antlr/java/JavaRecognizer;
@28: invokevirtual

    Reason:

      Type 'org/codehaus/groovy/antlr/java/JavaLexer' (current frame,
stack[1]) is not assignable to 'groovyjarjarantlr/CharScanner'

    Current Frame:

      bci: @28

      flags: { }

      locals: { 'java/lang/String',
'org/codehaus/groovy/antlr/SourceBuffer',
'org/codehaus/groovy/antlr/UnicodeEscapingReader',
'org/codehaus/groovy/antlr/java/JavaLexer' }

      stack: { 'org/codehaus/groovy/antlr/UnicodeEscapingReader',
'org/codehaus/groovy/antlr/java/JavaLexer' }

    Bytecode:

      0x0000000: bb00 bb59 bb00 bd59 2ab7 00be 2bb7 00c1

      0x0000010: 4dbb 00c3 592c b700 c64e 2c2d b600 ca2d

      0x0000020: b800 ce3a 0419 042b b600 d219 04b0

On Tue, Mar 14, 2017 at 12:23 PM, Guillaume Laforge <glaforge@gmail.com>
wrote:

> And with gradlew, in spite of a clean, doing dist gives me tons of those
> AntlrParserPlugin errors :-O
>
> :compileJava
>
> warning: [options] bootstrap class path not set in conjunction with
> -source 1.6
>
> /Users/glaforge/Downloads/groovy-2.4.10/src/main/org/
> codehaus/groovy/ast/tools/GenericsUtils.java:26: error: package
> org.codehaus.groovy.antlr.parser does not exist
>
> import org.codehaus.groovy.antlr.parser.GroovyLexer;
>
>                                        ^
>
> /Users/glaforge/Downloads/groovy-2.4.10/src/main/org/
> codehaus/groovy/ast/tools/GenericsUtils.java:27: error: package
> org.codehaus.groovy.antlr.parser does not exist
>
> import org.codehaus.groovy.antlr.parser.GroovyRecognizer;
>
>                                        ^
>
> /Users/glaforge/Downloads/groovy-2.4.10/src/main/org/
> codehaus/groovy/antlr/AntlrParserPlugin.java:26: error: package
> org.codehaus.groovy.antlr.parser does not exist
>
> import org.codehaus.groovy.antlr.parser.GroovyLexer;
>
>                                        ^
>
> /Users/glaforge/Downloads/groovy-2.4.10/src/main/org/
> codehaus/groovy/antlr/AntlrParserPlugin.java:27: error: package
> org.codehaus.groovy.antlr.parser does not exist
>
> import org.codehaus.groovy.antlr.parser.GroovyRecognizer;
>
>                                        ^
>
> /Users/glaforge/Downloads/groovy-2.4.10/src/main/org/
> codehaus/groovy/antlr/AntlrParserPlugin.java:28: error: package
> org.codehaus.groovy.antlr.parser does not exist
>
> import org.codehaus.groovy.antlr.parser.GroovyTokenTypes;
>
>                                        ^
>
> /Users/glaforge/Downloads/groovy-2.4.10/src/main/org/
> codehaus/groovy/antlr/AntlrParserPlugin.java:58: error: cannot find symbol
>
> public class AntlrParserPlugin extends ASTHelper implements ParserPlugin,
> GroovyTokenTypes {
>
>                                                                           ^
>
>   symbol: class GroovyTokenTypes
>
> /Users/glaforge/Downloads/groovy-2.4.10/src/main/org/
> codehaus/groovy/antlr/java/Groovifier.java:22: error: package
> org.codehaus.groovy.antlr.parser does not exist
>
> import org.codehaus.groovy.antlr.parser.GroovyTokenTypes;
>
>                                        ^
>
> /Users/glaforge/Downloads/groovy-2.4.10/src/main/org/
> codehaus/groovy/antlr/java/Groovifier.java:25: error: cannot find symbol
>
> public class Groovifier extends VisitorAdapter implements GroovyTokenTypes
> {
>
>                                                           ^
>
>   symbol: class GroovyTokenTypes
>
> /Users/glaforge/Downloads/groovy-2.4.10/src/main/org/
> codehaus/groovy/antlr/java/Java2GroovyConverter.java:22: error: package
> org.codehaus.groovy.antlr.parser does not exist
>
> import org.codehaus.groovy.antlr.parser.GroovyTokenTypes;
>
>                                        ^
>
> On Tue, Mar 14, 2017 at 12:21 PM, Guillaume Laforge <glaforge@gmail.com>
> wrote:
>
>> There's indeed a problem with cleanliness.
>> I get Antlr related problems in AntlrParserPlugin when not cleaning.
>>
>> I'm gonna try with the wrapper, just in case, as suggested by Paul.
>>
>> On Tue, Mar 14, 2017 at 11:12 AM, Cédric Champeau <
>> cedric.champeau@gmail.com> wrote:
>>
>>> Actually got the same error as Guillaume using Gradle 2.3:
>>> https://gradle.com/s/5d6oqw3wsbtny
>>>
>>> There's something wrong with the build somehow. I guess this one happens
>>> when the build isn't clean. It definitely needs a rewrite to benefit from
>>> all the latest Gradle nifties.
>>>
>>>
>>> 2017-03-14 10:53 GMT+01:00 Cédric Champeau <cedric.champeau@gmail.com>:
>>>
>>>> I think the error comes from using the latest Gradle release with the
>>>> 2.4.x branch: they don't seem to be compatible. Master uses latest Gradle,
>>>> not 2.4.x.
>>>>
>>>> 2017-03-14 9:01 GMT+01:00 Guillaume Laforge <glaforge@gmail.com>:
>>>>
>>>>> I upgraded my local Groovy and Gradle to the latest SDKman-available
>>>>> versions (2.4.9 and 3.4.1 respectively).
>>>>> Re-launching the dist build with --stacktrace, I have something
>>>>> different now...
>>>>>
>>>>> :groovydocAll FAILED
>>>>>
>>>>>
>>>>> FAILURE: Build failed with an exception.
>>>>>
>>>>>
>>>>> * What went wrong:
>>>>>
>>>>> Execution failed for task ':groovydocAll'.
>>>>>
>>>>> > java.lang.ExceptionInInitializerError (no error message)
>>>>>
>>>>>
>>>>> * Try:
>>>>>
>>>>> Run with *--info* or *--debug* option to get more log output.
>>>>>
>>>>>
>>>>> * Exception is:
>>>>>
>>>>> org.gradle.api.tasks.TaskExecutionException: Execution failed for
>>>>> task ':groovydocAll'.
>>>>>
>>>>>         at org.gradle.api.internal.tasks.
>>>>> execution.ExecuteActionsTaskExecuter.executeActions(ExecuteA
>>>>> ctionsTaskExecuter.java:84)
>>>>>
>>>>>         at org.gradle.api.internal.tasks.
>>>>> execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsT
>>>>> askExecuter.java:55)
>>>>>
>>>>>         at org.gradle.api.internal.tasks.
>>>>> execution.SkipUpToDateTaskExecuter.execute(SkipUpToDateTaskE
>>>>> xecuter.java:62)
>>>>>
>>>>>         at org.gradle.api.internal.tasks.
>>>>> execution.ValidatingTaskExecuter.execute(ValidatingTaskExecu
>>>>> ter.java:58)
>>>>>
>>>>>         at org.gradle.api.internal.tasks.
>>>>> execution.SkipEmptySourceFilesTaskExecuter.execute(SkipEmpty
>>>>> SourceFilesTaskExecuter.java:88)
>>>>>
>>>>>         at org.gradle.api.internal.tasks.
>>>>> execution.ResolveTaskArtifactStateTaskExecuter.execute(Resol
>>>>> veTaskArtifactStateTaskExecuter.java:46)
>>>>>
>>>>>         at org.gradle.api.internal.tasks.
>>>>> execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWith
>>>>> NoActionsExecuter.java:51)
>>>>>
>>>>>         at org.gradle.api.internal.tasks.
>>>>> execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecu
>>>>> ter.java:54)
>>>>>
>>>>>         at org.gradle.api.internal.tasks.
>>>>> execution.ExecuteAtMostOnceTaskExecuter.execute(ExecuteAtMos
>>>>> tOnceTaskExecuter.java:43)
>>>>>
>>>>>         at org.gradle.api.internal.tasks.
>>>>> execution.CatchExceptionTaskExecuter.execute(CatchExceptionT
>>>>> askExecuter.java:34)
>>>>>
>>>>>         at org.gradle.execution.taskgraph
>>>>> .DefaultTaskGraphExecuter$EventFiringTaskWorker$1.execute(De
>>>>> faultTaskGraphExecuter.java:236)
>>>>>
>>>>>         at org.gradle.execution.taskgraph
>>>>> .DefaultTaskGraphExecuter$EventFiringTaskWorker$1.execute(De
>>>>> faultTaskGraphExecuter.java:228)
>>>>>
>>>>>         at org.gradle.internal.Transforme
>>>>> rs$4.transform(Transformers.java:169)
>>>>>
>>>>>         at org.gradle.internal.progress.D
>>>>> efaultBuildOperationExecutor.run(DefaultBuildOperationExecut
>>>>> or.java:106)
>>>>>
>>>>>         at org.gradle.internal.progress.D
>>>>> efaultBuildOperationExecutor.run(DefaultBuildOperationExecut
>>>>> or.java:61)
>>>>>
>>>>>         at org.gradle.execution.taskgraph
>>>>> .DefaultTaskGraphExecuter$EventFiringTaskWorker.execute(Defa
>>>>> ultTaskGraphExecuter.java:228)
>>>>>
>>>>>         at org.gradle.execution.taskgraph
>>>>> .DefaultTaskGraphExecuter$EventFiringTaskWorker.execute(Defa
>>>>> ultTaskGraphExecuter.java:215)
>>>>>
>>>>>         at org.gradle.execution.taskgraph
>>>>> .AbstractTaskPlanExecutor$TaskExecutorWorker.processTask(Abs
>>>>> tractTaskPlanExecutor.java:77)
>>>>>
>>>>>         at org.gradle.execution.taskgraph
>>>>> .AbstractTaskPlanExecutor$TaskExecutorWorker.run(AbstractTas
>>>>> kPlanExecutor.java:58)
>>>>>
>>>>>         at org.gradle.execution.taskgraph
>>>>> .DefaultTaskPlanExecutor.process(DefaultTaskPlanExecutor.java:32)
>>>>>
>>>>>         at org.gradle.execution.taskgraph
>>>>> .DefaultTaskGraphExecuter.execute(DefaultTaskGraphExecuter.java:113)
>>>>>
>>>>>         at org.gradle.execution.SelectedT
>>>>> askExecutionAction.execute(SelectedTaskExecutionAction.java:37)
>>>>>
>>>>>         at org.gradle.execution.DefaultBu
>>>>> ildExecuter.execute(DefaultBuildExecuter.java:37)
>>>>>
>>>>>         at org.gradle.execution.DefaultBu
>>>>> ildExecuter.access$000(DefaultBuildExecuter.java:23)
>>>>>
>>>>>         at org.gradle.execution.DefaultBu
>>>>> ildExecuter$1.proceed(DefaultBuildExecuter.java:43)
>>>>>
>>>>>         at org.gradle.execution.DryRunBui
>>>>> ldExecutionAction.execute(DryRunBuildExecutionAction.java:32)
>>>>>
>>>>>         at org.gradle.execution.DefaultBu
>>>>> ildExecuter.execute(DefaultBuildExecuter.java:37)
>>>>>
>>>>>         at org.gradle.execution.DefaultBu
>>>>> ildExecuter.execute(DefaultBuildExecuter.java:30)
>>>>>
>>>>>         at org.gradle.initialization.Defa
>>>>> ultGradleLauncher$RunTasksAction.execute(DefaultGradleLaunch
>>>>> er.java:256)
>>>>>
>>>>>         at org.gradle.initialization.Defa
>>>>> ultGradleLauncher$RunTasksAction.execute(DefaultGradleLaunch
>>>>> er.java:253)
>>>>>
>>>>>         at org.gradle.internal.Transforme
>>>>> rs$4.transform(Transformers.java:169)
>>>>>
>>>>>         at org.gradle.internal.progress.D
>>>>> efaultBuildOperationExecutor.run(DefaultBuildOperationExecut
>>>>> or.java:106)
>>>>>
>>>>>         at org.gradle.internal.progress.D
>>>>> efaultBuildOperationExecutor.run(DefaultBuildOperationExecut
>>>>> or.java:56)
>>>>>
>>>>>         at org.gradle.initialization.Defa
>>>>> ultGradleLauncher.doBuildStages(DefaultGradleLauncher.java:175)
>>>>>
>>>>>         at org.gradle.initialization.Defa
>>>>> ultGradleLauncher.doBuild(DefaultGradleLauncher.java:119)
>>>>>
>>>>>         at org.gradle.initialization.Defa
>>>>> ultGradleLauncher.run(DefaultGradleLauncher.java:102)
>>>>>
>>>>>         at org.gradle.launcher.exec.Gradl
>>>>> eBuildController.run(GradleBuildController.java:71)
>>>>>
>>>>>         at org.gradle.tooling.internal.pr
>>>>> ovider.ExecuteBuildActionRunner.run(ExecuteBuildActionRunner.java:28)
>>>>>
>>>>>         at org.gradle.launcher.exec.Chain
>>>>> ingBuildActionRunner.run(ChainingBuildActionRunner.java:35)
>>>>>
>>>>>         at org.gradle.launcher.exec.InPro
>>>>> cessBuildActionExecuter.execute(InProcessBuildActionExecuter.java:41)
>>>>>
>>>>>         at org.gradle.launcher.exec.InPro
>>>>> cessBuildActionExecuter.execute(InProcessBuildActionExecuter.java:26)
>>>>>
>>>>>         at org.gradle.tooling.internal.pr
>>>>> ovider.ContinuousBuildActionExecuter.execute(ContinuousBuild
>>>>> ActionExecuter.java:75)
>>>>>
>>>>>         at org.gradle.tooling.internal.pr
>>>>> ovider.ContinuousBuildActionExecuter.execute(ContinuousBuild
>>>>> ActionExecuter.java:49)
>>>>>
>>>>>         at org.gradle.tooling.internal.pr
>>>>> ovider.ServicesSetupBuildActionExecuter.execute(ServicesSetu
>>>>> pBuildActionExecuter.java:49)
>>>>>
>>>>>         at org.gradle.tooling.internal.pr
>>>>> ovider.ServicesSetupBuildActionExecuter.execute(ServicesSetu
>>>>> pBuildActionExecuter.java:31)
>>>>>
>>>>>         at org.gradle.launcher.daemon.ser
>>>>> ver.exec.ExecuteBuild.doBuild(ExecuteBuild.java:67)
>>>>>
>>>>>         at org.gradle.launcher.daemon.ser
>>>>> ver.exec.BuildCommandOnly.execute(BuildCommandOnly.java:36)
>>>>>
>>>>>         at org.gradle.launcher.daemon.ser
>>>>> ver.api.DaemonCommandExecution.proceed(DaemonCommandExecutio
>>>>> n.java:120)
>>>>>
>>>>>         at org.gradle.launcher.daemon.ser
>>>>> ver.exec.WatchForDisconnection.execute(WatchForDisconnection.java:47)
>>>>>
>>>>>         at org.gradle.launcher.daemon.ser
>>>>> ver.api.DaemonCommandExecution.proceed(DaemonCommandExecutio
>>>>> n.java:120)
>>>>>
>>>>>         at org.gradle.launcher.daemon.ser
>>>>> ver.exec.ResetDeprecationLogger.execute(ResetDeprecationLogg
>>>>> er.java:26)
>>>>>
>>>>>         at org.gradle.launcher.daemon.ser
>>>>> ver.api.DaemonCommandExecution.proceed(DaemonCommandExecutio
>>>>> n.java:120)
>>>>>
>>>>>         at org.gradle.launcher.daemon.ser
>>>>> ver.exec.RequestStopIfSingleUsedDaemon.execute(RequestStopIf
>>>>> SingleUsedDaemon.java:34)
>>>>>
>>>>>         at org.gradle.launcher.daemon.ser
>>>>> ver.api.DaemonCommandExecution.proceed(DaemonCommandExecutio
>>>>> n.java:120)
>>>>>
>>>>>         at org.gradle.launcher.daemon.ser
>>>>> ver.exec.ForwardClientInput$2.call(ForwardClientInput.java:74)
>>>>>
>>>>>         at org.gradle.launcher.daemon.ser
>>>>> ver.exec.ForwardClientInput$2.call(ForwardClientInput.java:72)
>>>>>
>>>>>         at org.gradle.util.Swapper.swap(Swapper.java:38)
>>>>>
>>>>>         at org.gradle.launcher.daemon.ser
>>>>> ver.exec.ForwardClientInput.execute(ForwardClientInput.java:72)
>>>>>
>>>>>         at org.gradle.launcher.daemon.ser
>>>>> ver.api.DaemonCommandExecution.proceed(DaemonCommandExecutio
>>>>> n.java:120)
>>>>>
>>>>>         at org.gradle.launcher.daemon.ser
>>>>> ver.exec.LogAndCheckHealth.execute(LogAndCheckHealth.java:55)
>>>>>
>>>>>         at org.gradle.launcher.daemon.ser
>>>>> ver.api.DaemonCommandExecution.proceed(DaemonCommandExecutio
>>>>> n.java:120)
>>>>>
>>>>>         at org.gradle.launcher.daemon.ser
>>>>> ver.exec.LogToClient.doBuild(LogToClient.java:60)
>>>>>
>>>>>         at org.gradle.launcher.daemon.ser
>>>>> ver.exec.BuildCommandOnly.execute(BuildCommandOnly.java:36)
>>>>>
>>>>>         at org.gradle.launcher.daemon.ser
>>>>> ver.api.DaemonCommandExecution.proceed(DaemonCommandExecutio
>>>>> n.java:120)
>>>>>
>>>>>         at org.gradle.launcher.daemon.ser
>>>>> ver.exec.EstablishBuildEnvironment.doBuild(EstablishBuildEnv
>>>>> ironment.java:72)
>>>>>
>>>>>         at org.gradle.launcher.daemon.ser
>>>>> ver.exec.BuildCommandOnly.execute(BuildCommandOnly.java:36)
>>>>>
>>>>>         at org.gradle.launcher.daemon.ser
>>>>> ver.api.DaemonCommandExecution.proceed(DaemonCommandExecutio
>>>>> n.java:120)
>>>>>
>>>>>         at org.gradle.launcher.daemon.ser
>>>>> ver.exec.StartBuildOrRespondWithBusy$1.run(StartBuildOrRespo
>>>>> ndWithBusy.java:50)
>>>>>
>>>>>         at org.gradle.launcher.daemon.ser
>>>>> ver.DaemonStateCoordinator$1.run(DaemonStateCoordinator.java:297)
>>>>>
>>>>>         at org.gradle.internal.concurrent
>>>>> .ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPol
>>>>> icy.java:63)
>>>>>
>>>>>         at org.gradle.internal.concurrent
>>>>> .StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:46)
>>>>>
>>>>> Caused by: java.lang.ExceptionInInitializerError
>>>>>
>>>>>         at org.gradle.api.internal.classl
>>>>> oading.GroovySystemLoaderFactory.forClassLoader(GroovySystem
>>>>> LoaderFactory.java:44)
>>>>>
>>>>>         at org.gradle.api.internal.projec
>>>>> t.antbuilder.ClassPathToClassLoaderCache.withCachedClassLoad
>>>>> er(ClassPathToClassLoaderCache.java:115)
>>>>>
>>>>>         at org.gradle.api.internal.projec
>>>>> t.antbuilder.DefaultIsolatedAntBuilder.execute(DefaultIsolat
>>>>> edAntBuilder.java:127)
>>>>>
>>>>>         at org.gradle.api.internal.tasks.
>>>>> AntGroovydoc.getGroovyVersion(AntGroovydoc.java:113)
>>>>>
>>>>>         at org.gradle.api.internal.tasks.
>>>>> AntGroovydoc.execute(AntGroovydoc.java:74)
>>>>>
>>>>>         at org.gradle.api.tasks.javadoc.G
>>>>> roovydoc.generate(Groovydoc.java:98)
>>>>>
>>>>>         at org.gradle.internal.reflect.Ja
>>>>> vaMethod.invoke(JavaMethod.java:73)
>>>>>
>>>>>         at org.gradle.api.internal.projec
>>>>> t.taskfactory.DefaultTaskClassInfoStore$StandardTaskAction.d
>>>>> oExecute(DefaultTaskClassInfoStore.java:141)
>>>>>
>>>>>         at org.gradle.api.internal.projec
>>>>> t.taskfactory.DefaultTaskClassInfoStore$StandardTaskAction.e
>>>>> xecute(DefaultTaskClassInfoStore.java:134)
>>>>>
>>>>>         at org.gradle.api.internal.projec
>>>>> t.taskfactory.DefaultTaskClassInfoStore$StandardTaskAction.e
>>>>> xecute(DefaultTaskClassInfoStore.java:123)
>>>>>
>>>>>         at org.gradle.api.internal.Abstra
>>>>> ctTask$TaskActionWrapper.execute(AbstractTask.java:632)
>>>>>
>>>>>         at org.gradle.api.internal.Abstra
>>>>> ctTask$TaskActionWrapper.execute(AbstractTask.java:615)
>>>>>
>>>>>         at org.gradle.api.internal.tasks.
>>>>> execution.ExecuteActionsTaskExecuter.executeAction(ExecuteAc
>>>>> tionsTaskExecuter.java:95)
>>>>>
>>>>>         at org.gradle.api.internal.tasks.
>>>>> execution.ExecuteActionsTaskExecuter.executeActions(ExecuteA
>>>>> ctionsTaskExecuter.java:76)
>>>>>
>>>>>         ... 70 more
>>>>>
>>>>> Caused by: groovy.lang.GroovyRuntimeException: Unable to load module
>>>>> META-INF descriptor
>>>>>
>>>>>         ... 84 more
>>>>>
>>>>> Caused by: java.io.FileNotFoundException: JAR entry
>>>>> META-INF/services/org.codehaus.groovy.runtime.ExtensionModule not
>>>>> found in /Users/glaforge/Downloads/groovy-2.4.10/subprojects/groovy-x
>>>>> ml/target/libs/groovy-xml-2.4.10.jar
>>>>>
>>>>>         ... 84 more
>>>>>
>>>>>
>>>>>
>>>>> BUILD FAILED
>>>>>
>>>>> On Tue, Mar 14, 2017 at 6:13 AM, Paul King <paulk@asert.com.au>
wrote:
>>>>>
>>>>>> Okay, I am going to cancel the vote and try again with the commit
>>>>>> removed for the issue John found. I'll have to work out why one of
my
>>>>>> CI builds didn't trigger that error.
>>>>>>
>>>>>> I'll start a new vote shortly. Cédric/Guillaume, I'm keen for any
>>>>>> further feedback on why you were having issues with the 'dist' task.
>>>>>> That remains unexplained and unreproducible from my end.
>>>>>>
>>>>>> Cheers, Paul.
>>>>>>
>>>>>> On Mon, Mar 13, 2017 at 5:16 PM, Paul King <paulk@asert.com.au>
>>>>>> wrote:
>>>>>> > Hi John,
>>>>>> >
>>>>>> > I did a bit more testing for the non-spock case and perhaps
there is
>>>>>> > an issue there. I'll see if Jochen or Cédric have a little
more
>>>>>> > knowledge on whether that case should be allowed. Certainly
some
>>>>>> paths
>>>>>> > give you ClassFormatError with the dot in the name but there
seems
>>>>>> to
>>>>>> > be other paths which may not depending on how you run it - like
the
>>>>>> > test you showed.
>>>>>> >
>>>>>> > Cheers, Paul.
>>>>>> >
>>>>>> > On Mon, Mar 13, 2017 at 10:38 AM, Paul King <paulk@asert.com.au>
>>>>>> wrote:
>>>>>> >> Hi John, the Spock example is fine since that isn't left
as the
>>>>>> method
>>>>>> >> name by the time the test is run. I am puzzled how the other
one
>>>>>> could
>>>>>> >> have ever run.
>>>>>> >>
>>>>>> >> Cheers, Paul.
>>>>>> >>
>>>>>> >> On Sun, Mar 12, 2017 at 9:28 AM, John Wagenleitner
>>>>>> >> <john.wagenleitner@gmail.com> wrote:
>>>>>> >>> +1
>>>>>> >>>
>>>>>> >>> Just wanted to note that in testing I came across some
method
>>>>>> names in tests
>>>>>> >>> that had characters that are now no longer allowed in
method
>>>>>> names [1] [2].
>>>>>> >>> I know this is related to the fix for GROOVY-6792, just
thought
>>>>>> it was odd
>>>>>> >>> that it seems to have worked in some cases before.
>>>>>> >>>
>>>>>> >>> [1]
>>>>>> >>> https://github.com/grails/grails-core/blob/521f733530160407b
>>>>>> 92020ff0ed6430858767ed1/grails-test-suite-web/src/test/groov
>>>>>> y/org/grails/web/codecs/CodecSpec.groovy#L40
>>>>>> >>>
>>>>>> >>> [2]
>>>>>> >>> https://github.com/grails/grails-core/blob/521f733530160407b
>>>>>> 92020ff0ed6430858767ed1/grails-core/src/test/groovy/org/grai
>>>>>> ls/compiler/injection/DefaultDomainClassInjectorSpec.groovy#L17
>>>>>> >>>
>>>>>> >>> On Thu, Mar 9, 2017 at 2:29 PM, Paul King <paulk@asert.com.au>
>>>>>> wrote:
>>>>>> >>>>
>>>>>> >>>> Dear community,
>>>>>> >>>>
>>>>>> >>>> I am happy to start the VOTE thread for a Groovy
2.4.10 release!
>>>>>> >>>>
>>>>>> >>>> This release includes 9 bug fixes/improvements as
outlined in the
>>>>>> >>>> changelog:
>>>>>> >>>>
>>>>>> >>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje
>>>>>> ctId=12318123&version=12339743
>>>>>> >>>>
>>>>>> >>>> Tag:
>>>>>> >>>> https://git1-us-west.apache.org/repos/asf?p=groovy.git;a=tag
>>>>>> ;h=refs/tags/GROOVY_2_4_10
>>>>>> >>>> Tag commit id: f2796bad0c5e5d1304e51331244b671ece60c351
>>>>>> >>>>
>>>>>> >>>> The artifacts to be voted on are located as follows
(r18648).
>>>>>> >>>> Source release:
>>>>>> >>>> https://dist.apache.org/repos/dist/dev/groovy/2.4.10/sources
>>>>>> >>>> Convenience binaries:
>>>>>> >>>> https://dist.apache.org/repos/dist/dev/groovy/2.4.10/distrib
>>>>>> ution
>>>>>> >>>>
>>>>>> >>>> Release artifacts are signed with a key from the
following file:
>>>>>> >>>> https://dist.apache.org/repos/dist/dev/groovy/KEYS
>>>>>> >>>>
>>>>>> >>>> Please vote on releasing this package as Apache
Groovy 2.4.10.
>>>>>> >>>>
>>>>>> >>>> The vote is open for the next 72 hours and passes
if a majority
>>>>>> of at
>>>>>> >>>> least three +1 PMC votes are cast.
>>>>>> >>>>
>>>>>> >>>> [ ] +1 Release Apache Groovy 2.4.10
>>>>>> >>>> [ ]  0 I don't have a strong opinion about this,
but I assume
>>>>>> it's ok
>>>>>> >>>> [ ] -1 Do not release Apache Groovy 2.4.10 because...
>>>>>> >>>>
>>>>>> >>>> Here is my vote:
>>>>>> >>>>
>>>>>> >>>> +1 (binding)
>>>>>> >>>
>>>>>> >>>
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Guillaume Laforge
>>>>> Apache Groovy committer & PMC Vice-President
>>>>> Developer Advocate @ Google Cloud Platform
>>>>>
>>>>> Blog: http://glaforge.appspot.com/
>>>>> Social: @glaforge <http://twitter.com/glaforge> / Google+
>>>>> <https://plus.google.com/u/0/114130972232398734985/posts>
>>>>>
>>>>
>>>>
>>>
>>
>>
>> --
>> Guillaume Laforge
>> Apache Groovy committer & PMC Vice-President
>> Developer Advocate @ Google Cloud Platform
>>
>> Blog: http://glaforge.appspot.com/
>> Social: @glaforge <http://twitter.com/glaforge> / Google+
>> <https://plus.google.com/u/0/114130972232398734985/posts>
>>
>
>
>
> --
> Guillaume Laforge
> Apache Groovy committer & PMC Vice-President
> Developer Advocate @ Google Cloud Platform
>
> Blog: http://glaforge.appspot.com/
> Social: @glaforge <http://twitter.com/glaforge> / Google+
> <https://plus.google.com/u/0/114130972232398734985/posts>
>



-- 
Guillaume Laforge
Apache Groovy committer & PMC Vice-President
Developer Advocate @ Google Cloud Platform

Blog: http://glaforge.appspot.com/
Social: @glaforge <http://twitter.com/glaforge> / Google+
<https://plus.google.com/u/0/114130972232398734985/posts>

Mime
View raw message