Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3C0AF200C09 for ; Wed, 25 Jan 2017 13:10:57 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 3A9A3160B50; Wed, 25 Jan 2017 12:10:57 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 81F65160B4E for ; Wed, 25 Jan 2017 13:10:56 +0100 (CET) Received: (qmail 54347 invoked by uid 500); 25 Jan 2017 12:10:55 -0000 Mailing-List: contact dev-help@groovy.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@groovy.apache.org Delivered-To: mailing list dev@groovy.apache.org Received: (qmail 54337 invoked by uid 99); 25 Jan 2017 12:10:55 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Jan 2017 12:10:55 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id C6548C0F8E for ; Wed, 25 Jan 2017 12:10:54 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.379 X-Spam-Level: ** X-Spam-Status: No, score=2.379 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_SORBS_SPAM=0.5, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 6JIjm8O1mC5O for ; Wed, 25 Jan 2017 12:10:53 +0000 (UTC) Received: from mail-ot0-f175.google.com (mail-ot0-f175.google.com [74.125.82.175]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 98EC85F201 for ; Wed, 25 Jan 2017 12:10:53 +0000 (UTC) Received: by mail-ot0-f175.google.com with SMTP id f9so150036638otd.1 for ; Wed, 25 Jan 2017 04:10:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=MtPVTKhhvkwAMR0FiR9ESAusT2CvaqNbQLNiiGGYEQ4=; b=EopOXJ6pJ8586AVmLd/WwafpnUunoS5gUVTCLZSAZezvprEFFAbL5hIHzo/QyRB8gq Vx2vY5CUS5XT9HdpI4UJiTU3a664cQdluiYaiPXLByaB9Q3cnk6BrVYMBi6XwEeN8HSZ RsIwemNuRHn4zPpD7fKk57k+07dpVAwul8X39Mm748KjK6de4GXQgFaMwolaYPsoi/rq enoHtuLg0PuW3Tllz02VKIetoWf1xUYJp9q7qUrg81bzjsMqtHqBOxrDKRxyLEP3hq2e DW7O5KXneHHbTIkg697tTsGbhoFnoNH61vO4FhvE/ETQIc903M4Xd9NH2lINzAU3S9v7 PFSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=MtPVTKhhvkwAMR0FiR9ESAusT2CvaqNbQLNiiGGYEQ4=; b=F22O7cmX1cfDZ0eOuAyLYwJ24ZkYdEHGlGe48X/Gv8O09PMeaoqiY/xe/r9y6+1DDR Bqxj3oEGes2mYMmNoiXza/1HLrtYhnPs7eXmXFqZrwfGOTW4rjB/GoZFHAuA/cHafkki hogX3F73M9ZNDR4EvlUPMwg+Boq+4AYLMe6YEAZoU+8HmFY78C92aJmmnNQdg6Jra5oA aRxlbnr4ISn1wM7fa0hsdBRrl5M/Z3HGvRPRwknLdXISAkvXKEHr84T+cEjQSDiOR6KU gH3YF4/T9ugrcBA9BQMLGL3gb7QHPE1n7xHesH39+hcfDTALtAm8rQ4OPcdnYpLhXfjS jTIw== X-Gm-Message-State: AIkVDXL/PpS++eA8vy6OA2f/26AcU6tTvHbKx2DLhcX005ra7Vnuws1MvmwwsfjNbHmabvMId5v+H2AD97OXxA== X-Received: by 10.157.6.7 with SMTP id 7mr21300440otn.254.1485346252995; Wed, 25 Jan 2017 04:10:52 -0800 (PST) MIME-Version: 1.0 Received: by 10.202.193.197 with HTTP; Wed, 25 Jan 2017 04:10:52 -0800 (PST) In-Reply-To: References: From: =?UTF-8?Q?C=C3=A9dric_Champeau?= Date: Wed, 25 Jan 2017 13:10:52 +0100 Message-ID: Subject: Re: Traits and protected properties To: dev@groovy.apache.org, Paul King Content-Type: multipart/alternative; boundary=94eb2c095f7ac743590546ea1f0e archived-at: Wed, 25 Jan 2017 12:10:57 -0000 --94eb2c095f7ac743590546ea1f0e Content-Type: text/plain; charset=UTF-8 +1, this is an oversight from my side, protected properties should be prohibited too. 2017-01-25 12:56 GMT+01:00 Paul King : > Hi, for traits we explicitly prohibit protected (and package private) > methods - see the doco for some details. For properties however, we > never check (in 2.4.7 and earlier) for that case (protected) and in > fact include the property in the trait as if it was private. I was > thinking of adding an extra check to prohibit protected properties > since I don't think we can give any special meaning beyond private (or > public) and it's only confusing to let that case through. Any other > opinions? > > Cheers, Paul. > --94eb2c095f7ac743590546ea1f0e Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
+1, this is an oversight from my side, protected propertie= s should be prohibited too.

2017-01-25 12:56 GMT+01:00 Paul King <= ;paulk@asert.com.au= >:
Hi, for traits we explic= itly prohibit protected (and package private)
methods - see the doco for some details. For properties however, we
never check (in 2.4.7 and earlier) for that case (protected) and in
fact include the property in the trait as if it was private. I was
thinking of adding an extra check to prohibit protected properties
since I don't think we can give any special meaning beyond private (or<= br> public) and it's only confusing to let that case through. Any other
opinions?

Cheers, Paul.

--94eb2c095f7ac743590546ea1f0e--