groovy-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bo zhang <zhangbo...@gmail.com>
Subject Re: An issue about comparing arrays
Date Thu, 03 Nov 2016 01:24:11 GMT
Yes, that's my first instinct too, but a few minutes later I found test
cases as follows:

assert [[[5, 6], [7, 8]]] as int[][][] == [[[5, 6], [7, 8]]] as Long[][][]

See
https://github.com/groovy/groovy-core/blob/master/src/test/groovy/ArrayTest.groovy#L207

I think this issue can be discussed, anybody has opinions?

2016-11-03 7:51 GMT+08:00 Daniel.Sun <realbluesun@hotmail.com>:

> IMO, we should compare their type first. If not same, the comparing result
> should be 'false'.
>
> Cheers,
> Daniel.Sun
>
>
>
> 在 "bo zhang [via Groovy]" <ml-node+[hidden email]
> <http:///user/SendEmail.jtp?type=node&node=5736460&i=0>>,2016年11月3日
> 06:53写道:
>
> I'm afraid it's not a bug.
>
> Actually, `def a=new int[2][]` means that a is an array of two null
> pointers with type "int []", and `def b=new int[2][][]` means that b is an
> array of two null pointers with type "int[][]", it seems that they should
> be equal.
>
> See https://github.com/groovy/groovy-core/blob/master/src/
> test/groovy/ArrayTest.groovy#L198
>
>
> ​
>
> 2016-10-30 18:50 GMT+08:00 Daniel.Sun <[hidden email]>:
>
>> Hi Jochen,
>>
>>      I create JIRA issue
>> GROOVY-7983(https://issues.apache.org/jira/browse/GROOVY-7983) to track
>> the
>> issue.
>>
>>      BTW,  the code in the email should be corrected as follow:
>>
>> def a = new int[2][]
>> def b = new int[2][][]
>> assert a == b // expect faling
>>
>> Cheers,
>> Daniel.Sun
>>
>>
>>
>> --
>> View this message in context: http://groovy.329449.n5.
>> nabble.com/An-issue-about-comparing-arrays-tp5736379p5736398.html
>> Sent from the Groovy Dev mailing list archive at Nabble.com.
>>
>
>
>
> ------------------------------
> If you reply to this email, your message will be added to the discussion
> below:
> http://groovy.329449.n5.nabble.com/An-issue-about-comparing-arrays-
> tp5736379p5736458.html
> To unsubscribe from An issue about comparing arrays, click here.
> NAML
> <http://groovy.329449.n5.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml>
>
>
> ------------------------------
> View this message in context: Re: An issue about comparing arrays
> <http://groovy.329449.n5.nabble.com/An-issue-about-comparing-arrays-tp5736379p5736460.html>
>
> Sent from the Groovy Dev mailing list archive
> <http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html> at
> Nabble.com.
>

Mime
View raw message