Mailing-List: contact dev-help@groovy.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@groovy.apache.org
MIME-Version: 1.0
Reply-To: paulk@asert.com.au
In-Reply-To: <CAJ2HCd_yy+kgz-pFQkTXr+V0ARp_3D1AyseRRdi0ceLD5Jbpzw@mail.gmail.com>
References: <CAJp1MBMM48nVGZfNw-BiGE3qAx8O6EhxknOmk4ojaifGWwjKUA@mail.gmail.com>
 <CAJp1MBPDChuV7ND=ofiHo166-C+ddH9GhxLL4cffiuWByOyAbw@mail.gmail.com>
 <CAAJdKXmYBYuKbas9NL3BfYzkXx1VatAuR4fC=OZqC3OaBBZ0BQ@mail.gmail.com> <CAJ2HCd_yy+kgz-pFQkTXr+V0ARp_3D1AyseRRdi0ceLD5Jbpzw@mail.gmail.com>
From: Paul King <paulk@asert.com.au>
Date: Fri, 7 Oct 2016 21:57:08 +1000
Message-ID: <CAMbkE7RvL+NCRkiNK97phxySCFniaA_ea1=f80tk3OB0kcy2rQ@mail.gmail.com>
Subject: Re: Groovy macro documentation
To: dev@groovy.apache.org
Content-Type: text/plain; charset=UTF-8
archived-at: Fri, 07 Oct 2016 11:57:15 -0000

I'll try to review over the next little while too. Looks very
promising at first glance! Exciting to see a good start!

Paul.

On Fri, Oct 7, 2016 at 9:17 PM, Guillaume Laforge <glaforge@gmail.com> wrote:
> For reference, here's the PR:
> https://github.com/apache/groovy/pull/439
>
> On Fri, Oct 7, 2016 at 1:00 PM, Sergei Egorov <bsideup@gmail.com> wrote:
>>
>> Hey Mario,
>>
>> Wow! This is great! Didn't know you're working on it. I'll be happy to
>> review :)
>>
>>
>> Cheers,
>> Sergei
>>
>> On Fri, Oct 7, 2016 at 1:53 PM Mario Garcia <mario.ggar@gmail.com> wrote:
>>>
>>> Hi all:
>>>
>>> I sent a WIP with some groovy-macro documentation. The main problem with
>>> the PR is that there're two tests failing. I've been checking tests code and
>>> I can't see anything that may cause these tests to fail.
>>>
>>> I'll be reviewing the whole thing during the weekend but it would be
>>> better if anyone else could look into this.
>>>
>>> Of course I'd love to receive feedback related to the documentation. I'm
>>> sure there must be some typos, or something that should be explained
>>> better...
>>>
>>> Cheers
>>>
>>> Mario
>
>
>
>
> --
> Guillaume Laforge
> Apache Groovy committer & PMC Vice-President
> Developer Advocate @ Google Cloud Platform
>
> Blog: http://glaforge.appspot.com/
> Social: @glaforge / Google+