groovy-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Paul King <pa...@asert.com.au>
Subject Re: [PROGRESS REPORT 20161004]groovy-parser
Date Fri, 07 Oct 2016 10:23:21 GMT
On Fri, Oct 7, 2016 at 8:16 PM, Thibault Kruse <tibokruse@googlemail.com> wrote:
> On Tue, Oct 4, 2016 at 1:22 AM, daniel_sun <realbluesun@hotmail.com> wrote:
>> 2)
>> subprojects/groovy-groovysh/src/main/groovy/org/codehaus/groovy/tools/shell/commands/DocCommand.groovy(TODO
>> confirm: https://github.com/danielsun1106/groovy-parser/issues/5);
>
> So the current Groovy parser could handle this case?

There was an erroneous syntax error in that file - would have thrown
some kind of runtime exception (missing property or something) if that
branch was ever hit. Double quotes were changed to single for a
non-GString string (perhaps avoiding a codenarc warning?) but the
string already contained single quotes. Anyway, I flipped the inner
ones to be double quotes. So there is nothing to fix in the new
parser.

Paul.

Mime
View raw message