Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 5FC70200B6C for ; Sun, 28 Aug 2016 19:41:11 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 521F0160AB4; Sun, 28 Aug 2016 17:41:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 49AEF160AA6 for ; Sun, 28 Aug 2016 19:41:05 +0200 (CEST) Received: (qmail 8101 invoked by uid 500); 28 Aug 2016 17:41:04 -0000 Mailing-List: contact dev-help@groovy.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@groovy.apache.org Delivered-To: mailing list dev@groovy.apache.org Received: (qmail 8091 invoked by uid 99); 28 Aug 2016 17:41:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 28 Aug 2016 17:41:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id B8D1CC05BE for ; Sun, 28 Aug 2016 17:41:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.179 X-Spam-Level: * X-Spam-Status: No, score=1.179 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id WSIEzzwgFcIA for ; Sun, 28 Aug 2016 17:41:00 +0000 (UTC) Received: from mail-pa0-f46.google.com (mail-pa0-f46.google.com [209.85.220.46]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 360C15F613 for ; Sun, 28 Aug 2016 17:41:00 +0000 (UTC) Received: by mail-pa0-f46.google.com with SMTP id cy9so21058047pac.0 for ; Sun, 28 Aug 2016 10:41:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=tLXLvDD4MZuw+3o28aFr4/UmNEoXNZjo4hIKidVaxww=; b=ybd/Ke7mxdN09Wj6FNq1NAaUSDvlquv+4gsOw363MDeeslROL5eFqrcAx8hCKPsVV2 fCF66Gu6rnLRGt4Ax7vf8EJAi4YoYxzatqSfx35rKEABJjgcOk01r3cZt5LDTx1i8jUL eOmINlCkTVq0P6nSbYPO3SC+NzgHQ+elcVphOj9MQocwMvz0igc1FGTUulM+c7LLXlxP QSt0IdrquDpUL2q/eLLFgnWXOXp46jL9aw/fct+1PfeMu1Jw1qz8l9QVMbYVNk13b9Mj 5PZe2ltsIhCMWSW2ZFj/GA/Nj/b7Og06zIm+oMp1E7xZz/zKzaSB+3uZ3NwOju0/UMPu TtOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=tLXLvDD4MZuw+3o28aFr4/UmNEoXNZjo4hIKidVaxww=; b=Ry2QqF7/e5WP2j2dvvOSDcJNwLZ4Chyfa+2a9mSBApkhDAJk2hKvO0qCTAvG93W2Qj Nm1dOtJsUFa7ehlaquYHS2j68S7OtHwZmpMytE47S6fRVYqF5AgpkOVZp/PQgUIVfbhA bPfl6ZoGZOw0rd+mMhYVRCxOIrUOis3uAYnA0RImuoEdSdqqKXYFPKOl/T13GM525RzA WI5ia6W7lcru1M4wYyEnH994EqOsn0OA/dLvp1QQjK9cgaXT5yws220xCl4bV+msNVjP CGWicVu0vnzNH34PSQNSyirZIYmwFAoKZsBtmEjjp/BEypgTXMAuofVMfnKfXUXkmCzo G19w== X-Gm-Message-State: AE9vXwOtDEI5MBHHCcyX7xNrCBqFv6UuOSVaTPOQQ8o9Rm73gumTZR9M8gp0Y5477FK66XaJNx6ZZjlCdGjOPA== X-Received: by 10.66.229.39 with SMTP id sn7mr652552pac.80.1472406052680; Sun, 28 Aug 2016 10:40:52 -0700 (PDT) MIME-Version: 1.0 Received: by 10.66.251.104 with HTTP; Sun, 28 Aug 2016 10:40:52 -0700 (PDT) In-Reply-To: References: <57BE126D.7010605@gmx.org> <57BE821F.5030501@gmx.org> From: John Wagenleitner Date: Sun, 28 Aug 2016 10:40:52 -0700 Message-ID: Subject: Re: progress on executing tests with JDK9 status update To: dev@groovy.apache.org Content-Type: multipart/alternative; boundary=047d7b111f43bc3ae5053b253fd4 archived-at: Sun, 28 Aug 2016 17:41:11 -0000 --047d7b111f43bc3ae5053b253fd4 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Thu, Aug 25, 2016 at 7:57 AM, John Wagenleitner < john.wagenleitner@gmail.com> wrote: > > On Wed, Aug 24, 2016 at 10:29 PM, Jochen Theodorou > wrote: > >> On 25.08.2016 01:14, John Wagenleitner wrote: >> [...] >> >>> groovy.transform.stc.GenericsSTCTest > testGenericField FAILED >>> org.codehaus.groovy.control.Mu >>> ltipleCompilationErro >>> rsException: >>> startup failed: >>> TestScripttestGenericField257.groovy: 2: unable to resolve >>> class javax.xml.ws.Holder >>> @ line 2, column 13. >>> import javax.xml.ws.Holder >>> ^ >>> >>> >>> there are 2 of this kind of failure. The problem being that you nee= d >>> access to the module java.xml.ws or java.se.ee >>> to be able to get Holder class. I did not manag= e >>> to solve this one yet. "org.gradle.jvmargs=3D-ea -Xmx1G -addmods >>> java.se.ee " did not fix the failure. Makes me >>> wonder if that is then also used for tests. >>> >>> I had looked at that and I don't think the >>> GenericsSTCTest.testGenericField needs to rely on the java.xml.ws.Holde= r >>> class in order to be an effective test. I think it could be replaced b= y >>> class defined inline in the assertScript and then the dependency on the >>> java.xml module can be eliminated for core tests. >>> >> >> yes, but >> (a) what would be a good replacement? It should be nothing like a >> collection. And it should be in java7 >> > > > I think the following would work as a replacement assert for that test. > This fails on 2.1.3 (as specified in GROOVY-6135) and works on versions > since as does the current assert using javax.xml.ws.Holder. > > assertScript ''' > class MyClass { > static void main(args) { > Holder holder =3D new Holder() > holder.value =3D 5 > assert holder.value > 4 > } > private static class Holder { > T value > } > } > ''' > > >> (b) won=C2=B4t we get the same problem with groovy-xml later on? >> >> > > I think we've already hit this problem in groovy-xml (and it's dependent > projects like templates) and think that the new jdk9.gradle addresses it. > Unless necessary, it might be nice to keep core depending only on what's > available in the java.se module. > I updated the test to remove the dependence on javax.xml. The jigsaw version on the TC server is build 123 which is pretty old, with newer builds some of the failing shell tests pass. Would probably be good to update to the latest build if possible. --047d7b111f43bc3ae5053b253fd4 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On T= hu, Aug 25, 2016 at 7:57 AM, John Wagenleitner <john.wagenleitne= r@gmail.com> wrote:

On Wed, Aug 24, 2016 at 10:29 PM, Jochen Theodorou <blackd= rag@gmx.org> wrote:
On 25.08.2016 01:14, John Wagenleitner wrote:
[...]
=C2=A0 =C2=A0 =C2=A0 =C2=A0 groovy.transform.stc.GenericsSTCTest > = testGenericField FAILED
=C2=A0 =C2=A0 =C2=A0 =C2=A0 org.codehaus.groovy.control.Mu<= br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 <http://org.codehaus.groovy.control.Mu>ltipleCompilationErrorsException:
=C2=A0 =C2=A0 =C2=A0 =C2=A0 startup failed:
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0TestScripttestGenericField2= 57.groovy: 2: unable to resolve
=C2=A0 =C2=A0 =C2=A0 =C2=A0 class javax.xml.ws.Holder
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 @ line 2, column 13.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 import javax.xml.ws.Holder
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 ^


=C2=A0 =C2=A0 there are 2 of this kind of failure. The problem being that y= ou need
 =C2=A0 =C2=A0 access to the module java.xml.ws <http://java.xml.ws> or java.se.ee
=C2=A0 =C2=A0 <http://java.se.ee> to be able to get Holder class. I did= not manage
=C2=A0 =C2=A0 to solve this one yet. "org.gradle.jvmargs=3D-ea -Xmx1G = -addmods
 =C2=A0 =C2=A0 java.se.ee <http://java.se.ee>" did not fix the failure. M= akes me
=C2=A0 =C2=A0 wonder if that is then also used for tests.

I had looked at that and I don't think the
GenericsSTCTest.testGenericField needs to rely on the java.xml.ws.Hold= er
class in order to be an effective test.=C2=A0 I think it could be replaced = by
class defined inline in the assertScript and then the dependency on the
java.xml module can be eliminated for core tests.

yes, but
(a) what would be a good replacement? It should be nothing like a collectio= n. And it should be in java7
=C2=A0

I think the following would work as a replacement assert= for that test.=C2=A0 This fails on 2.1.3 (as specified in GROOVY-6135) and= works on versions since as does the current assert using javax.xml.ws.Hold= er.

assertScript ''' =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0
=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 class MyClass {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 static void main(args) {
=C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Holder<Integer&g= t; holder =3D new Holder<Integer>()
=C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 holder.value =3D 5
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 as= sert holder.value > 4
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 }
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 private static class Holder<T> {
=C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 T value
= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 } =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 } =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0
=C2=A0 =C2=A0 =C2= =A0 =C2=A0 '''
=C2=A0
(b) won=C2=B4t we get the same problem with groovy-xml later on?



I think we'v= e already hit this problem in groovy-xml (and it's dependent projects l= ike templates) and think that the new jdk9.gradle addresses it.=C2=A0 Unles= s necessary, it might be nice to keep core depending only on what's ava= ilable in the java.se modu= le.


I updated the test to remove the dependence on javax.xml.= =C2=A0

The jigsaw version on the TC server is build 123 which is pretty old, wit= h newer builds some of the failing shell tests pass.=C2=A0 Would probably b= e good to update to the latest build if possible.
--047d7b111f43bc3ae5053b253fd4--