groovy-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jochen Theodorou <blackd...@gmx.org>
Subject Re: Pull request to make private methods static when they are plain functions
Date Sun, 24 Apr 2016 19:46:07 GMT
On 24.04.2016 18:12, John Wagenleitner wrote:
> About to merge in PR 290 [1] and wanted to do a quick poll to see if
> there were any objections since it touches quite a few files across core
> and sub-modules.  Any objections to merging this into master?  And
> GROOVY_2_4_X?
>
> [1] https://github.com/apache/groovy/pull/290

I guess it is ok. I did see two package private methods made private 
instead of only private ones, but even those should be ok. so unless I 
did oversee something I do not really have any objection here.

bye Jochen

Mime
View raw message