Mailing-List: contact dev-help@groovy.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@groovy.apache.org
MIME-Version: 1.0
In-Reply-To: <git-pr-271-groovy@git.apache.org>
References: <git-pr-271-groovy@git.apache.org>
Date: Wed, 24 Feb 2016 17:30:21 +0100
Message-ID: 
 <CADQzvmknP1LUd_VLX8ymQtEJdXq5Mm0HzfSdNGMQPzi5+K_GaQ@mail.gmail.com>
Subject: Re: [GitHub] groovy pull request: Link to MrHaki's blog in
 TupleConstructor jav...
From: =?UTF-8?Q?C=C3=A9dric_Champeau?= <cedric.champeau@gmail.com>
To: dev@groovy.apache.org, notifications@groovy.apache.org
Content-Type: multipart/alternative; boundary=001a11c349d61205b1052c8695c3

--001a11c349d61205b1052c8695c3
Content-Type: text/plain; charset=UTF-8

I don't think linking to external resources like this is a good idea. We
don't own the end link, it can be dead very easily, especially in the
future. I would rather improve the documentation.

2016-02-24 17:25 GMT+01:00 pledbrook <git@git.apache.org>:

> GitHub user pledbrook opened a pull request:
>
>     https://github.com/apache/groovy/pull/271
>
>     Link to MrHaki's blog in TupleConstructor javadoc.
>
>     As discussed on Twitter, here's an example of linking to @mrhaki's
> blog from the javadocs so that people have ready access to more examples
> for certain classes. If this gets merged, I'll look into adding more.
>
> You can merge this pull request into a Git repository by running:
>
>     $ git pull https://github.com/pledbrook/incubator-groovy patch-01
>
> Alternatively you can review and apply these changes as the patch at:
>
>     https://github.com/apache/groovy/pull/271.patch
>
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
>     This closes #271
>
> ----
> commit 6741ce458c01cf8ab5df770a284d53a3657dd389
> Author: Peter Ledbrook <peter@cacoethes.co.uk>
> Date:   2016-02-24T16:23:07Z
>
>     Link to MrHaki's blog in TupleConstructor javadoc.
>
> ----
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>

--001a11c349d61205b1052c8695c3
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">I don&#39;t think linking to external resources like this =
is a good idea. We don&#39;t own the end link, it can be dead very easily, =
especially in the future. I would rather improve the documentation.</div><d=
iv class=3D"gmail_extra"><br><div class=3D"gmail_quote">2016-02-24 17:25 GM=
T+01:00 pledbrook <span dir=3D"ltr">&lt;<a href=3D"mailto:git@git.apache.or=
g" target=3D"_blank">git@git.apache.org</a>&gt;</span>:<br><blockquote clas=
s=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;pad=
ding-left:1ex">GitHub user pledbrook opened a pull request:<br>
<br>
=C2=A0 =C2=A0 <a href=3D"https://github.com/apache/groovy/pull/271" rel=3D"=
noreferrer" target=3D"_blank">https://github.com/apache/groovy/pull/271</a>=
<br>
<br>
=C2=A0 =C2=A0 Link to MrHaki&#39;s blog in TupleConstructor javadoc.<br>
<br>
=C2=A0 =C2=A0 As discussed on Twitter, here&#39;s an example of linking to =
@mrhaki&#39;s blog from the javadocs so that people have ready access to mo=
re examples for certain classes. If this gets merged, I&#39;ll look into ad=
ding more.<br>
<br>
You can merge this pull request into a Git repository by running:<br>
<br>
=C2=A0 =C2=A0 $ git pull <a href=3D"https://github.com/pledbrook/incubator-=
groovy" rel=3D"noreferrer" target=3D"_blank">https://github.com/pledbrook/i=
ncubator-groovy</a> patch-01<br>
<br>
Alternatively you can review and apply these changes as the patch at:<br>
<br>
=C2=A0 =C2=A0 <a href=3D"https://github.com/apache/groovy/pull/271.patch" r=
el=3D"noreferrer" target=3D"_blank">https://github.com/apache/groovy/pull/2=
71.patch</a><br>
<br>
To close this pull request, make a commit to your master/trunk branch<br>
with (at least) the following in the commit message:<br>
<br>
=C2=A0 =C2=A0 This closes #271<br>
<br>
----<br>
commit 6741ce458c01cf8ab5df770a284d53a3657dd389<br>
Author: Peter Ledbrook &lt;<a href=3D"mailto:peter@cacoethes.co.uk">peter@c=
acoethes.co.uk</a>&gt;<br>
Date:=C2=A0 =C2=A02016-02-24T16:23:07Z<br>
<br>
=C2=A0 =C2=A0 Link to MrHaki&#39;s blog in TupleConstructor javadoc.<br>
<br>
----<br>
<br>
<br>
---<br>
If your project is set up for it, you can reply to this email and have your=
<br>
reply appear on GitHub as well. If your project does not have this feature<=
br>
enabled and wishes so, or if the feature is enabled but not working, please=
<br>
contact infrastructure at <a href=3D"mailto:infrastructure@apache.org">infr=
astructure@apache.org</a> or file a JIRA ticket<br>
with INFRA.<br>
---<br>
</blockquote></div><br></div>

--001a11c349d61205b1052c8695c3--